Received-SPF: pass (google.com: domain of linux-kernel+bounces-107662-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <38fca2fa-11b2-4eb7-9e59-dc5d524d172e@amd.com>
Date: Tue, 19 Mar 2024 09:38:30 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 2/5] x86/kexec: do unconditional WBINVD in
 relocate_kernel()
Content-Language: en-US
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
 Kai Huang <kai.huang@intel.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, dave.hansen@intel.com,
 bp@alien8.de, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
 luto@kernel.org, peterz@infradead.org, rick.p.edgecombe@intel.com,
 ashish.kalra@amd.com, chao.gao@intel.com, bhe@redhat.com,
 nik.borisov@suse.com, pbonzini@redhat.com, seanjc@google.com
References: <cover.1710811610.git.kai.huang@intel.com>
 <e1d37efb8951eb1d38493687b10a21b23353e35a.1710811610.git.kai.huang@intel.com>
 <tvembdwwh4immxytlfzlhpvd42dlfsz7sddb7msk23kdduhu3t@ogpc66hklorv>
From: Tom Lendacky <thomas.lendacky@amd.com>
Autocrypt: addr=thomas.lendacky@amd.com; keydata=
 xsFNBFaNZYkBEADxg5OW/ajpUG7zgnUQPsMqWPjeAxtu4YH3lCUjWWcbUgc2qDGAijsLTFv1
 kEbaJdblwYs28z3chM7QkfCGMSM29JWR1fSwPH18WyAA84YtxfPD8bfb1Exwo0CRw1RLRScn
 6aJhsZJFLKyVeaPO1eequEsFQurRhLyAfgaH9iazmOVZZmxsGiNRJkQv4YnM2rZYi+4vWnxN
 1ebHf4S1puN0xzQsULhG3rUyV2uIsqBFtlxZ8/r9MwOJ2mvyTXHzHdJBViOalZAUo7VFt3Fb
 aNkR5OR65eTL0ViQiRgFfPDBgkFCSlaxZvc7qSOcrhol160bK87qn0SbYLfplwiXZY/b/+ez
 0zBtIt+uhZJ38HnOLWdda/8kuLX3qhGL5aNz1AeqcE5TW4D8v9ndYeAXFhQI7kbOhr0ruUpA
 udREH98EmVJsADuq0RBcIEkojnme4wVDoFt1EG93YOnqMuif76YGEl3iv9tYcESEeLNruDN6
 LDbE8blkR3151tdg8IkgREJ+dK+q0p9UsGfdd+H7pni6Jjcxz8mjKCx6wAuzvArA0Ciq+Scg
 hfIgoiYQegZjh2vF2lCUzWWatXJoy7IzeAB5LDl/E9vz72cVD8CwQZoEx4PCsHslVpW6A/6U
 NRAz6ShU77jkoYoI4hoGC7qZcwy84mmJqRygFnb8dOjHI1KxqQARAQABzSZUb20gTGVuZGFj
 a3kgPHRob21hcy5sZW5kYWNreUBhbWQuY29tPsLBmQQTAQoAQwIbIwcLCQgHAwIBBhUIAgkK
 CwQWAgMBAh4BAheAAhkBFiEE3Vil58OMFCw3iBv13v+a5E8wTVMFAmWDAegFCRKq1F8ACgkQ
 3v+a5E8wTVOG3xAAlLuT7f6oj+Wud8dbYCeZhEX6OLfyXpZgvFoxDu62OLGxwVGX3j5SMk0w
 IXiJRjde3pW+Rf1QWi/rbHoaIjbjmSGXvwGw3Gikj/FWb02cqTIOxSdqf7fYJGVzl2dfsAuj
 aW1Aqt61VhuKEoHzIj8hAanlwg2PW+MpB2iQ9F8Z6UShjx1PZ1rVsDAZ6JdJiG1G/UBJGHmV
 kS1G70ZqrqhA/HZ+nHgDoUXNqtZEBc9cZA9OGNWGuP9ao9b+bkyBqnn5Nj+n4jizT0gNMwVQ
 h5ZYwW/T6MjA9cchOEWXxYlcsaBstW7H7RZCjz4vlH4HgGRRIpmgz29Ezg78ffBj2q+eBe01
 7AuNwla7igb0mk2GdwbygunAH1lGA6CTPBlvt4JMBrtretK1a4guruUL9EiFV2xt6ls7/YXP
 3/LJl9iPk8eP44RlNHudPS9sp7BiqdrzkrG1CCMBE67mf1QWaRFTUDPiIIhrazpmEtEjFLqP
 r0P7OC7mH/yWQHvBc1S8n+WoiPjM/HPKRQ4qGX1T2IKW6VJ/f+cccDTzjsrIXTUdW5OSKvCG
 6p1EFFxSHqxTuk3CQ8TSzs0ShaSZnqO1LBU7bMMB1blHy9msrzx7QCLTw6zBfP+TpPANmfVJ
 mHJcT3FRPk+9MrnvCMYmlJ95/5EIuA1nlqezimrwCdc5Y5qGBbbOwU0EVo1liQEQAL7ybY01
 hvEg6pOh2G1Q+/ZWmyii8xhQ0sPjvEXWb5MWvIh7RxD9V5Zv144EtbIABtR0Tws7xDObe7bb
 r9nlSxZPur+JDsFmtywgkd778G0nDt3i7szqzcQPOcR03U7XPDTBJXDpNwVV+L8xvx5gsr2I
 bhiBQd9iX8kap5k3I6wfBSZm1ZgWGQb2mbiuqODPzfzNdKr/MCtxWEsWOAf/ClFcyr+c/Eh2
 +gXgC5Keh2ZIb/xO+1CrTC3Sg9l9Hs5DG3CplCbVKWmaL1y7mdCiSt2b/dXE0K1nJR9ZyRGO
 lfwZw1aFPHT+Ay5p6rZGzadvu7ypBoTwp62R1o456js7CyIg81O61ojiDXLUGxZN/BEYNDC9
 n9q1PyfMrD42LtvOP6ZRtBeSPEH5G/5pIt4FVit0Y4wTrpG7mjBM06kHd6V+pflB8GRxTq5M
 7mzLFjILUl9/BJjzYBzesspbeoT/G7e5JqbiLWXFYOeg6XJ/iOCMLdd9RL46JXYJsBZnjZD8
 Rn6KVO7pqs5J9K/nJDVyCdf8JnYD5Rq6OOmgP/zDnbSUSOZWrHQWQ8v3Ef665jpoXNq+Zyob
 pfbeihuWfBhprWUk0P/m+cnR2qeE4yXYl4qCcWAkRyGRu2zgIwXAOXCHTqy9TW10LGq1+04+
 LmJHwpAABSLtr7Jgh4erWXi9mFoRABEBAAHCwXwEGAEKACYCGwwWIQTdWKXnw4wULDeIG/Xe
 /5rkTzBNUwUCZYMCBQUJEqrUfAAKCRDe/5rkTzBNU7pAD/9MUrEGaaiZkyPSs/5Ax6PNmolD
 h0+Q8Sl4Hwve42Kjky2GYXTjxW8vP9pxtk+OAN5wrbktZb3HE61TyyniPQ5V37jto8mgdslC
 zZsMMm2WIm9hvNEvTk/GW+hEvKmgUS5J6z+R5mXOeP/vX8IJNpiWsc7X1NlJghFq3A6Qas49
 CT81ua7/EujW17odx5XPXyTfpPs+/dq/3eR3tJ06DNxnQfh7FdyveWWpxb/S2IhWRTI+eGVD
 ah54YVJcD6lUdyYB/D4Byu4HVrDtvVGUS1diRUOtDP2dBJybc7sZWaIXotfkUkZDzIM2m95K
 oczeBoBdOQtoHTJsFRqOfC9x4S+zd0hXklViBNQb97ZXoHtOyrGSiUCNXTHmG+4Rs7Oo0Dh1
 UUlukWFxh5vFKSjr4uVuYk7mcx80rAheB9sz7zRWyBfTqCinTrgqG6HndNa0oTcqNI9mDjJr
 NdQdtvYxECabwtPaShqnRIE7HhQPu8Xr9adirnDw1Wruafmyxnn5W3rhJy06etmP0pzL6frN
 y46PmDPicLjX/srgemvLtHoeVRplL9ATAkmQ7yxXc6wBSwf1BYs9gAiwXbU1vMod0AXXRBym
 0qhojoaSdRP5XTShfvOYdDozraaKx5Wx8X+oZvvjbbHhHGPL2seq97fp3nZ9h8TIQXRhO+aY
 vFkWitqCJg==
In-Reply-To: <tvembdwwh4immxytlfzlhpvd42dlfsz7sddb7msk23kdduhu3t@ogpc66hklorv>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WTdtRVRwc1FiL3YwUVZ3YVBwQk5heEZjOUU1YWJ4cXhNVUdnb29EdmUycmJk?=
 =?utf-8?B?RjhsYTRjMG1uQXlxY0VsMEVsQjdEWWYvNWF6Y3B2TkFING9jelJ1SmJRYTBG?=
 =?utf-8?B?N3NKRU1ublMyWXNVYVo3dm8rN28zdFNnKzY1WHVYRGEwTTVMVDdpeEM3ZVNr?=
 =?utf-8?B?T2VkVUlkZ1JrSno0QlN6TUZKaUhiVXJFVVkybG5qMVhvSEp3ZUU0amdGeGdu?=
 =?utf-8?B?a2xWUzU3allqM2NwSTU0dHViYmxkdDQxZEVBT3J6ZGFYUXZnby9XT28ybXNa?=
 =?utf-8?B?Qi9kNkt5ZE5GNVVUTGZoYmNwWjd4dnFIOVdSakh4UDBVL0RXcUZkYTNac1la?=
 =?utf-8?B?TW5MWGEyd3JSODFLTkdiUmtHajVmUXMwRlU0cG9KdXpxdG12NUFkV0FtK2cy?=
 =?utf-8?B?ZlRveHhrY2xMUU9LZ1ZLK1lTdTYxamdlaUpRYXJWWEExYzBuZXE1em1JUVNH?=
 =?utf-8?B?SUhBQXVnRmpxamplOFEyaFE4bEpLT3ErU3JuVS9zczF4NngrZzEveWxRQ2c1?=
 =?utf-8?B?anoxUU5UL3JHblBEMGNHUmZIYkNQSDJBSnRTNmNyZ2hNOFYyOVRXbnJTOHls?=
 =?utf-8?B?d3IrRHFnWWFhSFpEWjVvMHRkNWMySDkvdGc0T1lsa0t1VkRUbTdjb0xsOS9a?=
 =?utf-8?B?Q2pXSmgxT3M1TUh3Z3ZjcjJzMHBDZ3p2TEJmbGtSQzYyQXVTT3JibDBzOG10?=
 =?utf-8?B?dFVwbklFNk9VWmZMMW81dWtJQk1tcGhheXZ3dE9OWjMrWDltM3ZEcVFVMUlW?=
 =?utf-8?B?azlMaDN2elQ1ckk4VjJ5Y2xOVy9MaE5iSW9rRjY5cUJOYVk2aWxMLy9abm1l?=
 =?utf-8?B?Ykozdmh0YVFqbEhtZG1rb1VRUkVqUzJZeU5oc2JCMFJjaFVVWE5mZTA4enpq?=
 =?utf-8?B?UmJWV3hoVS9sZFM1VGRBQ1A2bHhMcDFRR3NYMFBTTnJwdW9MYzlKVTBuUWE0?=
 =?utf-8?B?MVdDU3lFMEJIeU14Q0MwR0xJUElzMUd0VlBONEUzQXBYUXM3VWVqOEs0ck1z?=
 =?utf-8?B?S1FsM1lTSVl5SmJVZ1ZQLzVrMHZ0ZUp1SjNHQWI0QWFJdGpCSnVSdmt6Mk01?=
 =?utf-8?B?MTM3dFpFNmhKSkNQZkM3SGdIVUszOUVBUFhRbWdtOFJRZWsvemVsaUFoRFov?=
 =?utf-8?B?K09XK2lxemRWS0JzaHZ5MFcydzQwS3F2TENCUDljZjRCZlgyT3A2cTV6ZVZ2?=
 =?utf-8?B?a25WWVcwWUZKM0k5R1lWd2gwM3VCeUUyejVMU0lqSnBoaUpObzNNN1lCbkVT?=
 =?utf-8?B?UllZYS9uaDhyYVpHbmtmbldHTTd4YXp3cEtQSCtxaE5oMU1CT21NUzJSemhB?=
 =?utf-8?B?U0dyWVI0b2ZuSXJwSEViLzdFK051WFFBU00vcHhNNEFxMjQ0TEhqU3p4anZP?=
 =?utf-8?B?amZDQVZ6SldPdXptUnoyTnJUcGRGZ1RJN0Z4bEM1VUdlZXVLMVhLQmhNYi9q?=
 =?utf-8?B?U3FpYld5SnJFcGVsVDFUZnJ6aml3djRrWE80TUtpZUdjYWhDbU1iRmpwMGE4?=
 =?utf-8?B?MWtqQWJyUG5xNWNkNmZWZzZDM1RNeXdET1huMzNiczdHOGFGVkhWMXFGUHBJ?=
 =?utf-8?B?eThrdldQU28zcXFMUUZWSlgyQmZaS1pKYklpS3Yra0ZFUTA0SHlKWEJDaTFx?=
 =?utf-8?B?U214akFNUkN3Zll2REZ3NjdhTTJLRkxZdkJFOTdpMi95UWxEUm9mbUt0MmRz?=
 =?utf-8?B?YUcrZmtlY3YzSHl5TVhrb1JBYVY0RzFaWmNsVzlVei81OU1wWHVPeXhneVNt?=
 =?utf-8?B?czU4bmtwQ3BqYXlyTVpjMFlJcFM0T0t3NWNZWTBiZUxUeDJ3T0ZxcjFPR01C?=
 =?utf-8?B?c3JXaE4vdFFIeG84YUp0SzdmaWZPU0gvWkNibWI2blJYREh6ODZqZ0VoM3c4?=
 =?utf-8?B?dmtyaGV3RTV3M0JXSkNnenF4REprKzcrS0R6RzNCZnhDQTFUZmp3WkU4SmF1?=
 =?utf-8?B?WWh4a00zSmg0TkRpZGNsQmlYcEVzbk4xaW5QZk9PbE0yVnhsUGN6RzZLQkFw?=
 =?utf-8?B?bE1BVkNzVWdvVlAvWDVPUlMrWVVlTHEzV016S1pKRk5qVlcyRjhXSHJGaHBh?=
 =?utf-8?B?WnJ4R0gyNUx0WTFZQUQvQWVQSXk3SVhFYW9id3FraXNqM3Vad2pYcnhaWlFy?=
 =?utf-8?Q?IeX6kSgWDDyMO5jPu+ycrs61i?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e823b6d6-fe75-41b6-5344-08dc4822410c
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2024 14:38:33.8943
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oLKnOXymcrao38UwDGhXcPZ6U1lDi0vzt8ELfDb281pt/PdLSvgmsl7BjP8toaxsCRgGQZhktgfw95LpP5V3VQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7517

On 3/19/24 06:13, Kirill A. Shutemov wrote:
> On Tue, Mar 19, 2024 at 01:48:45AM +0000, Kai Huang wrote:
>> Both SME and TDX can leave caches in incoherent state due to memory
>> encryption.  During kexec, the caches must be flushed before jumping to
>> the second kernel to avoid silent memory corruption to the second kernel.
>>
>> During kexec, the WBINVD in stop_this_cpu() flushes caches for all
>> remote cpus when they are being stopped.  For SME, the WBINVD in
>> relocate_kernel() flushes the cache for the last running cpu (which is
>> executing the kexec).
>>
>> Similarly, for TDX after stopping all remote cpus with cache flushed, to
>> support kexec, the kernel needs to flush cache for the last running cpu.
>>
>> Make the WBINVD in the relocate_kernel() unconditional to cover both SME
>> and TDX.
> 
> Nope. It breaks TDX guest. WBINVD triggers #VE for TDX guests.

Ditto for SEV-ES/SEV-SNP, a #VC is generated and crashes the guest.

Thanks,
Tom

>