Received-SPF: pass (google.com: domain of linux-kernel+bounces-107678-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <927c02e6-70cc-4af1-8e46-c4816583a3e7@amd.com>
Date: Tue, 19 Mar 2024 09:54:21 -0500
User-Agent: Mozilla Thunderbird Beta
Subject: Re: [PATCH v13 2/4] dt-bindings: remoteproc: add Tightly Coupled
 Memory (TCM) bindings
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 andersson@kernel.org, mathieu.poirier@linaro.org, robh+dt@kernel.org,
 krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
 michal.simek@amd.com, ben.levinsky@amd.com
Cc: linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
 Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
References: <20240311175926.1625180-1-tanmay.shah@amd.com>
 <20240311175926.1625180-3-tanmay.shah@amd.com>
 <84923a4e-6c8e-45b7-b7a8-1a4deeb72347@linaro.org>
Content-Language: en-US
From: Tanmay Shah <tanmay.shah@amd.com>
In-Reply-To: <84923a4e-6c8e-45b7-b7a8-1a4deeb72347@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YkVaUjFLd0hVRkorb3lWZWYzK0xqUDdaM2MxVzVGczdselpBUFNRVnNISFJQ?=
 =?utf-8?B?TnFkSXozT0JxRVZIait2dTJBeUdLQWNtV1lkSjVMOWFtM3FOK2hoMStweE1F?=
 =?utf-8?B?cVVCaUVVa3Z0U1kyVmpQcXRjWEY1RWIvM1FaUUlBc1ZyL3Y4YU5oVGVRelJQ?=
 =?utf-8?B?dE5YR0tFRWJNQmxsSmliNUh4NEFndnhDblpVR1cwMklQM0hTNXRJUTdNVytT?=
 =?utf-8?B?cFQxWlJSTDkxcEI0QTRXYUVOYVNQOUJ5RDNaUWVGMjJqbkNHUmlQbWR1Y1k0?=
 =?utf-8?B?dG16cGdQM0ZwdDhVYnc3Q283K3VMRjUwc0RMbStNcmxWMDNKOUltb2hLNEx3?=
 =?utf-8?B?S2FNZmRyWFlzQ0NiOTJZenR5VVpxUFpiZEdYSUErQk5GTTZ2ek1jaFh0RkY0?=
 =?utf-8?B?aFlYcHZRMTJ2T2I3dDI0MTRPVnlJMHAzM2FhcldLaVc5L29qWlhWNkNIaUZ5?=
 =?utf-8?B?RlVPSFRhcWZVY1ZOc2ZBUVRzQjU2RGJmMmVkM09QSWRoU2dvVk9HYjZNb0tB?=
 =?utf-8?B?cFlPTHBTM2pob0plc2dzb1QyNHhPUHZidlFyMEFWN2pBWlgwUm03OTZuOWZw?=
 =?utf-8?B?QkNwUDVyUFR4dUNMRWl4OUs5RW96Vkcxa3ZVOUNIR250NjN1SlM1WWhSZ1Vw?=
 =?utf-8?B?bWZuNEVYSzFrZHdWeWZEM1ZORWd5SUtzSlMwc00waERBVUFkak1uY1VLcC9Y?=
 =?utf-8?B?cCtpTGkvcG04TlVmc0NOQnF1V1ZjaGloV1dGeVBjamsvYk1uRzRxRjZXY2hR?=
 =?utf-8?B?ak9zTm96Tk5rU2U1MGQ1RFlmWHVnTXk4bnQ0aGs2SGJveGVKbW93dDVsNUw5?=
 =?utf-8?B?UTNUbURRcm0xOEkybmdob2lzdVY0UkpzN0pkSFE5Y1d2WHZtMHJ3a281RVFs?=
 =?utf-8?B?K01iQjFvUlRzK01pWVJRSVd2eWRqbTlnWXdjS0liWjB3NHdHTXVqWFlhRHYy?=
 =?utf-8?B?Zll1RWM5WmxKbzZ3N2FFdEtuZUFKRmYvclVwK0pTaGFiVjlNQWFrelE1U1hM?=
 =?utf-8?B?bHIxOG5haDh4NzB0RThaSzB3N01JVXM4dmJNejkwanpRVDIyWGhHSnFYVFdO?=
 =?utf-8?B?MUY5ZndRemVpdFRVbFl3dnhEUno0Ym1OWWprS3RrSnBBblNHazJCcXhGUi9t?=
 =?utf-8?B?QUhHTXdPL0lXMHFmbTdhL1poTTFTaE9OeDBteXpZb1dQRjVnMC9PNGM1anVh?=
 =?utf-8?B?cjllZXFHRzZnazNySG9WWXc0cjk4TmNMZjZlckdNUHJmWVJhREtsaWg5VXFQ?=
 =?utf-8?B?bVAvc2pySTBySDlQWVozTHkra1lHekdaeXliV2lUcEp0eXV5dklMQmNUYUV4?=
 =?utf-8?B?Nm8zWUFEd2lRazZZS3hsR05yVzNnR0tKdmlXUHRsWDI1dmtleVY3N0ZNZHpx?=
 =?utf-8?B?RTJFVzduK1NpL1Ezd1Y3UWlSc0w1Z1hOVUZGUGluRCtheExkUE5FWFlZMWZD?=
 =?utf-8?B?aFFuNXFCdUJpVGZVUVdVMFNkajIvZlBkOVppaitnR3pGb3BNNlhRbUFpdFFE?=
 =?utf-8?B?V3ZQaTRNYk1zbE5zcFFVSUJWOHhOck1aOVp4NUg3OTNCYzZDQkJrbFppTGNS?=
 =?utf-8?B?Q3hnaHdKUlZOcFoyZDdQRUFUdnRnQjRESFI2NVlrQkQrTkRTbVVSVlU1dnFP?=
 =?utf-8?B?ZzJsSS8wVU1RaGlmcGJlcGR5TmZqTWY0NnVodVBFd0JkVXZ3cldnQlFkb0w0?=
 =?utf-8?B?SC9tZDUwV0dWcS9JODNxM2hUVEkyOW9DOTU4U01lb2VpVjlPUHVDNHcyTzAz?=
 =?utf-8?B?NUwrWTBHMS83SkFqVEFKMjhSa1R5a2dETDlJNGVpendQVG1kZXFLMDN5RnNS?=
 =?utf-8?B?SjlSSVd2RTJMNC9SVVM1eUtEOWxRdGJtNy9ibU9oK3c4dXRHSzhQMFVkVFo5?=
 =?utf-8?B?SEdYYUY0T3paYUt6Nmg0VDBmbHZVTHZHdVhyM2RGS0YwOWdOWktJSEV3MFh6?=
 =?utf-8?B?bCtnTEtwNVN6SE9DYTFXUHFRVlpqRFN3YjZjbzFXKzQvSHhkdkJpT1p0TExa?=
 =?utf-8?B?ZHhXV1hzUnhPeVljR3NCSkdBUFQwOTF4bDF3dUJxZVYwMFlON1UvcjlQQUxu?=
 =?utf-8?B?VXZab25UNGRPejZlT092QWtKa2U3UE1WWWNCRGc3S1FXejFpajNUMlJ0RHhO?=
 =?utf-8?Q?Un7Fiyd2hIDm1pYg1bhPQx4Lo?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5031c4ef-22ce-48b0-4a9f-08dc482477cb
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5874.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2024 14:54:24.6884
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yUV0QoYmr+bJXvlAQe79MlEvGmnD+kBnyjfpYzFvtS63vU0eGqIex7rLBP36Uork
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7365


On 3/19/24 12:29 AM, Krzysztof Kozlowski wrote:
> On 11/03/2024 18:59, Tanmay Shah wrote:
>> From: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
>> 
>> Introduce bindings for TCM memory address space on AMD-xilinx Zynq
>> UltraScale+ platform. It will help in defining TCM in device-tree
>> and make it's access platform agnostic and data-driven.
>> 
>> Tightly-coupled memories(TCMs) are low-latency memory that provides
>> predictable instruction execution and predictable data load/store
>> timing. Each Cortex-R5F processor contains two 64-bit wide 64 KB memory
>> banks on the ATCM and BTCM ports, for a total of 128 KB of memory.
>> 
>> The TCM resources(reg, reg-names and power-domain) are documented for
>> each TCM in the R5 node. The reg and reg-names are made as required
>> properties as we don't want to hardcode TCM addresses for future
>> platforms and for zu+ legacy implementation will ensure that the
>> old dts w/o reg/reg-names works and stable ABI is maintained.
>> 
>> It also extends the examples for TCM split and lockstep modes.
>> 
>> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
>> Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
>> ---
> 
> I responded under my reviewed-tag, but to be clear, also here:
> 
> This patch has is not ready. Please do not merge.
> 

Glad we could catch this before merging this.
I will wait for your reply on other thread for refactoring.

> Best regards,
> Krzysztof
>