Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753308AbYAICEb (ORCPT ); Tue, 8 Jan 2008 21:04:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750836AbYAICEX (ORCPT ); Tue, 8 Jan 2008 21:04:23 -0500 Received: from ozlabs.org ([203.10.76.45]:58217 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750830AbYAICEW (ORCPT ); Tue, 8 Jan 2008 21:04:22 -0500 From: Rusty Russell To: Zach Brown Subject: Re: [PATCH 5/6] syslets: add generic syslets infrastructure Date: Wed, 9 Jan 2008 13:03:57 +1100 User-Agent: KMail/1.9.6 (enterprise 0.20070907.709405) Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Ingo Molnar , Ulrich Drepper , Arjan van de Ven , Andrew Morton , Alan Cox , Evgeniy Polyakov , "David S. Miller" , Suparna Bhattacharya , Davide Libenzi , Jens Axboe , Thomas Gleixner , Dan Williams , Jeff Moyer , Simon Holm Thogersen , suresh.b.siddha@intel.com References: <1196983219534-git-send-email-zach.brown@oracle.com> <1196983219370-git-send-email-zach.brown@oracle.com> <11969832192130-git-send-email-zach.brown@oracle.com> In-Reply-To: <11969832192130-git-send-email-zach.brown@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200801091303.58920.rusty@rustcorp.com.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1069 Lines: 25 On Friday 07 December 2007 10:20:18 Zach Brown wrote: > The indirect syslet arguments specify where to store the completion and > what function in userspcae to return to once the syslet has been executed. > The details of how we pass the indirect syslet arguments needs help. Hi Zach, Firstly, why not just specify an address for the return value and be done with it? This infrastructure seems overkill, and you can always extend later if required. Secondly, you really should allow integration with an eventfd so you don't make the posix AIO mistake of providing a poll-incompatible interface. Finally, and probably most alarmingly, AFAICT randomly changing TID will break all threaded programs, which means this won't be fitted into existing code bases, making it YA niche Linux-only API 8( Cheers, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/