Received-SPF: pass (google.com: domain of linux-kernel+bounces-107710-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 19 Mar 2024 16:27:36 +0100
From: Joel Granados <j.granados@samsung.com>
To: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>
CC: "Eric W. Biederman" <ebiederm@xmission.com>, Luis Chamberlain
	<mcgrof@kernel.org>, Kees Cook <keescook@chromium.org>,
	<linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 3/4] sysctl: drop now unnecessary out-of-bounds check
Message-ID: <20240319152736.mpgpahyyoiaryucn@joelS2.panther.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
	protocol="application/pgp-signature"; boundary="nlgf7jyuw2vaaq5p"
Content-Disposition: inline
In-Reply-To: <20240222-sysctl-empty-dir-v1-3-45ba9a6352e8@weissschuh.net>
CMS-TYPE: 201P
References: <20240222-sysctl-empty-dir-v1-0-45ba9a6352e8@weissschuh.net>
	<CGME20240222070824eucas1p2e176acc2f85f341f388a900eb35f7fa0@eucas1p2.samsung.com>
	<20240222-sysctl-empty-dir-v1-3-45ba9a6352e8@weissschuh.net>

--nlgf7jyuw2vaaq5p
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 22, 2024 at 08:07:38AM +0100, Thomas Wei=DFschuh wrote:
> The type field is now part of the header so
> sysctl_is_perm_empty_ctl_header() can safely be executed even without
> any ctl_tables.

Only comments on the commit message.
1. Can you please put this and your 4/4 patch together. Since 4/4 comes
   is a result of this 3/4 patch, then they can be in one.
2. Please re-write the commit message to state what you did: Something
   like : "Remove the now unneeded check for ctl_table_size; it is safe
   to do so as it is now part of ctl_table_header.
3. Remember to mention the removal of the sentinel when you merge 3/4
   and 4/4

>=20
> Signed-off-by: Thomas Wei=DFschuh <linux@weissschuh.net>
> ---
>  fs/proc/proc_sysctl.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>=20
> diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c
> index fde7a2f773f0..4cdf98c6a9a4 100644
> --- a/fs/proc/proc_sysctl.c
> +++ b/fs/proc/proc_sysctl.c
> @@ -232,8 +232,7 @@ static int insert_header(struct ctl_dir *dir, struct =
ctl_table_header *header)
>  		return -EROFS;
> =20
>  	/* Am I creating a permanently empty directory? */
> -	if (header->ctl_table_size > 0 &&
> -	    sysctl_is_perm_empty_ctl_header(header)) {
> +	if (sysctl_is_perm_empty_ctl_header(header)) {
>  		if (!RB_EMPTY_ROOT(&dir->root))
>  			return -EINVAL;
>  		sysctl_set_perm_empty_ctl_header(dir_h);
>=20
> --=20
> 2.43.2
>=20

--=20

Joel Granados

--nlgf7jyuw2vaaq5p
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmX5rucACgkQupfNUreW
QU/CEwv/XMjKtYlwmQtmbNIX6XHAb/Vylqr2p/XkMeSmWICOxe+59VJGKyhVLY76
e6z9IRpS42qH+fkx7DeP4KRDa5PuYX6UsFbhYEqXIJT6ep+Sji2XdRkRCxfVjvzc
P4iAejyZEcmFEMuEQ2oVhaAk0E1ZaMCrNe1hyvJ5xZzBCSOZv700Upasd0y9HTOW
CiG+x54R93+zLzzEROpRNqRYkObDzZJ8HWoHe2DZGNKRRtgkeNPG5kkE+mRsq0Dr
AuepdMyISHtBY6FdxIcpj2bAZxfGjOO21KU28bmgtBDngu+OMhFYfApRUlJ4R3Rk
WAOkq67ttnCkx857TRVWb0MpIjUlVs/a3J7LnoC8CLQ2CpgEJ4L71L7cJEs7h6af
CbdkWp+fjZW7C4N5HyhgXGbDYiQAYNvKjrAF5q/g0L+YztU8VxTJiCdrIMjhWEdA
9ooECsSlozx2evuTDn+WdmSnZbZmdxzhLMgTgQ4nVnNJxi13D0zGuHV129k63UD+
b1wVpBpU
=a/Sv
-----END PGP SIGNATURE-----

--nlgf7jyuw2vaaq5p--