Received-SPF: pass (google.com: domain of linux-kernel+bounces-107712-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240319-ad7944-cleanups-v2-1-50e77269351b@baylibre.com> <CAHp75VeO_=r_pMBUTaQQYKDRAV-OVfTnPYPwV8f7KDzOhaBCvQ@mail.gmail.com>
In-Reply-To: <CAHp75VeO_=r_pMBUTaQQYKDRAV-OVfTnPYPwV8f7KDzOhaBCvQ@mail.gmail.com>
From: David Lechner <dlechner@baylibre.com>
Date: Tue, 19 Mar 2024 10:28:31 -0500
Message-ID: <CAMknhBETEP123=EHycGtFEJjQ+NPssLXmw9ZdDoY8CRsWiSxVQ@mail.gmail.com>
Subject: Re: [PATCH v2] iio: adc: ad7944: simplify adi,spi-mode property parsing
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>, Michael Hennerich <michael.hennerich@analog.com>, 
	=?UTF-8?B?TnVubyBTw6E=?= <nuno.sa@analog.com>, linux-iio@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 19, 2024 at 10:01=E2=80=AFAM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Tue, Mar 19, 2024 at 4:28=E2=80=AFPM David Lechner <dlechner@baylibre.=
com> wrote:
> >
> > This simplifies the adi,spi-mode property parsing by using
> > device_property_match_property_string() instead of two separate
> > functions. Also, the error return value is now more informative
> > in cases where there was problem parsing the property.
>
> a problem
>
> ...
>
> > +       ret =3D device_property_match_property_string(dev, "adi,spi-mod=
e",
> > +                                                   ad7944_spi_modes,
> > +                                                   ARRAY_SIZE(ad7944_s=
pi_modes));
> > +       if (ret < 0) {
> > +               if (ret !=3D -EINVAL)
> > +                       return dev_err_probe(dev, ret,
> > +                                            "getting adi,spi-mode prop=
erty failed\n");
>
> > -               adc->spi_mode =3D ret;
> > -       } else {
>
> Actually we may even leave these unchanged
>
> >                 /* absence of adi,spi-mode property means default mode =
*/
> >                 adc->spi_mode =3D AD7944_SPI_MODE_DEFAULT;
> > +       } else {
> > +               adc->spi_mode =3D ret;
> >         }
>
>        ret =3D device_property_match_property_string(dev, "adi,spi-mode",
>                                                    ad7944_spi_modes,
>
> ARRAY_SIZE(ad7944_spi_modes));
>        if (ret >=3D 0) {
>                adc->spi_mode =3D ret;
>        } else if (ret !=3D -EINVAL) {
>                        return dev_err_probe(dev, ret,
>                                             "getting adi,spi-mode
> property failed\n");
>        } else {
>                /* absence of adi,spi-mode property means default mode */
>                adc->spi_mode =3D AD7944_SPI_MODE_DEFAULT;
>        }
>
> But I can admit this is not an often used approach.
>

I think Jonathan prefers to have the error path first, so I would like
to wait and see if he has an opinion here.