Received-SPF: pass (google.com: domain of linux-kernel+bounces-107733-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 19 Mar 2024 16:44:44 +0100
From: Joel Granados <j.granados@samsung.com>
To: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>
CC: "Eric W. Biederman" <ebiederm@xmission.com>, Luis Chamberlain
	<mcgrof@kernel.org>, Kees Cook <keescook@chromium.org>,
	<linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 1/4] sysctl: drop sysctl_is_perm_empty_ctl_table
Message-ID: <20240319154444.gjdg33aa6px7kmkc@joelS2.panther.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
	protocol="application/pgp-signature"; boundary="rhjcpktngvcxuw73"
Content-Disposition: inline
In-Reply-To: <20240222-sysctl-empty-dir-v1-1-45ba9a6352e8@weissschuh.net>
CMS-TYPE: 201P
References: <20240222-sysctl-empty-dir-v1-0-45ba9a6352e8@weissschuh.net>
	<CGME20240222070825eucas1p2dc50c8ef29cae3e43bee012773a19824@eucas1p2.samsung.com>
	<20240222-sysctl-empty-dir-v1-1-45ba9a6352e8@weissschuh.net>

--rhjcpktngvcxuw73
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 22, 2024 at 08:07:36AM +0100, Thomas Wei=DFschuh wrote:
> It is used only twice and those callers are simpler with
> sysctl_is_perm_empty_ctl_header().
> So use this sibling function.
Can you please add a comment relating this to the constification effort.
>=20
> Signed-off-by: Thomas Wei=DFschuh <linux@weissschuh.net>
> ---
>  fs/proc/proc_sysctl.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>=20
> diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c
> index 37cde0efee57..2f4d4329d83d 100644
> --- a/fs/proc/proc_sysctl.c
> +++ b/fs/proc/proc_sysctl.c
> @@ -48,10 +48,8 @@ struct ctl_table_header *register_sysctl_mount_point(c=
onst char *path)
>  }
>  EXPORT_SYMBOL(register_sysctl_mount_point);
> =20
> -#define sysctl_is_perm_empty_ctl_table(tptr)		\
> -	(tptr[0].type =3D=3D SYSCTL_TABLE_TYPE_PERMANENTLY_EMPTY)
>  #define sysctl_is_perm_empty_ctl_header(hptr)		\
> -	(sysctl_is_perm_empty_ctl_table(hptr->ctl_table))
> +	(hptr->ctl_table[0].type =3D=3D SYSCTL_TABLE_TYPE_PERMANENTLY_EMPTY)
>  #define sysctl_set_perm_empty_ctl_header(hptr)		\
>  	(hptr->ctl_table[0].type =3D SYSCTL_TABLE_TYPE_PERMANENTLY_EMPTY)
>  #define sysctl_clear_perm_empty_ctl_header(hptr)	\
> @@ -233,7 +231,7 @@ static int insert_header(struct ctl_dir *dir, struct =
ctl_table_header *header)
> =20
>  	/* Am I creating a permanently empty directory? */
>  	if (header->ctl_table_size > 0 &&
> -	    sysctl_is_perm_empty_ctl_table(header->ctl_table)) {
> +	    sysctl_is_perm_empty_ctl_header(header)) {
>  		if (!RB_EMPTY_ROOT(&dir->root))
>  			return -EINVAL;
>  		sysctl_set_perm_empty_ctl_header(dir_h);
> @@ -1204,7 +1202,7 @@ static bool get_links(struct ctl_dir *dir,
>  	struct ctl_table *entry, *link;
> =20
>  	if (header->ctl_table_size =3D=3D 0 ||
> -	    sysctl_is_perm_empty_ctl_table(header->ctl_table))
> +	    sysctl_is_perm_empty_ctl_header(header))
>  		return true;
> =20
>  	/* Are there links available for every entry in table? */
>=20
> --=20
> 2.43.2
>=20

--=20

Joel Granados

--rhjcpktngvcxuw73
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmX5suwACgkQupfNUreW
QU911Qv/XUtVU47NJ2TAOrmjM/9rBCJk43tJ6uNgBE4JrVTXaXV3hyT/bGtEX99m
H5hMHgKyJR2CRBqS8gaHKgYT53qEXsr8YBtF3xO3rtX/PtCXd4jwVO93wL6eQb8I
BKufeqOY69mzB2omwA8JzWeHH8u2dEY/R95ZGSMFPQeG4ennAUWQG2wAaw+BFoph
A2oJWZ7s6t1ue5/Suf75BeLY/40dOkGTXbvQ+slR41/dQMUvWYEx7Ho/WDcvDM7Y
HB8UV7izm61UPpzEWUPjvJFAI0LnNB6CLAgCZFMuUJ9LIZdoLbU5zctyXTBthy//
N5ku13pVSteJtI5clFwmnjALIVQ8zneS6s2BHB2VlYOlECJ9O/PmfBGZszB8AMA1
zOu4UYzJsIJax7PdAWMG75ZZok+tebPhc+LFSRY/aOtUcAX/bVroZflhhZWApoKH
zORCcxFq0E78tsw+cTSk4S2oFx3eM7q8L248Du0v8/zmMbTJ3ojL+c5euo++k+jN
DJiNNVWR
=70js
-----END PGP SIGNATURE-----

--rhjcpktngvcxuw73--