Received-SPF: pass (google.com: domain of linux-kernel+bounces-107743-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 19 Mar 2024 16:49:35 +0100
From: Joel Granados <j.granados@samsung.com>
To: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>
CC: "Eric W. Biederman" <ebiederm@xmission.com>, Luis Chamberlain
	<mcgrof@kernel.org>, Kees Cook <keescook@chromium.org>,
	<linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 0/4] sysctl: move sysctl type to ctl_table_header
Message-ID: <20240319154935.a3ase52pvuvrqz22@joelS2.panther.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
	protocol="application/pgp-signature"; boundary="zeom3d6o35odsrdw"
Content-Disposition: inline
In-Reply-To: <20240222-sysctl-empty-dir-v1-0-45ba9a6352e8@weissschuh.net>
CMS-TYPE: 201P
References: <20240222-sysctl-empty-dir-v1-0-45ba9a6352e8@weissschuh.net>
	<CGME20240319154938eucas1p10dd98f7dd53f3e91793bc8d0f34df1ec@eucas1p1.samsung.com>

--zeom3d6o35odsrdw
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 22, 2024 at 08:07:35AM +0100, Thomas Wei=DFschuh wrote:
> Praparation series to enable constification of struct ctl_table further
> down the line.
> No functional changes are intended.
Took me some time but I finally got around to it. I just had comments
regarding the commit messages. I'll add this to sysctl testing to get
the ball rolling; I'll add it to sysctl-next after you modify the commit
messages.

Thx.

>=20
> These changes have been split out and reworked from my original
> const sysctl patchset [0].
> I'm resubmitting the patchset in smaller chunks for easier review.
> Each split-out series is meant to be useful on its own.
>=20
> Changes since the original series:
> * Explicit initializartion of header->type in init_header()
> * Some additional cleanups
>=20
> [0] https://lore.kernel.org/lkml/20231204-const-sysctl-v2-0-7a5060b11447@=
weissschuh.net/
>=20
> ---
> Thomas Wei=DFschuh (4):
>       sysctl: drop sysctl_is_perm_empty_ctl_table
>       sysctl: move sysctl type to ctl_table_header
>       sysctl: drop now unnecessary out-of-bounds check
>       sysctl: remove unnecessary sentinel element
>=20
>  fs/proc/proc_sysctl.c  | 19 ++++++++-----------
>  include/linux/sysctl.h | 22 +++++++++++-----------
>  2 files changed, 19 insertions(+), 22 deletions(-)
> ---
> base-commit: b401b621758e46812da61fa58a67c3fd8d91de0d
> change-id: 20231216-sysctl-empty-dir-71d7631f7bfe
>=20
> Best regards,
> --=20
> Thomas Wei=DFschuh <linux@weissschuh.net>
>=20

--=20

Joel Granados

--zeom3d6o35odsrdw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmX5tA8ACgkQupfNUreW
QU+3JQv/Vzo9AyQraFidBTpoHTIFJw/b4gouckAz5RkfeG+55wcKHnJjv8gRZG27
Hf9/Bx6O9zchi0jnKT+i0JH5CeXY7yIym09/9Pu7z2EE+rcUnk67pKcU3CtLTsPn
fj/eHMNau4rO3Ozqtg003AbuXDa86sInKtfaDVxOzEIaubM7BYd2sSfp44xwnoZm
XI63wvl76FWgcFacfEizi5UzhZhXrzoT/pipwBUyCgtCccHJUgSXgyAZgOAD5M7J
JG8ytuNrLgpRvdvqQEvizVlxKBnE6qsRvsN0GuTC4iHKFQw3fFqjW5xsiNLoxKCX
o64qSqkzLD7ZyLUj21UtnqrCmrTavxuFj3Eqh3X4ZQXVGkyGhgjr3SiNMahqM19H
r1gkjNTIgV1irklPBM3Yrip7zx27xjOwMJooiBakqavOVdrZbWlh21pcgHR1C79K
wEpqm310ccLwndvmQ2dIQUEYWHjLGWiTZc5jl0gue4n5ruE8Id6RGaxjfmKIRRl0
ZF/E8W+1
=SbYd
-----END PGP SIGNATURE-----

--zeom3d6o35odsrdw--