Received-SPF: pass (google.com: domain of linux-kernel+bounces-107772-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Frank Li <Frank.Li@nxp.com>
Date: Tue, 19 Mar 2024 12:07:15 -0400
Subject: [PATCH v5 5/5] PCI: dwc: Add common send PME_Turn_Off message
 method
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20240319-pme_msg-v5-5-af9ffe57f432@nxp.com>
References: <20240319-pme_msg-v5-0-af9ffe57f432@nxp.com>
In-Reply-To: <20240319-pme_msg-v5-0-af9ffe57f432@nxp.com>
To: Bjorn Helgaas <bhelgaas@google.com>, Jingoo Han <jingoohan1@gmail.com>, 
 Gustavo Pimentel <gustavo.pimentel@synopsys.com>, 
 Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>, 
 Lorenzo Pieralisi <lpieralisi@kernel.org>, 
 =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= <kw@linux.com>, 
 Rob Herring <robh@kernel.org>, 
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, 
 Conor Dooley <conor+dt@kernel.org>, imx@lists.linux.dev
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, 
 devicetree@vger.kernel.org, Frank Li <Frank.Li@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eXNxUWkvS0xXbnNOei9aMUsrSFltTUxQcS9oZEdDNlZTNk16Uld6KzMrdlFL?=
 =?utf-8?B?MFBleVY4UUs3MmR0YTM2dlBYbVM1RzM4TjV4L3JLZ3R0RjdmQ3RGdGovL2p0?=
 =?utf-8?B?QmRVaHlPYmhYYnpBSExONnVTUUpUWkVzMlhSL0hzRHRiSW1CTXU1MERLYmlx?=
 =?utf-8?B?VERzYlhwZElmS0tCTkcrdDNMVldVZDhGemJVNmliMU9CdVIzMGNLcFU3NFpx?=
 =?utf-8?B?SWg0eGc4VjEzUWZmTEtVSkc5Q25kck1xUnRyMkFSN0laOERoODZMQ1pPSDlO?=
 =?utf-8?B?QlBNNytUTlNiTnZTc1h2eTU5emZQdERCKzJtTGxURHlEMWR1bGtvUHFNcURM?=
 =?utf-8?B?djNrMkZtUWlLYkNyNFArdHpmYy9aZ1U5cFZGOTNnQTlWUlNMdHpGWkxHZTFV?=
 =?utf-8?B?TnZjSEx2eXJzMjZCZmp0V0oxeUhlay8vdUxQZEYzbEcxVUI3OTQ4UXRHQVVw?=
 =?utf-8?B?VmlpS2g4NkpQdUQwZGV3ckRuWnA1UVdOa1FBSWNWdnJybFJWQm44RWVqcHpa?=
 =?utf-8?B?cEVuVHVpTGpvQ2tWYWM4bzlHa2JpSVk3OWdMdVI2ZzdzK085cVFnVTRrUWNL?=
 =?utf-8?B?UldlcGh5L0Z4b0xCMVhDZWRoYXRPVkd5VTh5ZGx3QzNYeHJmdERGS3hsSG4r?=
 =?utf-8?B?TzBuckhMdm5KUmEySGhTUkg2UFc4UTUxcW1JSWc1aFllMkVuS2lIbWk3ZWFJ?=
 =?utf-8?B?dnFVKzZGOVhkaUMvUDZXSndMZ3RRWGRPUzQzZDJIUUplS2JaQ0F5QzBCRHor?=
 =?utf-8?B?ZHZyMUh5ZzJQMFZqYVdrYVlmUTlRV3QrQjhKaXBQVmRSZFZ1c1NrNFZXU1pU?=
 =?utf-8?B?QU0xRWlIa0F3eWN4clhNakJMU3g3UHYxTjN4RGgwcnJvZGxUajI4elJmM3JG?=
 =?utf-8?B?a3UzL1RYZ0M5NUk0Q0ZPWWowUlgvSUR1aXd6QU1YVXMyR2N6SmRocmZ0anFX?=
 =?utf-8?B?SW5laXI1SysxeTdKSTV3NkJKcCtLbzVqM3cyTnozU3I4T2NZVWRjdlN6aDBw?=
 =?utf-8?B?a2psdEw2K1NNSVRjVjdJYm5XVzZCK0RHVEhadE1lSWhPNTJNOXhqSVpGeHNP?=
 =?utf-8?B?alozTWJjNVpzZlk2U2lqVVBoVFVIdU1LS0V2MlZKbWp4d1I1RCtPeTlXRVpj?=
 =?utf-8?B?T3B0SjNobmdCRkMwbGVVQjFnMVljcWFIZUxjcFR6dlBCSTNTSldoWXVvdEJh?=
 =?utf-8?B?dDRRWmRqZ0RDQzUzcm8vYWE0NXJqR2o0OXU5Y1d3TUZSVEhLYkhkdTNKZ0Nw?=
 =?utf-8?B?dHh6MEVpQllOSGJCekZLak4rWkFuaFZZeUJsZW9wQ1VmNENWNG1Lc3QraDVG?=
 =?utf-8?B?UEVvdzlDSVRvNW5sK21VVlk0WlJtSnlhTnVHK1p4WHlleFB2Sjk4QXZNVmZV?=
 =?utf-8?B?TnRjVzk0YkMzenZxWStBT1oyT1VTYm1SZVAyQ0lkLzRiQVl5cUxJWnZYendL?=
 =?utf-8?B?N0FUTlhESk9qK0d1b1VDNXRVUnlwSXdISllmdmFYWWErcEVLQWNxQXQxVW5t?=
 =?utf-8?B?UkZ4K3BhaktXVS9rNFpFMUxZcUZpclljWkdVUm5EMk9pV0NXV0JzUTVYNVZ5?=
 =?utf-8?B?Vm1pRDVvbWU3SGZmTHoyRW9xYXVHOU9CZ2Zhb2ZTTG5jT29JTStyYXRSaDgw?=
 =?utf-8?B?VkVmMjFzRFh2SGk4OGltbnJWcGl6NS9SeW91NVBGSXZDVDFxYTV2dHBJSitI?=
 =?utf-8?B?SXhzTTdPN0NQeU9xZXNjT1JXaWNhbi9vMkNOK0tkMm5vTGdmazV5N3M4clF1?=
 =?utf-8?B?a1p2L2N3TUhDS1czeXZFN3MwT1E3Ny92WHdRSG1Db0o0amQ0WWFBbGlLY2xJ?=
 =?utf-8?B?U3d3ZkNjYjJlTTBaODdzUUpVNEFCYXFaUU5Xcndvd1dONnk3cXZ2U2toZ1lo?=
 =?utf-8?B?OGJYZG1neXorU1NqMDR5d2lCcmxYNWNnMzA3QnJTYnlDdUl4ZFZoeE9RWElX?=
 =?utf-8?B?a1lmU1BrejJXK3ptTzFZNTJBdVcvalMvUm1hVmIyb0xMTkFoZ3Q3aEh1Sjl1?=
 =?utf-8?B?Zy93dEJNcHcrQTRNcFBveFV0Y090TFY5WXNzM1FKbUE5UTFwaHp6VjRWS29I?=
 =?utf-8?B?OU54K1poc3J1ekhlZTNnU2ZNSi85TFlTeExpMnZrbnZVcEJQSkh1S0duZ1h2?=
 =?utf-8?Q?DyNx4fUwHexBKhqDjSxbwzfqO?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5a22b166-c021-440c-0476-08dc482eb230
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2024 16:07:37.5746
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: R46hvF2TaVw+0IEzDGXeKahGUFt5AdE9nNbpC4sL4mUNGc8dhhJ7aDX+iqKmCQfvhaA8YUteO6HxGioOux9nww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7772

Reserve space at end of first IORESOURCE_MEM window as message TLP MMIO
window. This space's size is 'region_align'.

Set outbound ATU map memory write to send PCI message. So one MMIO write
can trigger a PCI message, such as PME_Turn_Off.

Add common dwc_pme_turn_off() function.

Call dwc_pme_turn_off() to send out PME_Turn_Off message in general
dw_pcie_suspend_noirq() if there are not platform callback pme_turn_off()
exist.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 drivers/pci/controller/dwc/pcie-designware-host.c | 94 ++++++++++++++++++++++-
 drivers/pci/controller/dwc/pcie-designware.h      |  3 +
 2 files changed, 93 insertions(+), 4 deletions(-)

diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
index 267687ab33cbc..d5723fce7a894 100644
--- a/drivers/pci/controller/dwc/pcie-designware-host.c
+++ b/drivers/pci/controller/dwc/pcie-designware-host.c
@@ -393,6 +393,31 @@ static int dw_pcie_msi_host_init(struct dw_pcie_rp *pp)
 	return 0;
 }
 
+static void dw_pcie_host_request_msg_tlp_res(struct dw_pcie_rp *pp)
+{
+	struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
+	struct resource_entry *win;
+	struct resource *res;
+
+	win = resource_list_first_type(&pp->bridge->windows, IORESOURCE_MEM);
+	if (win) {
+		res = devm_kzalloc(pci->dev, sizeof(*res), GFP_KERNEL);
+		if (!res)
+			return;
+
+		/* Reserve last region_align block as message TLP space */
+		res->start = win->res->end - pci->region_align + 1;
+		res->end = win->res->end;
+		res->name = "msg";
+		res->flags = win->res->flags | IORESOURCE_BUSY;
+
+		if (!request_resource(win->res, res))
+			pp->msg_res = res;
+		else
+			devm_kfree(pci->dev, res);
+	}
+}
+
 int dw_pcie_host_init(struct dw_pcie_rp *pp)
 {
 	struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
@@ -479,6 +504,10 @@ int dw_pcie_host_init(struct dw_pcie_rp *pp)
 
 	dw_pcie_iatu_detect(pci);
 
+	/* Need call after dw_pcie_iatu_detect() before dw_pcie_setup_rc() */
+	if (pp->use_atu_msg)
+		dw_pcie_host_request_msg_tlp_res(pp);
+
 	ret = dw_pcie_edma_detect(pci);
 	if (ret)
 		goto err_free_msi;
@@ -536,6 +565,11 @@ void dw_pcie_host_deinit(struct dw_pcie_rp *pp)
 
 	dw_pcie_edma_remove(pci);
 
+	if (pp->msg_res) {
+		release_resource(pp->msg_res);
+		devm_kfree(pci->dev, pp->msg_res);
+	}
+
 	if (pp->has_msi_ctrl)
 		dw_pcie_free_msi(pp);
 
@@ -697,6 +731,10 @@ static int dw_pcie_iatu_setup(struct dw_pcie_rp *pp)
 		atu.pci_addr = entry->res->start - entry->offset;
 		atu.size = resource_size(entry->res);
 
+		/* MSG TLB window resource reserve at one of end of IORESOURCE_MEM resource */
+		if (pp->msg_res && pp->msg_res->parent == entry->res)
+			atu.size -= resource_size(pp->msg_res);
+
 		ret = dw_pcie_prog_outbound_atu(pci, &atu);
 		if (ret) {
 			dev_err(pci->dev, "Failed to set MEM range %pr\n",
@@ -728,6 +766,8 @@ static int dw_pcie_iatu_setup(struct dw_pcie_rp *pp)
 		dev_warn(pci->dev, "Ranges exceed outbound iATU size (%d)\n",
 			 pci->num_ob_windows);
 
+	pp->msg_atu_index = i;
+
 	i = 0;
 	resource_list_for_each_entry(entry, &pp->bridge->dma_ranges) {
 		if (resource_type(entry->res) != IORESOURCE_MEM)
@@ -833,11 +873,54 @@ int dw_pcie_setup_rc(struct dw_pcie_rp *pp)
 }
 EXPORT_SYMBOL_GPL(dw_pcie_setup_rc);
 
+/* Using message outbound ATU to send out PME_Turn_Off message for dwc PCIe controller */
+static int dw_pcie_pme_turn_off(struct dw_pcie *pci)
+{
+	struct dw_pcie_ob_atu_cfg atu = { 0 };
+	void __iomem *m;
+	int ret;
+
+	if (pci->num_ob_windows <= pci->pp.msg_atu_index)
+		return -EINVAL;
+
+	if (!pci->pp.msg_res)
+		return -EINVAL;
+
+	atu.code = PCIE_MSG_CODE_PME_TURN_OFF;
+	atu.routing = PCIE_MSG_TYPE_R_BC;
+	atu.type = PCIE_ATU_TYPE_MSG;
+	atu.size = resource_size(pci->pp.msg_res);
+	atu.index = pci->pp.msg_atu_index;
+
+	if (!atu.size) {
+		dev_dbg(pci->dev,
+			"atu memory map windows is zero, please check 'msg' reg in dts\n");
+		return -ENOMEM;
+	}
+
+	atu.cpu_addr = pci->pp.msg_res->start;
+
+	ret = dw_pcie_prog_outbound_atu(pci, &atu);
+	if (ret)
+		return ret;
+
+	m = ioremap(atu.cpu_addr, pci->region_align);
+	if (!m)
+		return -ENOMEM;
+
+	/* A dummy write is converted to a Msg TLP */
+	writel(0, m);
+
+	iounmap(m);
+
+	return 0;
+}
+
 int dw_pcie_suspend_noirq(struct dw_pcie *pci)
 {
 	u8 offset = dw_pcie_find_capability(pci, PCI_CAP_ID_EXP);
 	u32 val;
-	int ret;
+	int ret = 0;
 
 	/*
 	 * If L1SS is supported, then do not put the link into L2 as some
@@ -849,10 +932,13 @@ int dw_pcie_suspend_noirq(struct dw_pcie *pci)
 	if (dw_pcie_get_ltssm(pci) <= DW_PCIE_LTSSM_DETECT_ACT)
 		return 0;
 
-	if (!pci->pp.ops->pme_turn_off)
-		return 0;
+	if (pci->pp.ops->pme_turn_off)
+		pci->pp.ops->pme_turn_off(&pci->pp);
+	else
+		ret = dw_pcie_pme_turn_off(pci);
 
-	pci->pp.ops->pme_turn_off(&pci->pp);
+	if (ret)
+		return ret;
 
 	ret = read_poll_timeout(dw_pcie_get_ltssm, val, val == DW_PCIE_LTSSM_L2_IDLE,
 				PCIE_PME_TO_L2_TIMEOUT_US/10,
diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h
index 703b50bc5e0f1..dca5de4c6e877 100644
--- a/drivers/pci/controller/dwc/pcie-designware.h
+++ b/drivers/pci/controller/dwc/pcie-designware.h
@@ -341,6 +341,9 @@ struct dw_pcie_rp {
 	struct pci_host_bridge  *bridge;
 	raw_spinlock_t		lock;
 	DECLARE_BITMAP(msi_irq_in_use, MAX_MSI_IRQS);
+	bool			use_atu_msg;
+	int			msg_atu_index;
+	struct resource		*msg_res;
 };
 
 struct dw_pcie_ep_ops {

-- 
2.34.1