Received-SPF: pass (google.com: domain of linux-kernel+bounces-107880-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <0d41ae1a-f6aa-4377-b8a3-7fcf067f99ac@acm.org>
Date: Tue, 19 Mar 2024 10:01:11 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] scsi: core: Make scsi_lib KUnit tests modular for real
Content-Language: en-US
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Mike Christie <michael.christie@oracle.com>,
 "James E . J . Bottomley" <jejb@linux.ibm.com>,
 "Martin K . Petersen" <martin.petersen@oracle.com>,
 Lukas Bulwahn <lukas.bulwahn@gmail.com>, linux-scsi@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <48ca5e827ca420bbdbabb1643e2179dc95c9e0b7.1710849638.git.geert@linux-m68k.org>
 <d1a1b0b8-41f1-4ead-b393-d8d2f099b0c4@acm.org>
 <CAMuHMdWzD1OR8qj8oHfUgQ9GMtrD8y69G+A+ONdVm0vTCvYe=w@mail.gmail.com>
From: Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <CAMuHMdWzD1OR8qj8oHfUgQ9GMtrD8y69G+A+ONdVm0vTCvYe=w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 3/19/24 09:10, Geert Uytterhoeven wrote:
> On Tue, Mar 19, 2024 at 5:03=E2=80=AFPM Bart Van Assche <bvanassche@acm=
org> wrote:
>> On 3/19/24 05:02, Geert Uytterhoeven wrote:
>> kernel module? What are the advantages compared to the current approac=
h?
>> That information is missing from the patch description.
>=20
> SCSI_LIB_KUNIT_TEST is already tristate, so the original author must
> have meant it to be modular.  Or perhaps he just copied it from
> (most/all) other tests ;-)
>=20
> Anyway, I find it very useful to be able to do "modprobe kunit" and
> "modprobe <test>" to run a test when I feel the need to do so.

Hi Geert,

Why to run hardware-independent kunit tests on the target system instead
of on the host? Isn't it much more convenient when developing embedded
software to run kunit tests on the host using UML? The script I use to
run SCSI kunit tests is available below. And if there is a desire to run
SCSI tests on the target system, how about adding triggers in sysfs for
running kunit tests? The (GPL v2) Samsung smartphone kernel supports
this but I have not yet checked whether their implementation is
appropriate for the upstream kernel.

Thanks,

Bart.


#!/bin/sh

set -e

mkdir -p .kunit
if [ -e .config ]; then
     rm -f .config
     make ARCH=3Dum mrproper
fi
if [ ! -e .kunit/.kunitconfig ] || [ "$0" -nt .kunit/.kunitconfig ]; then
     echo "Regenerating .kunit/.kunitconfig"
     cat <<EOF >.kunit/.kunitconfig
CONFIG_BLK_DEV_SD=3Dy
CONFIG_BLK_DEV_ZONED=3Dy
CONFIG_MQ_IOSCHED_DEADLINE=3Dy
CONFIG_BLOCK=3Dy
CONFIG_EISA=3Dn
CONFIG_KUNIT=3Dy
CONFIG_SCSI_PROCFS=3Dn
#CONFIG_PROVE_LOCKING=3Dy
CONFIG_SCSI=3Dy
#CONFIG_SYSFS=3Dy
CONFIG_UBSAN=3Dy
CONFIG_KASAN=3Dy
CONFIG_RUNTIME_TESTING_MENU=3Dn
CONFIG_WERROR=3Dy
EOF
     syms=3D(
	CONFIG_SCSI_ERROR_TEST
	CONFIG_SCSI_PROTO_TEST
	CONFIG_SCSI_SD_TEST
     )
     for s in "${syms[@]}"; do
     if git grep -qw "${s#CONFIG_}" block/Kconfig* drivers/scsi/Kconfig;=20
then
	echo "$s=3Dy" >> .kunit/.kunitconfig
     fi
     done
     cp .kunit/.kunitconfig .kunit/.config
fi
/tools/testing/kunit/kunit.py run