Received-SPF: pass (google.com: domain of linux-kernel+bounces-107944-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <a9462db4-bd41-4254-b11d-239ba6aaeff0@intel.com>
Date: Tue, 19 Mar 2024 10:50:10 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v16 3/9] x86/resctrl: Prepare for different scope for
 control/monitor operations
Content-Language: en-US
To: Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>, "Peter
 Newman" <peternewman@google.com>, Jonathan Corbet <corbet@lwn.net>, "Shuah
 Khan" <skhan@linuxfoundation.org>, <x86@kernel.org>
CC: Shaopeng Tan <tan.shaopeng@fujitsu.com>, James Morse
	<james.morse@arm.com>, Jamie Iles <quic_jiles@quicinc.com>, Babu Moger
	<babu.moger@amd.com>, Randy Dunlap <rdunlap@infradead.org>, Drew Fustini
	<dfustini@baylibre.com>, <linux-kernel@vger.kernel.org>,
	<linux-doc@vger.kernel.org>, <patches@lists.linux.dev>
References: <20240312214247.91772-1-tony.luck@intel.com>
 <20240312214247.91772-4-tony.luck@intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240312214247.91772-4-tony.luck@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NnFxY3pkWmJxUisxbW83b241bXBNMG8vY09HMFJlSXVveWwreVQ5MlF6L3Qr?=
 =?utf-8?B?Z2Y4ZS9CSWR5emxnOGJqdzVucWN4RlZtWlRhODhZK0t2RE9FbUw2K0syelhS?=
 =?utf-8?B?NXZtZW5EZ2p1a3AwQ3FqUmNPbHBDVURDaUNwSGlCQ2Nqb012UEtEWDc1QzRZ?=
 =?utf-8?B?ZG5PbGpycHJSRndvY1JORk9pbnJ6UXZHNTlueGZhSFl1Z0NlU2pidlYvQ0Jn?=
 =?utf-8?B?N2FLMjlDdE9VY0piWHN4aFdQNElmdXZ6VlRSMTlKZnpUTlZheS9vcG9KdGd4?=
 =?utf-8?B?NWlCYWhGVlRGWG9QdTZHM3B4WjN5UmRCZlI2am5tTW95eWtZUnc3UU15c0NT?=
 =?utf-8?B?Y0RFOFpOQlV5R2hnNkM4SjVsSWFzMUNYZnM3OFYvQW9PbXpvWXo3RE1uY05Z?=
 =?utf-8?B?Sk5yMWVnRUY5bWgzQWlaM1VNeEpOa1R1VTVsMndrZThJeEVpeEVOOXBlR05p?=
 =?utf-8?B?bUptbHhBWkU2RXRrcG9aRXJXWGs1VFhqbWdUdEcrNUFrSXcyMEZGUW9TcEs2?=
 =?utf-8?B?TnpvamFwMStvK0xCMFo5UUI0M3UrZ3ZQZVNocVRNbk11ekNIU0hxeEphYURL?=
 =?utf-8?B?MHRNWmFLbVUzSldrSTNWeWRjN1lzNnRwV0NzTFMrcVBDLzJqckJvS2EwL3RP?=
 =?utf-8?B?ajE5RWxtUzhoTHlpbjUzcHgzREdPeFlZS203NS81NVZDVmxEL0hYQ3pBdmUx?=
 =?utf-8?B?dHdJU2NqeGNBdVpNOW8zaGNsemRCaGVIcEJmcU5LZTJ5K0JwOHVTdVR0cXVV?=
 =?utf-8?B?TlEwWXBORjI5OEFuM0RiV0tCQ2lIME5MTWtlazEzU215VGh3aGE4aXIxQWE3?=
 =?utf-8?B?c0o3QWl1WTdLZm92UWJtRkdnT2pSYjV1NlduUWJhR1U1elZmRWhMcG43ZHBP?=
 =?utf-8?B?SEJIU2tybkd1K3I0MElYd1hNeXJ0eXRWZ2dyeWRUMFRPeDZQVTVHM3VQWlN4?=
 =?utf-8?B?aXY0TS9wc2JPeE1lTDhDK1h0UGtnTjRUUU1KeWpIbkpVdC9CYVQvWnNEekZs?=
 =?utf-8?B?QUNlTlJLekpxQW1qOW9BNjRyZlBrZ1gxNWhUblBiSjVyejFBWTllRnpYYlhv?=
 =?utf-8?B?UC9GTlhaVUFxcldDUS9QWUlreUh0VlhYUHZhMlk4b0xDbENGcHFCSTRka1J6?=
 =?utf-8?B?Nk5rU24vaXBIQmJlbjF3RVJud1ExUGxWRVR4WGc3UFY1b2FVZVZDckdCSDE2?=
 =?utf-8?B?Z1lCclJBVVV0djhUZ2k0d0tMMHlhU3M1QTNmdmNBaGp4TUZQQ1lBZWhTK3VO?=
 =?utf-8?B?VkNxNGo5eE1PeTU1QWFwRk95WGc3Nm1acUd2UWNabnhNc2xCMDhMUDVqM29q?=
 =?utf-8?B?TUo3YUZmL3FIV2d4YkRFeDdoY0E0UTFoQzkrb2tHdi9mR2NEQlhQQ0RkMFM3?=
 =?utf-8?B?K2dSaXVMNTZGS0RoZXBxNWFJcm5JSFNsQU1pcUdidnNEMEVUd2lUellDSFRW?=
 =?utf-8?B?dytNT1gybVVkVXVRT3E4THpmeGJKMVhJMks4amVsdVF2Q3R4SlNsSTliSmh3?=
 =?utf-8?B?akR4Qm90TmVJaUJtOERLMkdjSTAvR1RiMkJRdEVXcmQ4cjZMQzZLM2hYQnRV?=
 =?utf-8?B?ZnZOV1V0SmZiQkh2MXVNUkJzak41L3ZaYnVSWVVIaytRMkZRRXFyU0J0REg2?=
 =?utf-8?B?L0VOQjQrN2pQcGRKWkVQczJvczFWTGlrWlRuQ0xDd01DRTdrVC9tUWp0Y3lT?=
 =?utf-8?B?SWdqa3JaMmF1SUFycis4Qjl3UzRvMFFBTFMzR25pa09EQ0w0dmFvS01McEQv?=
 =?utf-8?B?dncrWEtkOVY0Lytla1VlZ01LQm5oUlkxblUyTEdwMlEydkkreVBIZ3A5QzQr?=
 =?utf-8?B?bnIyaDFJekNDZVVDaitVR3J1WDRudWtrUzFrOFZDUndrV3dXNmVaOFhQZ2s3?=
 =?utf-8?B?KzFYRGx3Z2tXWDEwclJ3YjVLZmxzUGMxYjJwbUsvY2dVTEszaDA1ODFoL2Rs?=
 =?utf-8?B?N0hrOGRzaW9SZmR4Y0dwRmVPcHE0U0xVdDB5VzBFSlFVb3RCcWlzMkVEYlB1?=
 =?utf-8?B?WDNpd1gzdlU0b1J0eHorOXMvZzFSU3VLR1Nudi9RNXlDRUJtMTRuMlVZM0Nr?=
 =?utf-8?B?a0tMMld5NTJrVUhhVlRMSlMwVFFyT1lYWGpsWnpCNExpTEU3d3ZOMEo1TEpa?=
 =?utf-8?B?dmZpNUtRL3RXKy9EdDNPU0x0YndKUjhpWjJacWZKb2xyZUUwRjNORW5jemo3?=
 =?utf-8?B?YVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 53dcf230-6d93-42c3-30b7-08dc483d0677
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2024 17:50:12.0036
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OAJML26b9A/jzP1bSix+R35UyMphtjh2n3+fWI2zw24cj2qcHozURz+RsX4M0s3z6a4gGbP9CUMNIcas/yWH48Jcj6AHssaYQJxx0Z0VplY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6113
X-OriginatorOrg: intel.com

Hi Tony,

On 3/12/2024 2:42 PM, Tony Luck wrote:

..

> @@ -169,10 +176,12 @@ enum resctrl_scope {
>   * @alloc_capable:	Is allocation available on this machine
>   * @mon_capable:	Is monitor feature available on this machine
>   * @num_rmid:		Number of RMIDs available
> - * @scope:		Scope of this resource
> + * @ctrl_scope:		Scope of this resource for control functions
> + * @mon_scope:		Scope of this resource for monitor functions
>   * @cache:		Cache allocation related data
>   * @membw:		If the component has bandwidth controls, their properties.
> - * @domains:		RCU list of all domains for this resource
> + * @ctrl_domains:	Control domains for this resource
> + * @mon_domains:	Monitor domains for this resource

nit: could you please keep the comment related to these being RCU lists now?

Reinette