Received-SPF: pass (google.com: domain of linux-kernel+bounces-107975-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240319034143-mutt-send-email-mst@kernel.org>
In-Reply-To: <20240319034143-mutt-send-email-mst@kernel.org>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Tue, 19 Mar 2024 11:03:44 -0700
Message-ID: <CAHk-=wi363CLXBm=jB=eAtJQ18E-h4Vwrgmd6_7Q=DN+9u8z6w@mail.gmail.com>
Subject: Re: [GIT PULL] virtio: features, fixes
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, 
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org, 
	alex.williamson@redhat.com, andrew@daynix.com, david@redhat.com, 
	dtatulea@nvidia.com, eperezma@redhat.com, feliu@nvidia.com, 
	gregkh@linuxfoundation.org, jasowang@redhat.com, jean-philippe@linaro.org, 
	jonah.palmer@oracle.com, leiyang@redhat.com, lingshan.zhu@intel.com, 
	maxime.coquelin@redhat.com, ricardo@marliere.net, shannon.nelson@amd.com, 
	stable@kernel.org, steven.sistare@oracle.com, suzuki.poulose@arm.com, 
	xuanzhuo@linux.alibaba.com, yishaih@nvidia.com
Content-Type: text/plain; charset="UTF-8"

On Tue, 19 Mar 2024 at 00:41, Michael S. Tsirkin <mst@redhat.com> wrote:
>
> virtio: features, fixes
>
> Per vq sizes in vdpa.
> Info query for block devices support in vdpa.
> DMA sync callbacks in vduse.
>
> Fixes, cleanups.

Grr. I thought the merge message was a bit too terse, but I let it slide.

But only after pushing it out do I notice that not only was the pull
request message overly terse, you had also rebased this all just
moments before sending the pull request and didn't even give a hit of
a reason for that.

So I missed that, and the merge is out now, but this was NOT OK.

Yes, rebasing happens. But last-minute rebasing needs to be explained,
not some kind of nasty surprise after-the-fact.

And that pull request explanation was really borderline even *without*
that issue.

                Linus