Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp1082543lqt; Tue, 19 Mar 2024 12:04:40 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW2492/DJphssMNjfxrLktTQJObJkqYeFZELOGFVDDi/QibTnhn93oRZiumXGxzftuTro9ZbnfKw44h3p8lwnCBM3tiED0i59jePjAwFA== X-Google-Smtp-Source: AGHT+IH462HaNWrzLu+2x2bqmyu3h2vFuR/iEc980n9AJTu0J+BqhGrId90hORCw/Ft1YNmQBik5 X-Received: by 2002:a05:6a20:7f83:b0:1a1:8c6a:ed7 with SMTP id d3-20020a056a207f8300b001a18c6a0ed7mr4371750pzj.44.1710875080566; Tue, 19 Mar 2024 12:04:40 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710875080; cv=pass; d=google.com; s=arc-20160816; b=fby831dIf4TO5OJGL/0ELqcr68wenFx2KkALpPkoaxDNWyueXEPlBiZPU6Or2ogGz1 M1k12yE3rvAuOa/NAxM4GQrzK/1whhXinGQoNV4rPF3DoJ/hCFf4fHd7YCaE2ZwWlYe3 sN4diQ2w/gfbEuqdt5/qh6XXDVm8H99KeRx0ZfONPCE+bLIye7RzgmNlgolb9j4UG3HJ 3u5r9VCYIE21twFZclYR1kv+uj7dbsUAMRpsKdmzsnozkHKbS3yVg9Vo5DyebZ4oHwRD 64ythoPQ+JTKe/52+YIrjufeTgA2iaDML4ywXCtPL7c1/XOTxPpjUFvJUjH/piu5GFf0 m1JQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :reply-to:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature:dkim-signature:dkim-signature; bh=m62pe4FrwAX4W2HKydm4w3ADTQa0VQzYozY1M6lUmqg=; fh=6dyG4BxLJ7p2B5V+iEfvJllY8Bc02Dfkp7qhWK8+KOs=; b=Ucpeptx5qc6zGRP9xeeTq1dmOwSw+zs45x9Kae7ciYyFMsnDWNcPovsBE8Rm0AQ7yC A9mjtmVjFYxCc2VTvHcg8A3F4PA+ah7CDXJb4ccsnM9V+pQYN7fGKmhkQdsBvAYJQ2Ia 7qlBMC585bGPqXRfcsPoPPEhNos9jO1t96fRcX92JLpOyGLvBnZxAycwdbfpD1FXFsfP jOPmv+rUOIQhnrId0bt1m3MtX0dPhRL9PQL2tKN9tnsJhYgqImzRrxELVMnYnbaD/ZVp TTuwpG086j9/O/3zMzLMFcitfjQ3jWPPVTMpmgTKI1oImjR3zMX1DFJ1te4zDiOypYDF /k5w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=kRc6YG2S; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=kRc6YG2S; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.cz dkim=pass dkdomain=suse.cz dkim=pass dkdomain=suse.cz); spf=pass (google.com: domain of linux-kernel+bounces-108049-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-108049-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id a8-20020a17090a8c0800b0029f94ac7203si5771098pjo.4.2024.03.19.12.04.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 12:04:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-108049-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=kRc6YG2S; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=kRc6YG2S; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.cz dkim=pass dkdomain=suse.cz dkim=pass dkdomain=suse.cz); spf=pass (google.com: domain of linux-kernel+bounces-108049-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-108049-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3BCA9283798 for ; Tue, 19 Mar 2024 19:04:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F25EE39FE9; Tue, 19 Mar 2024 19:04:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="kRc6YG2S"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="5dZwg4br"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="kRc6YG2S"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="5dZwg4br" Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F6A52B9CF; Tue, 19 Mar 2024 19:04:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710875069; cv=none; b=cn5Yo3V9GLM87u4p65xhpBpexOADqQZuKTmxSJeBodqUW6MLy3ym7lvvi/VvuIAsS6q/tccEVRoxp4nN37NFqvtx/hHkUL3Go58Xa25Z84HZzemKQGc5iGBOWisFA9qf4m3WND7pxOqW92HMKBn7CHEHNO+/n4A1QnKf2tiZvhg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710875069; c=relaxed/simple; bh=1pjcoLPclLzjr/spIkeBg9aX2MPdr/BpKaruYoQCPz4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ut2VRqoHomVB5QIU16BOfnRhImEWLLiXLDg8D0BRF1scDmVmGBdUzFLtnuRXP9jes75SDS22mz/hp0CZ3qd/JrHnUBmCK6t28ZtQRVHclpiUnOk170BLAhRlSXYxq2JAtgsUNzYSyIZOCF+kKnf04W1FRXdCaa+GeK6sJZ9bdco= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=kRc6YG2S; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=5dZwg4br; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=kRc6YG2S; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=5dZwg4br; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 39E552269E; Tue, 19 Mar 2024 19:04:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1710875065; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m62pe4FrwAX4W2HKydm4w3ADTQa0VQzYozY1M6lUmqg=; b=kRc6YG2SeImuplw8mrkrbKl3wl1XvxFbvIG60cqI4+KqpBclNfMzGjFu1uivSlc4BL1dhR L3aM/VziCWSBbfMzgl3oAf8Sn/HUE6d8eVY5I196h68y/LOEc6yk384iD5dl5MbBsu4TSM f51s6sLUFWGeRqdJHfsPE3BHOuXs64I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1710875065; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m62pe4FrwAX4W2HKydm4w3ADTQa0VQzYozY1M6lUmqg=; b=5dZwg4brtsInmvMmSkeb9afo9JrrV1Kb0M5/7ZEg/HEXIwm0yAevAC3aHkhbBGGEcGpUS9 VqWluK7WGnw5D3AQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1710875065; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m62pe4FrwAX4W2HKydm4w3ADTQa0VQzYozY1M6lUmqg=; b=kRc6YG2SeImuplw8mrkrbKl3wl1XvxFbvIG60cqI4+KqpBclNfMzGjFu1uivSlc4BL1dhR L3aM/VziCWSBbfMzgl3oAf8Sn/HUE6d8eVY5I196h68y/LOEc6yk384iD5dl5MbBsu4TSM f51s6sLUFWGeRqdJHfsPE3BHOuXs64I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1710875065; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m62pe4FrwAX4W2HKydm4w3ADTQa0VQzYozY1M6lUmqg=; b=5dZwg4brtsInmvMmSkeb9afo9JrrV1Kb0M5/7ZEg/HEXIwm0yAevAC3aHkhbBGGEcGpUS9 VqWluK7WGnw5D3AQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1C9361376B; Tue, 19 Mar 2024 19:04:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id xgzGBrnh+WWTWQAAD6G6ig (envelope-from ); Tue, 19 Mar 2024 19:04:25 +0000 Date: Tue, 19 Mar 2024 19:57:11 +0100 From: David Sterba To: Maximilian Heyne Cc: stable@vger.kernel.org, Chris Mason , Josef Bacik , David Sterba , Filipe Manana , Qu Wenruo , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4.19 5.4 5.15] btrfs: defrag: fix memory leak in btrfs_ioctl_defrag Message-ID: <20240319185711.GA14596@suse.cz> Reply-To: dsterba@suse.cz References: <20240319170055.17942-1-mheyne@amazon.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240319170055.17942-1-mheyne@amazon.de> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Spam-Score: -2.81 X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Flag: NO X-Spamd-Result: default: False [-2.81 / 50.00]; HAS_REPLYTO(0.30)[dsterba@suse.cz]; RCVD_VIA_SMTP_AUTH(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[suse.cz:+]; MX_GOOD(-0.01)[]; RCPT_COUNT_SEVEN(0.00)[9]; NEURAL_HAM_SHORT(-0.20)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; BAYES_HAM(-0.10)[65.16%]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; RCVD_DKIM_ARC_DNSWL_HI(-1.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:dkim]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_IN_DNSWL_HI(-0.50)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_TLS_ALL(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from] X-Spam-Level: Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=kRc6YG2S; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=5dZwg4br X-Rspamd-Queue-Id: 39E552269E On Tue, Mar 19, 2024 at 05:00:55PM +0000, Maximilian Heyne wrote: > Prior to commit c853a5783ebe ("btrfs: allocate > btrfs_ioctl_defrag_range_args on stack") range is allocated on the heap > and must be freed. However, commit 173431b274a9 ("btrfs: defrag: reject > unknown flags of btrfs_ioctl_defrag_range_args") didn't take care of > this when it was backported to kernel < 5.15. > > Add a kfree on the error path for stable kernels that lack > commit c853a5783ebe ("btrfs: allocate btrfs_ioctl_defrag_range_args on > stack"). > > This bug was discovered and resolved using Coverity Static Analysis > Security Testing (SAST) by Synopsys, Inc. Good catch, thanks. The affected versions are as you say 4.19, 5.4, 5.15, the fixup is sufficient and minimal fix, c853a5783ebe is reasonably safe for backport too.