Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp1100002lqt; Tue, 19 Mar 2024 12:38:41 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXSEUmyPr/qha2fvx5eKjtpsH/IB4Oi18oMHLl9eFEHD4Ro9mYna+HP2sWM2p20L4EJQ7VAf7gDDFltYYTjGTyuo7DOVXR80uj7xks6bA== X-Google-Smtp-Source: AGHT+IHD6xOr5LoWSzRNfxKglmhcgkBGPvPalrEn0/6XdRmX6JjmcYUMv3+NDEjz/pFHEdZIecxy X-Received: by 2002:a17:907:806:b0:a46:e017:1ef7 with SMTP id wv6-20020a170907080600b00a46e0171ef7mr2313338ejb.64.1710877120929; Tue, 19 Mar 2024 12:38:40 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710877120; cv=pass; d=google.com; s=arc-20160816; b=hu1MGJG5LvR9tETAUiaM6wI1eQLDRHK9YWdnem7VA2qybUAwedghHIQ6VQIEsjR7ZK GApwTDoT8nrlkXs054zdzaDWsgsc5gKkN3YoOOzAe/3n3L1be2+N1WPxGcH69yjUSNl2 jTtvQPQXdvEX2ClY0VMnAMnnCQ1vJzLZZrBcCkFC2Lsee5OV/l9ygp4DGgqFX0e6xyej 16k4dnIzX7VQWljTDfm2SSzuRDeBGE+nvDOG9wiyZzNzmxuM10wvKPMczLcNpeK+78q9 BEM/A9ILzOKMDT4AVRMUD2QGNdaL9Z3CQvS0fF97jViC7l5HfZ4ol/NneuOBJGJzO57K b5oA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=KuJ46ov0M1WFwhfgzmspEFR4JVVYgLT88C9rn2uIR34=; fh=x37FUQupRG7+nn8dhrU/9pWdCOwEuy3w1GzjjlbBseU=; b=CZp1Xg6SebPf2dOV4AeWXLrT3HXEhzRmVUSydptMiGn13CsZSmudxb4JHXaazMAViN hsKHG47Svx+358avyNo+pDjElw9iGXkSzDJoJVUYlhbMw9ehjZWT6U+U4DUcFmwdsCBu 5vZyZ6V6fF0Kd/WTKfWDQ1tRFadrLcKNSQCk05XaLAF6X9R+oCZMqLqNuGIkl4qqJ3vh xzR1p8cvwaoUTevqLxUogePrfPl0r1JOSCPDbuOs8hlk/5QMmApgLE3EluKqN3dpO27r d9pPzD+pNSJbc7oFF5MHqcrRniEvwLowM1PEjNEG7HLyiDKHo90HM/GEErqtvAswvcmE cRTw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=bVWvnIiq; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-108070-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-108070-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id js10-20020a17090797ca00b00a46b2e490a1si3017455ejc.95.2024.03.19.12.38.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 12:38:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-108070-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=bVWvnIiq; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-108070-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-108070-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 70AD61F23591 for ; Tue, 19 Mar 2024 19:38:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4571D3A1DB; Tue, 19 Mar 2024 19:38:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="bVWvnIiq" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D458B1CAB2; Tue, 19 Mar 2024 19:38:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710877110; cv=none; b=JaaLDVeheBAkq6mwTBxsdEO+3qf7QwjfBUS7Blv0vbRSPO73lKtWQdhUT58uffWQJTUg/9mVVS3BA7OqLMC1I80d92GwxL1s98ZEQYHUjHkuwWEXLynyJrgTkpvNMj09ne5NMQMa3QZSneoVDAOieddDWKEW01/AP5VjAVV27Ws= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710877110; c=relaxed/simple; bh=kO1YJJtx2987pVea+qT8uhv2VHxBqnR51SKI5+CEBUs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=G5njgH+NA8cm5fvpgP2r2FLMt7ZoDzqgmKUPkykFwZGXQ/i+maR1h6g/b0p1DRECiTm67EqT1O+vwVrURZNL82vGC2x4nixyBPw4pycBPSDbTfGe+QfXHXWEghG4BEBF/M6JurIKcQccmw69aZK7kH5c7QipRNh97vg5XlXXNrw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=bVWvnIiq; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=KuJ46ov0M1WFwhfgzmspEFR4JVVYgLT88C9rn2uIR34=; b=bVWvnIiqzDGPrE99+90DS3V/0c FfzZ4Xx1Lkoij6a3fsPRHLBdnADgUk5RsDNbLcxQ2NbscnZBGNiTXVTGbJ2Ja7iCXcjY6XnIIWHaG IK4j2hgYiCnKYhMdZixQthGh23EC/SNWFf1icFUQv9MDVpt6mve9ZKTeoQvc26nVaRlA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rmfHf-00Ajib-Vv; Tue, 19 Mar 2024 20:38:03 +0100 Date: Tue, 19 Mar 2024 20:38:03 +0100 From: Andrew Lunn To: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= Cc: Daniel Golle , DENG Qingfang , Sean Wang , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , =?iso-8859-1?Q?Ren=E9?= van Dorst , Russell King , SkyLake Huang , Heiner Kallweit , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 0/3] Fix EEE support for MT7531 and MT7988 SoC switch Message-ID: <6cb585f6-6da8-45a2-a28b-2fb556f95672@lunn.ch> References: <20240318-for-net-mt7530-fix-eee-for-mt7531-mt7988-v> <00ec9779-19ce-4005-83f0-f4abf37350fc@arinc9.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <00ec9779-19ce-4005-83f0-f4abf37350fc@arinc9.com> > I would argue that EEE advertisement on the PHY should be enabled by > default. That is an open question at the moment. For some use cases, it can add extra delay and jitter which can cause problems. I've heard people doing PTP don't like EEE for example. The current phylib core code leaves the PHY advertisement whatever its reset default is. So we leave it to the manufacture to decide if it should be enabled or disabled by default. It is policy, so it should really be down to user space to configure EEE how it wants it. Andrew