Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp1114427lqt; Tue, 19 Mar 2024 13:07:57 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWk2g4RpI8YHQuVfW4TsN6VT85qjX4lBIjnW4Ojv6b9b1j5qBujm113YaDHn/Qu0bLDHMNe3aymulPSXgkkaUS1ZGoEP/Dz1KwjUcIU5A== X-Google-Smtp-Source: AGHT+IHhzSaXvB1Xtc5USTHKOPf+cgPn32NwwTYGC4Q4U90ztw5cVBtMw0BDsaWdT4zH5VY0CN6u X-Received: by 2002:a05:6a20:1589:b0:1a1:7713:acc with SMTP id h9-20020a056a20158900b001a177130accmr113302pzj.49.1710878877567; Tue, 19 Mar 2024 13:07:57 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710878877; cv=pass; d=google.com; s=arc-20160816; b=t7NDEgDVYEXQXDSieQUUx4WZydoBMtaQWyDCq3e15FzEh+WP3q5sdwiC7MY4Mo8hks 7u5oYLF12BR5hsDIzrIGvlCth91CBEEleOQcX8QE6gyBSnqx+J2w22L0WO3L7DIU7oRx A6zrStYaxLMiJj/KeI8vLUlQ5sBvllZwhzWkCkoX6dxd9NkwWGgp5dUGZxl2WC6YvEnV 99oLySmYph/BsuP89rqcWxKoeqvNYg5U6A0tr+b9TJ+WVIg0mS/tCZZ6E7KTDUNvnfzC 4czZlBosxuglxU3UOKolk9I0put63yITe3R6WPgWhY0lsdvvQtFt2g1VFOpjPFi8LTYU gG+g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=h8iYAvMZFu5A/68kV52L2WkrKjN4XdTrum+qmKp4Ffc=; fh=3vYK+9w6cdaebTHtqzKpdX5VN3+h404yNPo+l+5AZOA=; b=btFt50WklklQChuWDRllU/WS7H/PE2GEsP6t/n1hBv8pZfk2Q+inZrrVN2XSVfnDn0 giwvECt8rQB7zUo6gt4X5WVsj9unxTfSxYRW14AwpSIGLnd/zTweXsyGyLZ8NxpuOg1X TDe+0qjHZhlBCLSj0km/2FppEn+HNBIUliD0ikACD06ZC/6ADgFqfdhN2kZkbRmbxkbo 9UIV68wgg9gRlVUgkt5vlO2pvPongxsDBx8uiQyV/xNmVY6uqChNB0gx4CeDFwIwvZa2 d8YxFs4axxc5HrxOUTPkGCM5Yew5GssY/SV7vL9L+J2+Xx3kGnHFWgI5SUPHrcnQ2ORn rr6Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=F8hSzFIJ; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-108091-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-108091-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id t67-20020a632d46000000b005ce025116bbsi10770642pgt.858.2024.03.19.13.07.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 13:07:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-108091-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=F8hSzFIJ; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-108091-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-108091-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 7C61DB22042 for ; Tue, 19 Mar 2024 20:07:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 79A1957339; Tue, 19 Mar 2024 20:07:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="F8hSzFIJ" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26F4B5FB86; Tue, 19 Mar 2024 20:07:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710878863; cv=none; b=NG1GrTz8l/2/h8tf1AkWUFnnb2bSJrIE74Hjb+NmbwzUhl2H/+fL3FgobJHkjcxTDhaaBUE4lk9JIublHR6zq+mcWObATYDAfjUrp5QUIHkQ+UyJQAYWEq1EvYdf66fQbmoDolamMxFsCIyQ/VB3dKuo5aN57LaA5xQDNm9W36k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710878863; c=relaxed/simple; bh=CR6LOcX/INoY9Aw6zt9x/JGRV1GfCiWscRNG+bSuvRo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FGv5PIE2vEFrdUYy7eN+zp8ym13T6HDxLd5g6EEIy9hG2GOLi99H0sb8bnMYKm5zLx4khY9MvOppsoZFfFfLLciK4CncxZtxfN5eNJN3+vLbbFZtWdUCxTLGIa/hbo3EtyrXnplc/G6y/BWjame7H7A2cztD6hpNP7gsS1JqhzQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=F8hSzFIJ; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710878861; x=1742414861; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=CR6LOcX/INoY9Aw6zt9x/JGRV1GfCiWscRNG+bSuvRo=; b=F8hSzFIJAMNEE3yF7njTCrDcVG4DRAfHA6nwDHFSpizFDC2fS50PDimW anUw8+Gfus1hIubIjDzJsJIgym5uD95fb/DdWemaUOO4b/wXsdyTMhNJp diNQ48efGmqAMIfLFoloz5iXyIeqRA+9gAVFIERHqjw3jku0Eostl+TDN DWpg7uksBdaLVebU7OD9dLh/R6QhjwNl/IspeyQL5eTnpEe045cplJ0HK xPOItKEhwmdM5Bg6mPw/yco7hgSBwN54SQjf+05ABkKX0/zQILXr01WBl jyI4ZUMuSVr+1zugw5P0Ff8FDEQdX2VLDwRa3rDwF3ZyNkJ4wQhmiswzx A==; X-IronPort-AV: E=McAfee;i="6600,9927,11018"; a="5638693" X-IronPort-AV: E=Sophos;i="6.07,137,1708416000"; d="scan'208";a="5638693" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2024 13:07:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,137,1708416000"; d="scan'208";a="44877439" Received: from ccantr1x-mobl.amr.corp.intel.com (HELO [10.255.229.75]) ([10.255.229.75]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2024 13:07:40 -0700 Message-ID: <56958bb8-1b4e-4691-8d81-d8e5846a3b06@intel.com> Date: Tue, 19 Mar 2024 13:07:39 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 09/15] KVM: SEV: sync FPU and AVX state at LAUNCH_UPDATE_VMSA time Content-Language: en-US To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: michael.roth@amd.com, isaku.yamahata@intel.com, seanjc@google.com, Dave Hansen References: <20240318233352.2728327-1-pbonzini@redhat.com> <20240318233352.2728327-10-pbonzini@redhat.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240318233352.2728327-10-pbonzini@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/18/24 16:33, Paolo Bonzini wrote: > Since the XSAVE state for AVX is the first, it does not need the > compacted-state handling of get_xsave_addr(). However, there are other > parts of XSAVE state in the VMSA that currently are not handled, and > the validation logic of get_xsave_addr() is pointless to duplicate > in KVM, so move get_xsave_addr() to public FPU API; it is really just > a facility to operate on XSAVE state and does not expose any internal > details of arch/x86/kernel/fpu. We don't want to grow _too_ many users of get_xsave_addr() since it's hard to use it right. But this seems to be a legitimate user. Acked-by: Dave Hansen