Received-SPF: pass (google.com: domain of linux-kernel+bounces-108111-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240319055115.4063940-1-namhyung@kernel.org> <20240319055115.4063940-5-namhyung@kernel.org>
 <ZfmZobDmVFxEQ6hU@x1> <CAM9d7chdEcA7qFS3k=DGfeXcdZP1xWvdory_-Q0WFPfGi0St_Q@mail.gmail.com>
 <ZfnXIm2rRnzVcZ4n@x1>
In-Reply-To: <ZfnXIm2rRnzVcZ4n@x1>
From: Namhyung Kim <namhyung@kernel.org>
Date: Tue, 19 Mar 2024 13:33:31 -0700
Message-ID: <CAM9d7ciNeiDBmz_ip_mTAyMf3Vzi6tbCdCRQdJ3==xKMKGJ2jQ@mail.gmail.com>
Subject: Re: [PATCH 04/23] perf dwarf-aux: Add die_find_func_rettype()
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ian Rogers <irogers@google.com>, Jiri Olsa <jolsa@kernel.org>, 
	Adrian Hunter <adrian.hunter@intel.com>, Peter Zijlstra <peterz@infradead.org>, 
	Ingo Molnar <mingo@kernel.org>, LKML <linux-kernel@vger.kernel.org>, 
	linux-perf-users@vger.kernel.org, 
	Linus Torvalds <torvalds@linux-foundation.org>, Stephane Eranian <eranian@google.com>, 
	Masami Hiramatsu <mhiramat@kernel.org>, linux-toolchains@vger.kernel.org, 
	linux-trace-devel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 19, 2024 at 11:19=E2=80=AFAM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> On Tue, Mar 19, 2024 at 10:42:00AM -0700, Namhyung Kim wrote:
> > On Tue, Mar 19, 2024 at 6:56=E2=80=AFAM Arnaldo Carvalho de Melo
> > > > +             return NULL;
> > > > +
> > > > +     if (die_get_real_type(&tmp_die, die_mem) =3D=3D NULL)
> > > > +             return NULL;
> > >
> > >
> > > Here you check die_get_real_type() return, may I go and do the same f=
or
> > > the previous patch to address my review comment?
> >
> > Sure thing! :)
>
> Ack?

Yep, looks good!

Thanks,
Namhyung

>
> - Arnaldo
>
> diff --git a/tools/perf/util/dwarf-aux.c b/tools/perf/util/dwarf-aux.c
> index cd9364d296b6bf42..09fd6f1f0ed8eac3 100644
> --- a/tools/perf/util/dwarf-aux.c
> +++ b/tools/perf/util/dwarf-aux.c
> @@ -1856,7 +1856,10 @@ static int __die_find_member_offset_cb(Dwarf_Die *=
die_mem, void *arg)
>         if (offset =3D=3D loc)
>                 return DIE_FIND_CB_END;
>
> -       die_get_real_type(die_mem, &type_die);
> +       if (die_get_real_type(die_mem, &type_die) =3D=3D NULL) {
> +               // TODO: add a pr_debug_dtp() later for this unlikely fai=
lure
> +               return DIE_FIND_CB_SIBLING;
> +       }
>
>         if (dwarf_aggregate_size(&type_die, &size) < 0)
>                 size =3D 0;