Received-SPF: pass (google.com: domain of linux-kernel+bounces-108114-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Tue, 19 Mar 2024 22:43:28 +0200
Message-Id: <CZY0P8Z9MKWI.UDXUUC9BD43U@kernel.org>
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Jarkko Sakkinen" <jarkko@kernel.org>, "James Bottomley"
 <James.Bottomley@HansenPartnership.com>, <linux-kernel@vger.kernel.org>
Cc: "Jason Gunthorpe" <jgg@ziepe.ca>, "Mimi Zohar" <zohar@linux.ibm.com>,
 "Peter Huewe" <peterhuewe@gmx.de>, <linux-integrity@vger.kernel.org>
Subject: Re: [PATCH] MAINTAINERS: Update W's for KEYS/KEYRINGS_INTEGRITY and
 TPM DEVICE RIVER
References: <20240226062245.2279635-1-jarkko@kernel.org>
 <eaa5107ac4f982b6fd6e80b522643a591e719dc9.camel@HansenPartnership.com>
 <CZEWILFMZ5L1.2TCZXVS7GTDKZ@suppilovahvero>
 <3bae009a24a55902d93e4055ecd13f9f54cdbb37.camel@HansenPartnership.com>
 <CZG2JXJ83L7K.32PU7BZTQNHLV@kernel.org>
In-Reply-To: <CZG2JXJ83L7K.32PU7BZTQNHLV@kernel.org>

On Tue Feb 27, 2024 at 8:22 PM EET, Jarkko Sakkinen wrote:
> On Mon Feb 26, 2024 at 12:11 PM EET, James Bottomley wrote:
> > On Mon, 2024-02-26 at 11:26 +0200, Jarkko Sakkinen wrote:
> > > On Mon Feb 26, 2024 at 8:49 AM EET, James Bottomley wrote:
> > > > On Mon, 2024-02-26 at 08:22 +0200, Jarkko Sakkinen wrote:
> > > > > Add TPM driver test suite URL to the MAINTAINERS files and move
> > > > > the
> > > > > wiki
> > > > > URL to more appropriate location.
> > > > >=20
> > > > > Link: https://gitlab.com/jarkkojs/linux-tpmdd-test
> > > > > Link: https://kernsec.org/wiki/index.php/Linux_Kernel_Integrity
> > > > > Cc: Jason Gunthorpe <jgg@ziepe.ca>
> > > > > Cc: Mimi Zohar <zohar@linux.ibm.com>
> > > > > Cc: Peter Huewe <peterhuewe@gmx.de>
> > > > > Cc: linux-integrity@vger.kernel.org
> > > > > Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> > > > > ---
> > > > > =C2=A0MAINTAINERS | 3 ++-
> > > > > =C2=A01 file changed, 2 insertions(+), 1 deletion(-)
> > > > >=20
> > > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > > index bf77be03fb2b..6380c1109b86 100644
> > > > > --- a/MAINTAINERS
> > > > > +++ b/MAINTAINERS
> > > > > @@ -11947,6 +11947,7 @@ M:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Mim=
i Zohar <zohar@linux.ibm.com>
> > > > > =C2=A0L:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0linux-integrity@vger.kernel=
org
> > > > > =C2=A0L:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0keyrings@vger.kernel.org
> > > > > =C2=A0S:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Supported
> > > > > +W:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0https://kernsec.org/wiki/index.p=
hp/inux_Kernel_Integrity
> > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^
> > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 Missing L
> > > >=20
> > > > James
> > >=20
> > > Thanks! I'll fixup that.
> > >=20
> > > "linux-tpmdd-test" is the suite that I'm using to test your patch
> > > set. It has swtpm integrated. I wonder if there was easy to way to
> > > tweak swtpm to emulate "interposer", i.e. reset its state while it is
> > > running (preferably not by restarting it).
> >
> > The way I do it is to use a qemu patch
> >
> > https://lore.kernel.org/qemu-devel/20231004184219.6594-1-jejb@linux.ibm=
com/
> >
> > which allows qemu to connect to the mssim (or ibmswtpm2) TPM over an
> > inet socket which means I can execute TPM commands from the host (like
> > resetting the TPM) as well as the guest and snoop the TPM traffic.
>
> To which exact and most recent possible QEMU version I can apply that
> cleanly?
>
> My build configuration builds both QEMU and swtpm [1] for every build so
> I could pick that patch, copy it to board/qemu/patches/qemu, and set the
> version in the BuildRoot configuration appropriately.
>
> [1]
> https://gitlab.com/jarkkojs/linux-tpmdd-test/-/tree/main/package/libtpms
> https://gitlab.com/jarkkojs/linux-tpmdd-test/-/tree/main/package/swtpm

Friendly ping. Still looking forward to test.

I cannot recall exact review comments for v7 but what I can recall is
that they were cosmetic.

BR, Jarkko