Received-SPF: pass (google.com: domain of linux-kernel+bounces-108181-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
Date: Tue, 19 Mar 2024 22:13:41 +0000
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
From: "Anton Bambura" <jenneron@postmarketos.org>
Message-ID: <87c34b2d0a062497488aa1c7e3f0d12d3a029828@postmarketos.org>
TLS-Required: No
Subject: Re: [PATCH v2 4/6] arm64: dts: qcom: sc8180x-lenovo-flex-5g: enable
 touchscreen
To: "Bjorn Andersson" <andersson@kernel.org>
Cc: "Konrad Dybcio" <konrad.dybcio@linaro.org>, "Rob Herring"
 <robh+dt@kernel.org>, "Krzysztof Kozlowski"
 <krzysztof.kozlowski+dt@linaro.org>, "Conor Dooley"
 <conor+dt@kernel.org>, linux-arm-msm@vger.kernel.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
In-Reply-To: <2tq6m75m3skcu5wlvrwpwnn53kay3pzo2aeecofxpfnll7mwqn@whtnrabrrivw>
References: <20240203191200.99185-1-jenneron@postmarketos.org>
 <20240203191200.99185-5-jenneron@postmarketos.org>
 <2tq6m75m3skcu5wlvrwpwnn53kay3pzo2aeecofxpfnll7mwqn@whtnrabrrivw>

March 18, 2024 at 4:43 AM, "Bjorn Andersson" <andersson@kernel.org> wrote=
:


>=20
>=20On Sat, Feb 03, 2024 at 09:11:58PM +0200, Anton Bambura wrote:
>=20
>=20>=20
>=20> Set regulators, reset gpio and delays according to ACPI tables.
> >=20
>=20>=20=20
>=20>=20
>=20>  Signed-off-by: Anton Bambura <jenneron@postmarketos.org>
> >=20
>=20>  ---
> >=20
>=20>  .../boot/dts/qcom/sc8180x-lenovo-flex-5g.dts | 30 ++++++++++++++++=
++-
> >=20
>=20>  1 file changed, 29 insertions(+), 1 deletion(-)
> >=20
>=20>=20=20
>=20>=20
>=20>  diff --git a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts b=
/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> >=20
>=20>  index 6ae6cb030b70..5bf6285f905f 100644
> >=20
>=20>  --- a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> >=20
>=20>  +++ b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> >=20
>=20>  @@ -271,6 +271,12 @@ vreg_l3c_1p2: ldo3 {
> >=20
>=20>  regulator-initial-mode =3D <RPMH_REGULATOR_MODE_HPM>;
> >=20
>=20>  };
> >=20
>=20>=20=20
>=20>=20
>=20>  + vreg_l4c_3p3: ldo4 {
> >=20
>=20>  + regulator-min-microvolt =3D <3296000>;
> >=20
>=20>  + regulator-max-microvolt =3D <3304000>;
> >=20
>=20>  + regulator-initial-mode =3D <RPMH_REGULATOR_MODE_HPM>;
> >=20
>=20>  + };
> >=20
>=20>  +
> >=20
>=20>  vreg_l10c_3p3: ldo10 {
> >=20
>=20>  regulator-min-microvolt =3D <3000000>;
> >=20
>=20>  regulator-max-microvolt =3D <3312000>;
> >=20
>=20>  @@ -337,6 +343,12 @@ vreg_l10e_2p9: ldo10 {
> >=20
>=20>  regulator-initial-mode =3D <RPMH_REGULATOR_MODE_HPM>;
> >=20
>=20>  };
> >=20
>=20>=20=20
>=20>=20
>=20>  + vreg_l12e_1p8: ldo12 {
> >=20
>=20>  + regulator-min-microvolt =3D <1800000>;
> >=20
>=20>  + regulator-max-microvolt =3D <1800000>;
> >=20
>=20>  + regulator-initial-mode =3D <RPMH_REGULATOR_MODE_HPM>;
> >=20
>=20>  + };
> >=20
>=20>  +
> >=20
>=20>  vreg_l16e_3p0: ldo16 {
> >=20
>=20>  regulator-min-microvolt =3D <3072000>;
> >=20
>=20>  regulator-max-microvolt =3D <3072000>;
> >=20
>=20>  @@ -365,11 +377,19 @@ &i2c1 {
> >=20
>=20>  touchscreen@10 {
> >=20
>=20>  compatible =3D "hid-over-i2c";
> >=20
>=20>  reg =3D <0x10>;
> >=20
>=20>  +
> >=20
>=20>  hid-descr-addr =3D <0x1>;
> >=20
>=20>  + reset-gpios =3D <&tlmm 54 GPIO_ACTIVE_LOW>;
> >=20
>=20>  +
> >=20
>=20>  + vdd-supply =3D <&vreg_l4c_3p3>;
> >=20
>=20>  + vddl-supply =3D <&vreg_l12e_1p8>;
> >=20
>=20>  +
> >=20
>=20>  + post-power-on-delay-ms =3D <3>;
> >=20
>=20>  + post-reset-deassert-delay-ms =3D <200>;
> >=20
>=20
> As I ran into with the X13s, post-reset-deassert-delay-ms is not an
>=20
>=20accepted property for hid-over-i2c. I think the desired path forward =
is
>=20
>=20to extend elan,ekth6915.yaml and i2c-hid-of-elan.c and hard code thes=
e
>=20
>=20values there instead.
>=20
>=20But I suspect you, like me, are unaware of the actual name of the
>=20
>=20device? Perhaps it's acceptable to make something up based on the
>=20
>=20reported product id?

Indeed, I don't know the actual IC. evtest reports this:

Input device ID: bus 0x18 vendor 0x4f3 product 0x2a7d version 0x100
Input device name: "hid-over-i2c 04F3:2A7D"

>=20
>=20Regards,
>=20
>=20Bjorn
>=20
>=20>=20
>=20> interrupts-extended =3D <&tlmm 122 IRQ_TYPE_LEVEL_LOW>;
> >=20
>=20>=20=20
>=20>=20
>=20>  - pinctrl-0 =3D <&ts_int_default>;
> >=20
>=20>  + pinctrl-0 =3D <&ts_int_default>, <&ts_reset_default>;
> >=20
>=20>  pinctrl-names =3D "default";
> >=20
>=20>  };
> >=20
>=20>  };
> >=20
>=20>  @@ -735,6 +755,14 @@ ts_int_default: ts-int-default-state {
> >=20
>=20>  drive-strength =3D <2>;
> >=20
>=20>  };
> >=20
> >=20=20
>=20>=20
>=20>  + ts_reset_default: ts-reset-default-state {
> >=20
>=20>  + pins =3D "gpio54";
> >=20
>=20>  + function =3D "gpio";
> >=20
>=20>  +
> >=20
>=20>  + bias-disable;
> >=20
>=20>  + drive-strength =3D <16>;
> >=20
>=20>  + };
> >=20
>=20>  +
> >=20
>=20>  usbprim_sbu_default: usbprim-sbu-state {
> >=20
>=20>  oe-n-pins {
> >=20
>=20>  pins =3D "gpio152";
> >=20
>=20>  --=20
>=20>=20
>=20>  2.42.0
> >
>