Received-SPF: pass (google.com: domain of linux-kernel+bounces-108239-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
IronPort-PHdr: A9a23:14HXyh2f1Mx2wOp5smDPY1BlVkEcU/3cNwoR7N8gk71RN/nl9JX5N
 0uZ7vJo3xfFXoTevupNkPGe87vhVmoJ/YubvTgcfYZNWR4IhYRenwEpDMOfT0yuBPXrdCc9W
 s9FUQwt5Gm1ZHBcA922fFjOuju35D8WFA/4MF92L/7pG4rbjOy81vu5/NvYZAAbzDa4aKl5e
 Q2/th6Z9tFDm4ZgJ60tghfIuS5OfOJbhCtkcFmShB37oMy3+fZe
IronPort-Data: A9a23:7HAXI67pGJbjSipQKKVEHAxRtB7HchMFZxGqfqrLsTDasY5as4F+v
 mpLXWrTM/rfamr1KY10b9u+9hkB7cLWnNZiGVFrripnZn8b8sCt6fZ1gavT04J+CuWZESqLO
 u1HMoGowPgcFyKa/lH1dOG58RGQ7InQLpLkEunIJyttcgFtTSYlmHpLlvUw6mJSqYDR7zil5
 5Wq/KUzBHf/g2QoajlNuvrYwP9SlK2aVA0w7wRWic9j5Dcyp1FNZLoDKKe4KWfPQ4U8NoZWk
 M6akdlVVkuAl/scIovNfoTTKyXmcZaOVeS6sUe6boD56vR0SoPe5Y5gXBYUQR8/ZzxkBLmdw
 v0V3XC7YV9B0qEhBI3xXjEAexySM5Gq95fmHWG/gZSr3XbJVEO86fZiL2cGM5chr7Mf7WFmr
 ZT0KRgXZRyFwumx2r/+FK9nh98oK4/gO4Z3VnNIlG6CS615B8GYBfyXure03x9o7ixKNfXXf
 dYYbTNsRB/BeBZIfFwQDfrSmc/y3iKgL2QJ8wr9Sawf4UX9khEr0YnXM/H0aP+yYZ4Nr3ffn
 zeTl4j+KkpHbIPEk2XtHmiXruvOmz7rHZkZD7yQ6PFnmhuQy3YVBRlQUkG0ydG9i0ijS5dcJ
 lYS9y4Gs6c/7gqoQ8P7Uhn+p2SL1iPwQPJKGOE8rQqK0KeRvUCSB3MPSXhKb9lOWNIKqSIC9
 2OQn+OxPS5Uv5qtGVie+pSynT2oAH1ARYMdXhMsQQwA6tjlhYg8iBPTU9pueJJZaPWrQ1kcJ
 BjU9kADa6UvsCId60msEbn6b9+EvJPFSEs+4R/aGzzj5QJib4njbIutgbQ60RqiBNjHJrVil
 CFY8yR70AzoJcrQ/MBqaL5QdIxFH97fbFXhbadHRvHNDQiF9X+5Zpx36zpjPkpvOctsUWa2O
 ReD5lgJu8MLYCvCgUpLj2SZVpRCIU/ISISNaxwoRoYmjmVZLVbYrH80OSZ8IUiyzhBEfV4D1
 WezKpv0Ui1AVsyLPRK9RvwW1vcw1zsiyGbIDZH9xFLP7FZtTCD9dFvxC3PXNrpRxPrd+G39q
 o8PX+PUkE83eLOlPUHqHXs7cApiwY4TX86m8qS6t4erf2JbJY3WI6aKkeN8KtM7xvQ9eyWh1
 ijVZ3K0AWHX3BXvAQ6LcXtkLrjoWP5CQbgTZETA4X7AN6AfXLuS
IronPort-HdrOrdr: A9a23:OI3gwq8PmAbVQTT1MDZuk+Gddr1zdoMgy1knxilNoENuA6+lfp
 GV/MjziyWUtN9IYgBQpTnhAsW9qXO1z+8N3WBjB8bTYOCAghrnEGgC1/qs/9SEIVydygcz79
 YcT0ETMqyWMbE+t7eF3ODaKadg/DDkytHVuQ629R4EJm8aDtAF0+46MHflLqQcfng/OXNNLu
 vn2iMxnUvaRZ14VLXcOlA1G8L4i5ngkpXgbRQaBxghxjWvoFqTgoLSIlyz5DtbdylA74sD3A
 H+/jAR4J/Nj9iLjjvnk0PD5ZVfn9XsjvFZAtaXt8QTIjLwzi61eYVIQdS5zXMIidDqzGxvvM
 jHoh8mMcg2wWjWZHuJrRzk3BSl+Coy6kXl1USTjRLY0I7ErXMBeo98bLBiA1zkAnkbzZdBOW
 VwrjukXq9sfFf9deLGloD1vl9R5xGJSDEZ4J0uZjRkIPkjgflq3MwiFIc/KuZcIMo8g7pXSt
 VGHYXS4u1bfkidaG2ctm5zwMa0VnB2BRueRFMe0/blmQS+sUoJh3fw/vZv1Uso5dY4Ud1J9u
 7EOqNnmPVHSdIXd7t0AKMETdGsAmLATBrQOCbKSG6XWJ0vKjbIsdr68b817OaldNgBy4Yzgo
 3IVBdduXQpc0zjBMWS1NlA8wzLQm+6QTPxo/suqqRRq/n5Xv7mICeDQFchn4+ppOgeGNTSX7
 KpNJdfE5bYXCLT8EZyrnvDsrVpWA4juZcuy6MGsnq107b2FrE=
From: "Karan Tilak Kumar (kartilak)" <kartilak@cisco.com>
To: Li Zhijian <lizhijian@fujitsu.com>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
CC: "Sesidhar Baddela (sebaddel)" <sebaddel@cisco.com>,
        "James E.J. Bottomley"
	<jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: RE: [PATCH v2 12/25] scsi: snic: Convert sprintf() family to
 sysfs_emit() family
Thread-Topic: [PATCH v2 12/25] scsi: snic: Convert sprintf() family to
 sysfs_emit() family
Thread-Index: AQHaecc+MkuUcRMBh0aVAdlHnrVgVrE/t/wQ
Date: Tue, 19 Mar 2024 23:39:02 +0000
Message-ID:
 <SJ0PR11MB5896A8AF663BFF279C8077E7C32C2@SJ0PR11MB5896.namprd11.prod.outlook.com>
References: <20240319063132.1588443-1-lizhijian@fujitsu.com>
 <20240319063132.1588443-12-lizhijian@fujitsu.com>
In-Reply-To: <20240319063132.1588443-12-lizhijian@fujitsu.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?rYVtiZClPquLuLBLvdmI8y/QwjBxM2qdqMTkwJPMfIeMB9w8aI4DJZdycWXH?=
 =?us-ascii?Q?VnBS9sKNkrKoLHVPQvWcBrplk/3D3WoeBd3GK5wyySX7EIUFwd4a9HuCUqSX?=
 =?us-ascii?Q?g3OH+9i1/6bq0tILLKF9ANYAawtkJ4+6vtP3e47X+OKNAE08sRdbYsfoiM6B?=
 =?us-ascii?Q?OXxpEFX4LzYf2SaWCL04cz/TZFb38PrQn238E2dsCika6BkADl8YKeS8UF4p?=
 =?us-ascii?Q?da73iNu2x9Ossd6ALXHAKGlQPbpO8pIJBL8AahWbjg5qGoOtsHAAuaGTzimH?=
 =?us-ascii?Q?0WKrME8ICenDeJHNcCP32FXicbog46vvh8w96AH5PUaxD2puFgOvqqF5O5jR?=
 =?us-ascii?Q?L3cfSldvMdOSUzBk9ecuXTywUcjy6WhDWK9fiwmKgpW74kPtxVEeJNV6usOZ?=
 =?us-ascii?Q?+o0nOeHdpAD5viuTohRz8HQzFOMK1djntxCSuypHFK+/2/8WBe1E7n17340c?=
 =?us-ascii?Q?PMeN0tAsLj7QJOFNnRwdSS/d/otktsrjrob6EQwZ9ivrMmdPIj8UlTcxV5Ol?=
 =?us-ascii?Q?o7i8YefA4SThxVZ8GSL+KcjyHM9fDr07bSEgM6lzcBmHmFY6w0Dohebb9Egr?=
 =?us-ascii?Q?KagZUsMV/88kaHNat0SHeaZxWbezmhCnb348+nKJPewkRxTFe1VQofQrFH+j?=
 =?us-ascii?Q?V+xr1qrkJ5Opw2DdxWsKCEshpyZboheMTL9sdISuk/tpq9VEW5sGQPN6Z5CT?=
 =?us-ascii?Q?pjBFlgAHyQwlcH/3gVDS6esNbEaZUF0R/3qOESPyd/msn/piRZQ/PcwxGE2h?=
 =?us-ascii?Q?rh0yinmobL80SmTxpzHf/kYbzgc/A/KTw1hlcIMH/wFfqUTNM6HsttYboMqD?=
 =?us-ascii?Q?oGbBTWnWtEtoKy6q9L6+KDYUX3a7O02DeOS+BT4HHb4vpA8zXSo5QVhh4Iu1?=
 =?us-ascii?Q?bmKqLzRLg/DFhFTxlPYCntbQsFo3GX02G40rLCfXzkCFxy9MemhQ6moMQuaO?=
 =?us-ascii?Q?ABV1YSXBc/44ci5JMYs13XnqHGQQSwENdX1Z2K2QFCuLtZH+pEcSGCONetxA?=
 =?us-ascii?Q?aEcq6PgxbiRIBAVDeET+lN0qk9PmDgEEmimGNKVC79aIrDQMR8ywo7KJl4cq?=
 =?us-ascii?Q?mWnU+veLoxvA1/8YOtzvhX2ve4baMFGpCrqtYMfsoVYOKBhlmu7GldzpHpWn?=
 =?us-ascii?Q?62P1cdIXZh3iWjqNOAvbAUQ6fSFZKbVoz5bIH3BJYJwFttAYVFuGoHhtc5sd?=
 =?us-ascii?Q?W2D5ZoezWHnqoJu3p7qhAxTqDIWnYPXpgPV7sxcoDSrgHGvlYjv9fmZxVScN?=
 =?us-ascii?Q?iiZuwxnpwtO5XfVC0GdsiGjvcIIeqcX6Q9mikvocLs+aCOW7Z6LZdprCM6pp?=
 =?us-ascii?Q?/FPxUSpo0hDnR0FUFTD/J45qogzY2DBryTFoF1sEkDkTh0Y7oCdwXFbseDJ0?=
 =?us-ascii?Q?a8EzpmhP81nA4t5nO45gGIdWWf5C2/rIWy2ADTjk9DCqDCP3zLWTfaknlCPQ?=
 =?us-ascii?Q?t+L9DMF4mPjCOnbjJXwdhxuiOYclZGIDyILwmcJtcQYopAPagWq7Rc9BnW6/?=
 =?us-ascii?Q?sEUXOzN9vc/yt0HyMlH8rWUCDPDIWmvOR47Z0q3cys44piHuYvpTA96anKu7?=
 =?us-ascii?Q?5W7NhhTP+tsskjzWjYV2gbkM9NAEbvZayG5fml4N3/B0GKnqVD8A96rokeBJ?=
 =?us-ascii?Q?Wa3xWM50n3lYWOWAnVokm2P6rBv8+YHT/omScLbd8A+O?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: cisco.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5896.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 16177d37-7a62-4f3a-4c41-08dc486dc211
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Mar 2024 23:39:02.4149
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hcHQEWLTy8HeiMAwxO149VTGYYIZRSypZeshxqql5sWULDFEToDwn2rUUrTiHD05Elj6PW4Zp2tVEu2tnCxvGw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4900
X-Outbound-SMTP-Client: 173.37.147.253, alln-opgw-5.cisco.com
X-Outbound-Node: rcdn-core-6.cisco.com

On Monday, March 18, 2024 11:31 PM, Li Zhijian <lizhijian@fujitsu.com> wrot=
e:
>
> Per filesystems/sysfs.rst, show() should only use sysfs_emit() or sysfs_e=
mit_at() when formatting the value to be returned to user space.
>
> coccinelle complains that there are still a couple of functions that use =
snprintf(). Convert them to sysfs_emit().
>
> sprintf() and scnprintf() will be converted as well if they have.
>
> Generally, this patch is generated by
> make coccicheck M=3D<path/to/file> MODE=3Dpatch \ COCCI=3Dscripts/coccine=
lle/api/device_attr_show.cocci
>
> No functional change intended
>
> CC: Karan Tilak Kumar <kartilak@cisco.com>
> CC: Sesidhar Baddela <sebaddel@cisco.com>
> CC: "James E.J. Bottomley" <jejb@linux.ibm.com>
> CC: "Martin K. Petersen" <martin.petersen@oracle.com>
> CC: linux-scsi@vger.kernel.org
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
> This is a part of the work "Fix coccicheck device_attr_show warnings"[1] =
Split them per subsystem so that the maintainer can review it easily [1] ht=
tps://lore.kernel.org/lkml/20240116041129.3937800-1-lizhijian@fujitsu.com/
> ---
> drivers/scsi/snic/snic_attrs.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/scsi/snic/snic_attrs.c b/drivers/scsi/snic/snic_attr=
s.c index 3ddbdbc3ded1..48bf82d042b4 100644
> --- a/drivers/scsi/snic/snic_attrs.c
> +++ b/drivers/scsi/snic/snic_attrs.c
> @@ -13,7 +13,7 @@ snic_show_sym_name(struct device *dev,  {
> struct snic *snic =3D shost_priv(class_to_shost(dev));
>
> -     return snprintf(buf, PAGE_SIZE, "%s\n", snic->name);
> +     return sysfs_emit(buf, "%s\n", snic->name);
> }
>
> static ssize_t
> @@ -23,8 +23,7 @@ snic_show_state(struct device *dev,  {
> struct snic *snic =3D shost_priv(class_to_shost(dev));
>
> -     return snprintf(buf, PAGE_SIZE, "%s\n",
> -                     snic_state_str[snic_get_state(snic)]);
> +     return sysfs_emit(buf, "%s\n", snic_state_str[snic_get_state(snic)]=
);
> }
>
> static ssize_t
> @@ -32,7 +31,7 @@ snic_show_drv_version(struct device *dev,
> struct device_attribute *attr,
> char *buf)
> {
> -     return snprintf(buf, PAGE_SIZE, "%s\n", SNIC_DRV_VERSION);
> +     return sysfs_emit(buf, "%s\n", SNIC_DRV_VERSION);
> }
>
> static ssize_t
> @@ -45,8 +44,8 @@ snic_show_link_state(struct device *dev,
> if (snic->config.xpt_type =3D=3D SNIC_DAS)
> snic->link_status =3D svnic_dev_link_status(snic->vdev);
>
> -     return snprintf(buf, PAGE_SIZE, "%s\n",
> -                     (snic->link_status) ? "Link Up" : "Link Down");
> +     return sysfs_emit(buf, "%s\n",
> +                       (snic->link_status) ? "Link Up" : "Link Down");
> }
>
> static DEVICE_ATTR(snic_sym_name, S_IRUGO, snic_show_sym_name, NULL);
> --
> 2.29.2
>
>

Reviewed-by: Karan Tilak Kumar <kartilak@cisco.com>

Regards,
Karan