Received-SPF: pass (google.com: domain of linux-kernel+bounces-108241-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID:
 <JH0PR01MB57807C10CBF09DC49C8A7CF6CB2C2@JH0PR01MB5780.apcprd01.prod.exchangelabs.com>
Date: Wed, 20 Mar 2024 07:49:05 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] workqueue: add function in event of
 workqueue_activate_work
To: tj@kernel.org
Cc: mhiramat@kernel.org, mathieu.desnoyers@efficios.com,
 linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
 Kassey Li <quic_yingangl@quicinc.com>, Steven Rostedt <rostedt@goodmis.org>
References: <20240308021818.2306176-1-quic_yingangl@quicinc.com>
 <20240307212356.2e4d77d7@gandalf.local.home>
From: kassey li <kassey_li_1216@outlook.com>
In-Reply-To: <20240307212356.2e4d77d7@gandalf.local.home>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: JH0PR01MB5780:EE_|SEZPR01MB4502:EE_
X-MS-Office365-Filtering-Correlation-Id: dd53d1f9-0d21-49fd-b97f-08dc486f2cd3
X-MS-Exchange-SLBlob-MailProps:
	WaIXnCbdHrMKDiLrK7zKqACv4bCVGfEVW2f7IPkEkDpUbM+78X4Bm0PtQJHguRiNvanljUXJBf9HEwydgSanPjiWzjf2M5eaUYnNtKDb5H3AHVrVXG5m5yf8FfrJGjyb9EUS29NhxtnUAAsQX2DSkX38u+FL5SBGDIVBDKv8cl1wyvBSGz4NSAZTzGAD34XkYH5VYWRBsdX0LGk/d2BTllg0P50W7sFHgSf65zbsl2n64lYTs0lQC0qBIFqakMqhF8xmd7c4s7tyRWDhAHmnOe2XNYkT3+dNBdLh98nR88seneQWq/D1K8wER/y0ct6J2ujln20wCG8j49KbtHh9gJH5qx1brVZHxbWGx9Yx5y20wHLp6G0eGe3J+HQbnjXhEB4gsOpkoNUdJp/VlB6RuZMb7A/bwvhw4EmBsoBD/k+FpJr/WJU4g5jR/RYPY5WahZ9GfCVYEkJfQ5O7uAUpTFS1UywCY8m0cN1XVhy9mc90lDS4vUFMe45Jd57AdF9WHcx8F3kzIiBog1fXxuBWBDnluQUsdNIwIQtGkNbCZGWpOxMaHv/2rhXI/easCo0CMRjsgXDgWaRdsZufZEp0pVEJFUeR6Yy8+XoinU4zUpbDoxXfapcHoijQBsq49JyJt+rIYVw5w4uIweOdYlyN4sGGdgJMkW9ZUcNNnojd3uX/I1g0dGKPQAgF3RqdFAVhzcDW5zq54Snw04m1FIcZavqy5USZYLXKZTZuT2n9K4ci8SctBbBpXxJyhfWMAc5v2VKwBRa+wys=
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+wDZzc5GEvMj55ssCZdttxtuXKUVpnS+3i63lfeWcAmOXUAL7fub9i8Q2ZeAegJD6Ki/Ujo2XuwZTegza/HARRmdTFcnaPVPhlXlYnAXqdgL2fZuLx7Ip6QxlMNVYKg1W/T/nq7AVPRSo3l7vDZ9EL/BCq1TsjqryEg2MdSs+6kHFO2LqIZ2bOL9EfV4lFnaGRgR3qnDCh63YwXvlinao8ALqmugm2lWTADJMBNqqUWEhWPWyQYFsOo81srtld4Por/2bckIpEz2edFiVZi9p37THp03C7gl60+SWrfrwjlodMyh8dNiGB8tCLClhY8pI+lKeahg3Vq568K/41h0oNgGxjx0ujTwHXT4lPM7ZDJSpBdK1uNOChWejYcYGcKwPXbDiOlhHrMgd3b8CT/SOMXDPZf7RXlwzVlJIcuFm+r5HmRGwhj0AhDWBQ+bb2Vk/UNPr65uKRg4sWQcuasjEv3fsbQ9pFRZ88Q/zpwRuXiIaWoycfOQFn5Ghukpf2oZ46rsQWd1G9ZX/8p9pc/GLxhVKOjF3Qrb3dDwlcStLbqbKqtpFZh+jCCu0muzzHkZFIt1/t6ELcrJZAcv6ZeLcEsJOasI+QIZFKzbQTrYpejx9QaF1CpEwXxi1RBIVLUo3HXRoXsERC//fm/6HdotI6wey/dsugAVraVyyIqCnfk=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OU1LVjVlYk9Ydkl0c0krMDdaaUpVQmRuTEJ6a1dpbStDdXdGeGFHd0IxUXRz?=
 =?utf-8?B?UExnZWdKZHNvYTdsUXpkLzMrUUVEWEFhWmJ0ZHBydThDc0pQWUZ5RkFaZG9G?=
 =?utf-8?B?RUcvK25NL0oxNXYvQXU5dzdmeUpFODBSZWVOemo4Q1NHR04zZjl6S081Ti93?=
 =?utf-8?B?dldLdkR1Y205NU91MzVZTEVKN2p4MWNNU2lTai9ZTjlWd0IwNzlveUcvbDhN?=
 =?utf-8?B?b3NseEJkRTZETjJ1TlllRVNwUjBEamx4aEN4Z0xCSjlUOHJ6QnJIVlhsc2hB?=
 =?utf-8?B?TnhMUm1yNkt0MVFxMGpMdWI3TmZsNTR0L1FFcEhnS1NnN2tTeXkxN0RiZGNz?=
 =?utf-8?B?Q2pseFRXTkVMam9ubnJxbVZxOHNadCt2UFVNcmhQQU9UOTdIRWdqREFGVm82?=
 =?utf-8?B?azc5N0MwQXlKVk1ZQUxuV3Fyd0lkcExYY3hoN2RndmNwZitOSUhVZkJjRnB5?=
 =?utf-8?B?UW1lTjR5SUhKRTVYNlZNUjRpejFYTXJnWG03NURkR0ozbkxrT3lJVmpHZnlw?=
 =?utf-8?B?cXM0TzdRZllKY1ZVMDZMeDNPZGxsSFAweHAvdXQyTG51Q3NnUkdLY09Ja25z?=
 =?utf-8?B?bndTMGNYbkVlU1dWV1haeElOK3pzdk0yMGQ2cDhuWEJ5aW16YzkwZ2dHY3pL?=
 =?utf-8?B?MDQ5ZFVUeEtIWU9uWGhzMGxmbFZtTktmbnVzdHNXTSt2cjhzTk9DU3hsTkRZ?=
 =?utf-8?B?QmFIL2JYZWFuTFNBMFNTVVJhNDFWcGxTMEdIZW5mcUo0azZzZDBRVVF0a2xU?=
 =?utf-8?B?WWJqSHB4WmlEem9lbUZmZWpLWm5rSzM4QnBudEVITGZuWmRITnh3ZjBiTEhv?=
 =?utf-8?B?N2o5VkhYa0NEamRkRmxCRHlNL3FCY1dVcmhDNHFtK3pzVmYyV3JVQ0ZBNTF1?=
 =?utf-8?B?RDJCYUlBemlQbVgvTm5LU3l1YlhCaE1FTG90b3JkbXRaazh4RzdFWGl4UVla?=
 =?utf-8?B?Y2ZsQmk2RTFpbXpRa2svNXdBNjV0cGF1R3Z0OG15NlJjVVVPeEhKeUFzQWtC?=
 =?utf-8?B?VlZ3WDRBNFdnNnQ3eW80bFNQUG01dXBYVlVoVERpUVVUNzBycWRiVHJTQTNW?=
 =?utf-8?B?enlNai9WUUtSVFA2Wkg0R3dBVnRSYWx2czBYVzQ5V0Zqenc5QUxlbWdEZUI0?=
 =?utf-8?B?bFpVR1FvN3RFbEFmYmNlS3ZRdm4zZWdIcXFxdTlWU0graVp4Wkt4NmhBM1Uw?=
 =?utf-8?B?Z04xSUMxeWx4Z2VtbllwcnpEZVlSaS9sTnVQbDlsV1p5SlVjM3E1djRJTGlq?=
 =?utf-8?B?dkptUEZqWThTdFZPdFIrZnhlREhDa1F5L0p5d05nUVBaYWRZalppYi9za3lu?=
 =?utf-8?B?YnNEN28xMHVZZFBRY2xJVlFhZUROM1VIWUtTN1lsUkE0OXNHeXZBREVsaWRs?=
 =?utf-8?B?U0Q2K2cvSk9HTXk1UXZWTGNkbU9wTHNIV0UrMWY4VnVodWlGR1J2OUpOSWFp?=
 =?utf-8?B?VndiYnFPUmxZcHEyTmxtQ1F3enFzWkFJcXRzV3hiT1VlcTdZVnNsRDd5NGRm?=
 =?utf-8?B?M1huRjNib1RpMytSNHp3NlNMNm1KNFgxanJFTHc2WkM1bWhEQnl0WkpPaGE1?=
 =?utf-8?B?N0xkWUE1UUVIdVJmaVR1QTcxMElhR0NUZ0loY0dGc3AwUnRhMmpoSmYrNmN6?=
 =?utf-8?B?M3U5alNzQkhMYVI2R2NRYXdmdUVuTzFEeU1hT1pJTzZzVzkzTUNzV3RwRzRE?=
 =?utf-8?Q?WX+fCWAHVK43EgIWDZ8S?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dd53d1f9-0d21-49fd-b97f-08dc486f2cd3
X-MS-Exchange-CrossTenant-AuthSource: JH0PR01MB5780.apcprd01.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2024 23:49:11.4959
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR01MB4502


on 2024/3/8 10:23, Steven Rostedt wrote:
> On Fri, 8 Mar 2024 10:18:18 +0800
> Kassey Li <quic_yingangl@quicinc.com> wrote:
> 
>> The trace event "workqueue_activate_work" only print work struct.
>> However, function is the region of interest in a full sequence of work.
>> Current workqueue_activate_work trace event output:
>>
>>      workqueue_activate_work: work struct ffffff88b4a0f450
>>
>> With this change, workqueue_activate_work will print the function name,
>> align with workqueue_queue_work/execute_start/execute_end event.
>>
>>      workqueue_activate_work: work struct ffffff80413a78b8 function=vmstat_update
>>
>> Signed-off-by: Kassey Li <quic_yingangl@quicinc.com>
>> ---
>> Changelog:
>> v1: https://lore.kernel.org/all/20240308010929.1955339-1-quic_yingangl@quicinc.com/
>> v1->v2:
>> - do not follow checkpatch in TRACE_EVENT() macros
>> - add sample "workqueue_activate_work: work struct ffffff80413a78b8 function=vmstat_update"
> 
>  From a tracing POV,
> 
> Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> 
> -- Steve

hello, Tejun, may you have a chance to review this change ?

> 
>> ---
>>   include/trace/events/workqueue.h | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/trace/events/workqueue.h b/include/trace/events/workqueue.h
>> index 262d52021c23..6ef5b7254070 100644
>> --- a/include/trace/events/workqueue.h
>> +++ b/include/trace/events/workqueue.h
>> @@ -64,13 +64,15 @@ TRACE_EVENT(workqueue_activate_work,
>>   
>>   	TP_STRUCT__entry(
>>   		__field( void *,	work	)
>> +		__field( void *,	function)
>>   	),
>>   
>>   	TP_fast_assign(
>>   		__entry->work		= work;
>> +		__entry->function	= work->func;
>>   	),
>>   
>> -	TP_printk("work struct %p", __entry->work)
>> +	TP_printk("work struct %p function=%ps ", __entry->work, __entry->function)
>>   );
>>   
>>   /**
> 
>