Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp1215993lqt; Tue, 19 Mar 2024 17:15:55 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUS+yj1q3g+HeAOZa54j41868BtvUIUecy3toyp0GL1JB0UvPfKLrjPTvBKM9BjKkAtqCQMnVhAjek3yMfYjy6/QaSaDQmSLAHi4RrJyQ== X-Google-Smtp-Source: AGHT+IEmHjZCIB9up4/gqt9dCJ+HqeW86jH7JdXhsouVfwfzQ/O7K9EeePj2zTjNLsib5Wdnhp2z X-Received: by 2002:a19:8c56:0:b0:515:7686:6068 with SMTP id i22-20020a198c56000000b0051576866068mr2676465lfj.55.1710893754850; Tue, 19 Mar 2024 17:15:54 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710893754; cv=pass; d=google.com; s=arc-20160816; b=OYEXAAmGm8EaCLbFpbvbzD6JEoKUC1GVe6KZr/vzz/Uj8r4h9aPqTf4NJphB+ZbI0/ jFOxONo/LgXRZaYQvCFYz+u8PHIbL8cOz1QkgU2cHwYLxgADVJ+rgzP8wvwxM9Nc+Eip +mxOf5nBn/iKXo6BScaw+qz5/T8VG0S7iggq7lKwkPWd4w/sWsW7yJDVzThcWl8LYBBH 7SBMr1MkywkWYa22FvXnF8rXAWEFhgOWPrgvsn7MPJrCl8jmWh/tWH06Zs+TmahEmfaL wCpz3gtv6XqtzVYQQht0monco8ND5eAmXYMD7WhseDK/gayZ1ISNoLmPdBzrNMuaIeTL HUBw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:from:subject:message-id:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:reply-to:dkim-signature; bh=yXW69hbgzeuHAbIm4Wagg4PsoRhn/DM4eoDcBzj7jGA=; fh=LpMVuAHkjLa44/uVEfSWel5S0IYqX63fBUMqcYAVrGg=; b=rRt+pzTPvKZ9Bzy79AvNiqaA6zMlHtanqfC4GmBv1AxPwuIYxBfxnn/Idzya/flkrB Pilb8rDJsRoehj3nu70bO8TUWbHR82UZ/ELtRUoQC5C0ERMkUcch8Z+dNhfDP59e5LQH YplxAWhl7c9MUCp6GXYMupG6k7nn8kEmmvBgMC8x2Yuz6yWUgURjzj+07QQS+Ivw7NMq hhjpAmLa7GPHPI2vAyVw2Vxxl7Tkfsd48toROo0tzEmiLWSmviPm8KRWrKMyeHb0fsxt 0RrpGxDFULRNRJwED597pGPdHijNYyqyfEKaLVN8DJgRA/Fnelzd0n72sydkyAENnOKi 1TJg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=bfSxA5jO; arc=pass (i=1 spf=pass spfdomain=flex--seanjc.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-108255-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-108255-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id p20-20020a170906229400b00a46daccf6fesi1172570eja.849.2024.03.19.17.15.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 17:15:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-108255-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=bfSxA5jO; arc=pass (i=1 spf=pass spfdomain=flex--seanjc.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-108255-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-108255-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 917D31F23627 for ; Wed, 20 Mar 2024 00:15:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CA7F2A32; Wed, 20 Mar 2024 00:15:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="bfSxA5jO" Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FA33384 for ; Wed, 20 Mar 2024 00:15:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710893747; cv=none; b=uY5ZJL+4WaVVbMJuv9SoULt71UspJFvdW4ZxSvhJmXsNLRhhGAvWnd34c2bBk2e95jc9kB/YPuTLCeYDS/Juv1O2zv7CsGl+C+7l3ab+vBTC725pT+wsv42VDYIbUM4U4d4z0iQ/mbCuJZ3OwwncSGiJ1Ez0ofQUh7/zfSTef88= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710893747; c=relaxed/simple; bh=9M12NXD3dtnNHAjqsgvhN+VjqoN4vkfcG3ZC8N7PFng=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=Kxetj1beTCtKmpLprrbZ3tTgd3ut9VxTQ/QPGT/2uEUzaQyosY391GgKTvn8NYE5iBbE0DmOihkgJNzUkD5DkipKWygJKTcEG/RrG7vQfa9/XOVS7TX0nNxjR0VYsdVrsVLD5SZm911pcFpiRgJiF3ILnTG8KJWQG73smnkvuTk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=bfSxA5jO; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-60cd073522cso123426547b3.1 for ; Tue, 19 Mar 2024 17:15:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1710893744; x=1711498544; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:reply-to:from:to:cc :subject:date:message-id:reply-to; bh=yXW69hbgzeuHAbIm4Wagg4PsoRhn/DM4eoDcBzj7jGA=; b=bfSxA5jO6WLFqYM/QYdG6x+P7A6SrHNYOauytlV1Stj/eb/IOQ9Giu8lw0RVTooWKE d2z8sq0p0nx5EqxP+RMd4JRY85hlVXgz8YXbZg16cwQ3gKtf149TJkIGaqgeHkkfGS+N yPsrkFNaG5x3qx3jMf4CO2GfQPTjzVq9JMBPz4chUrOW/3DiiS3uLmPlO/QGmQW1Oafs lY/vfp12nrzQkoV6utK/7XdXjBwdJHKe6vP6ngdCbjylibiDvtPsvvxCqIIeQY4ItxRT z6OvDs8FlGxZesyuESIVb0lczaNXeXysrcHMw/3/RJpyqIwz1B/3TI/bI7ZpcuIQQw2b vfvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710893744; x=1711498544; h=cc:to:from:subject:message-id:mime-version:date:reply-to :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yXW69hbgzeuHAbIm4Wagg4PsoRhn/DM4eoDcBzj7jGA=; b=R/qWaeKbizZu2pp0oJMZBag8R329MOpXlfB42Da7DzqltJKeCykkoOWsUHVK+k2p88 TTYqjEwYxNXLXb/SOx36kDUWXypIgEaxEMbYXNU9le60iS7WI+qM5dkgAUBYk7KxTNGs XZKv5/ySVVERaulUjJGd+rWWANb5+dYTbFcYYcxNO2GJTWI0Xx60cIgZQ9pjUsPn1cs0 cVR3egV+2NHSGffSmT9v9YgUIcd2fDRV1FrM0XR/AAW4mx7KE3ewLeHjEEVvpfK1ZsmX mBVx+LoYEUi0/JxIlNj0FST0zCf7jnX9kv/3KxouOWC4GjwWuPifgy4gqTKf1ZKCE6FI H5Ww== X-Forwarded-Encrypted: i=1; AJvYcCUo5BlCpXC2kkIfddhFRXTYxJWE8yU46GV5EtivGdAbBU2fyEhsPXwxZeRkjMDFsJci7r87LSU5BeLPiXb3+OmXq657hej6FfbcgcDE X-Gm-Message-State: AOJu0YxBWgN7EBT9ca+iZXUHa4fuvnjIbVQqSeyFtSbKfbjZUfdcLhNn nhGN0cKfJ+uve6F8ZrYsFDVvLmpj7V3Iuq97SCZCtPyLhi7cbOy/o4bJQt33U/lUSoUs2kn1FMT B4Q== X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a0d:d7cf:0:b0:610:f2d3:d33 with SMTP id z198-20020a0dd7cf000000b00610f2d30d33mr275348ywd.6.1710893744675; Tue, 19 Mar 2024 17:15:44 -0700 (PDT) Reply-To: Sean Christopherson Date: Tue, 19 Mar 2024 17:15:39 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.44.0.291.gc1ea87d7ee-goog Message-ID: <20240320001542.3203871-1-seanjc@google.com> Subject: [PATCH 0/3] KVM: Fix for a mostly benign gpc WARN From: Sean Christopherson To: Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Christopherson , syzbot+106a4f72b0474e1d1b33@syzkaller.appspotmail.com, David Woodhouse , Paul Durrant Content-Type: text/plain; charset="UTF-8" Fix a bug found by syzkaller, thanks to a new WARN sanity check, where KVM marks a gfn_to_pfn_cache as active without actually setting gpc->gpa or any other metadata. On top, harden against _directly_ setting gpc->gpa to KVM's magic INVALID_GPA, which would also fail the sanity check. Sean Christopherson (3): KVM: Add helpers to consolidate gfn_to_pfn_cache's page split check KVM: Check validity of offset+length of gfn_to_pfn_cache prior to activation KVM: Explicitly disallow activatating a gfn_to_pfn_cache with INVALID_GPA Sean Christopherson (3): KVM: Add helpers to consolidate gfn_to_pfn_cache's page split check KVM: Check validity of offset+length of gfn_to_pfn_cache prior to activation KVM: Explicitly disallow activatating a gfn_to_pfn_cache with INVALID_GPA virt/kvm/pfncache.c | 48 ++++++++++++++++++++++++++++++++------------- 1 file changed, 34 insertions(+), 14 deletions(-) base-commit: 964d0c614c7f71917305a5afdca9178fe8231434 -- 2.44.0.291.gc1ea87d7ee-goog