Received-SPF: pass (google.com: domain of linux-kernel+bounces-108263-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 19 Mar 2024 17:21:53 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Robert Richter <rrichter@amd.com>, Dan Williams <dan.j.williams@intel.com>
CC: "Rafael J. Wysocki" <rafael@kernel.org>, Alison Schofield
	<alison.schofield@intel.com>, Dave Hansen <dave.hansen@linux.intel.com>,
	<linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-cxl@vger.kernel.org>, Derick Marks <derick.w.marks@intel.com>, "Len
 Brown" <lenb@kernel.org>
Subject: Re: [PATCH] cxl: Fix use of phys_to_target_node() outside of init
 section
Message-ID: <65fa2c219548f_aa2229499@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <20240318210904.2188120-1-rrichter@amd.com>
 <20240318210904.2188120-2-rrichter@amd.com>
 <65f8b191c0422_aa222941b@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <Zfl9Efxe7DwuU_i3@rric.localdomain>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Zfl9Efxe7DwuU_i3@rric.localdomain>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xdmt3OSTZHgBkDtMyxFoVPnnIeDLJaRf6r/j9J4D7kRtAV/dRw+Q3QFq60TL?=
 =?us-ascii?Q?Ma8tdutS15vLTyLNGUJx2USv6+aElmP1NnIqWEVoG06GiKTIYIbsJ70hNfe6?=
 =?us-ascii?Q?H8vD7B9y83WShgKEwA6SdGqgesBCjbQ4J4Xv4zKcjWs+yjNFFudphiWxroin?=
 =?us-ascii?Q?sWkceyQ1zOFd5pqPrctCkEiPJQy0rqtUk8OeN+d05zhKkNzWLXTviBnpatwH?=
 =?us-ascii?Q?UhwT0bmxGHRH8eipjiIf3W6V7w4APmgw1qSB9f4g8A/+eLTcyTI1LliDjNrx?=
 =?us-ascii?Q?fZ3LVZTenH8xQ3wET5NRI86OJy2PUbF195ubGQILT7YDZ4U1xMY1xBjLwnw8?=
 =?us-ascii?Q?j9AAFixujonXvgQFppW9yEVO84bDJWd/gI1gMzCWetHTH9MEFrKFY1+sx9oy?=
 =?us-ascii?Q?oUU/O3Y/5qMBrPwpA2SjJ8mZwRFj2gJbg96kMaLRRchU+fRQPfxnPptEnjyG?=
 =?us-ascii?Q?HoGwULlRN/tWV66rm20rexH6ThhvK6Y/aNJDI8KUB1JkSIvT4zvMvfj2fnop?=
 =?us-ascii?Q?+mTbfsvL3zuZZqxf3DsvGKElLtOtRXHGSaj1s10KyJG0ZONYm//tUzHmJYrr?=
 =?us-ascii?Q?U9AlMcoXacWdCBXv2X4LBGBYQHckKEMrCAa2FLtg5AX6QVkpVq8xpOCAFAKe?=
 =?us-ascii?Q?7hnfEJBdyeoTsTA8SF03MPlvrbc1L1FMlw1SjATcrZb6KOmk08lZabQ/8tn0?=
 =?us-ascii?Q?kRACipQcnXS+YeELzJWjHyJZFxNKHuvG1yOT+7Xk8erTXu505U3IM3KDMosK?=
 =?us-ascii?Q?F47LoW4iUYmmHXvXfpE6oV8aCKuYPeJ+KDL9ZzCXJUFrxZOqgg9U8wgMqSAm?=
 =?us-ascii?Q?4zoN3eSwEkPBq64UZh+RaU1NWqbliTtHfEeC9xrldJEp3oNMupRWEnKcfFPh?=
 =?us-ascii?Q?JxOUl1Tp3zh7EpQeGCH1u/9QT05QkbpmHJQDXepZ0aTOMTzzQIbQvA3Yb56a?=
 =?us-ascii?Q?hRWgPj9GTiY1LH+/9wlTfzpOWbsWZCh79FPeyS6+Iuteaw8QhG3n/JtoWiuF?=
 =?us-ascii?Q?yJWPhj9Kwxq+VNIH2eRJxv24wOW1Y5LTARLttN3sxedrz4UXE4t1cvi7a6aJ?=
 =?us-ascii?Q?cIDM8FJKjLzl5nmVI1pfbmoyyimOkSF1DpgS6KQOUlPIsL9WDJ8mmSU+xxpe?=
 =?us-ascii?Q?7oq1uowg30qCW5Cb/doQT8LZwLVsy8ed0p8CNVPgULqc6nelFDT0fMwCjOsJ?=
 =?us-ascii?Q?6JUc5HQv0GMWDHrAJfsUH4azIewuBpuS/jRpb8XHs5SOOegL/591InXVSKYf?=
 =?us-ascii?Q?dDE1RKmuLxjAp0YUAR0+FxGb28dKBpDydCKENhLyfDVERK5wlVqkC5aCC81I?=
 =?us-ascii?Q?JFAjrEZhuxC+2tma036Z5sNFEgYkdP2+DAxxopfGTVNrYLImINX5ejylxxaO?=
 =?us-ascii?Q?x18xUES3fXahbCbqZRWl/CyveiLtpvRko1UqTJcjyvGc6wIT5WxqtdxL5pHn?=
 =?us-ascii?Q?U5Pzxk7vMVMvqjMv7Io4zWpy/JAYixIPmDFKclTHCyfS7o2iUApaxpBC0CQd?=
 =?us-ascii?Q?zHt/CBDN8J+KymyUfTfljW88WPD5b6NUbn/NoB/oxaaO/8fX0b5NyKxRCAgU?=
 =?us-ascii?Q?wpgWtaYVeRTWbzIGTmpJ0XUNw48kElORDceCvTs79voTQb5FyJTscQwehucI?=
 =?us-ascii?Q?Xg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c0c7257b-642f-4b11-42e6-08dc4873c00b
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2024 00:21:56.1705
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yEsWW/IVhfQfjGkslbz+7fEpdXuhE/jcSJpbso15yvSUzu0NRh3Pil7qOsiiNnhuurBcCoAyuGi4CBEQLGW1Wtp+StjB5r9K2cD+FJPQnWU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7383
X-OriginatorOrg: intel.com

Robert Richter wrote:
> Hi Dan,
> 
> patch below. I have not included it into v2 of the SRAT/CEDT changes
> as it is cxl specific and can be applied separately.
> 
> Thanks,
> 
> -Robert
> 
> 
> On 18.03.24 14:26:41, Dan Williams wrote:
> > It should also be the case that cxl_acpi needs this:
> > 
> > diff --git a/drivers/cxl/Kconfig b/drivers/cxl/Kconfig
> > index 67998dbd1d46..1bf25185c35b 100644
> > --- a/drivers/cxl/Kconfig
> > +++ b/drivers/cxl/Kconfig
> > @@ -6,6 +6,7 @@ menuconfig CXL_BUS
> >         select FW_UPLOAD
> >         select PCI_DOE
> >         select FIRMWARE_TABLE
> > +       select NUMA_KEEP_MEMINFO if NUMA
> >         help
> >           CXL is a bus that is electrically compatible with PCI Express, but
> >           layers three protocols on that signalling (CXL.io, CXL.cache, and
> 
> From be5b495980bae41d879909212db02dac0fba978e Mon Sep 17 00:00:00 2001

Hi Robert,

When you send inline patches like this can you remember to include a
scissors line? That way tools like "b4 am" automatically know where to
trim things. So add a line like the following:

-- >8 --

..see "git mailinfo --help" for details.

Also note that if you reply with an updated patch in a series include
the "vX NN/MM" suffix, like "Subject: [PATCH v3 2/3] ..." so that b4 am
knows to perform a "partial reroll".

> From: Robert Richter <rrichter@amd.com>
> Date: Tue, 19 Mar 2024 09:28:33 +0100
> Subject: [PATCH] cxl: Fix use of phys_to_target_node() outside of init section
> 
> The CXL driver uses both functions phys_to_target_node() and
> memory_add_physaddr_to_nid(). The x86 architecture relies on the
> NUMA_KEEP_MEMINFO kernel option to be set. Enable the option for the
> driver accordingly.
> 
> Suggested-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Robert Richter <rrichter@amd.com>
> ---
>  drivers/cxl/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/cxl/Kconfig b/drivers/cxl/Kconfig
> index 67998dbd1d46..6140b3529a29 100644
> --- a/drivers/cxl/Kconfig
> +++ b/drivers/cxl/Kconfig
> @@ -6,6 +6,7 @@ menuconfig CXL_BUS
>  	select FW_UPLOAD
>  	select PCI_DOE
>  	select FIRMWARE_TABLE
> +	select NUMA_KEEP_MEMINFO if (NUMA && X86)
>  	help
>  	  CXL is a bus that is electrically compatible with PCI Express, but
>  	  layers three protocols on that signalling (CXL.io, CXL.cache, and
> -- 
> 2.39.2
>