Received-SPF: pass (google.com: domain of linux-kernel+bounces-108315-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Zi Yan <ziy@nvidia.com>
To: "\"Matthew Wilcox (Oracle)\"" <willy@infradead.org>
Cc: linux-mm@kvack.org, SeongJae Park <sj@kernel.org>,
 Andrew Morton <akpm@linux-foundation.org>,
 "\"Matthew Wilcox (Oracle)\"" <willy@infradead.org>,
 Yang Shi <shy828301@gmail.com>, Huang Ying <ying.huang@intel.com>,
 "\"Kirill A . Shutemov\"" <kirill.shutemov@linux.intel.com>,
 Ryan Roberts <ryan.roberts@arm.com>,
 Baolin Wang <baolin.wang@linux.alibaba.com>,
 "\"Yin, Fengwei\"" <fengwei.yin@intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mm/migrate: split source folio if it is on deferred
 split list
Date: Tue, 19 Mar 2024 21:30:00 -0400
Message-ID: <7DE48248-2210-487D-82A0-5FE9F2C14871@nvidia.com>
In-Reply-To: <28D1C313-8333-4F87-9B1D-47E77789A853@nvidia.com>
References: <20240320010813.136765-1-sj@kernel.org>
 <DEB67249-569C-4585-BB67-B4EBEE91152E@nvidia.com>
 <28D1C313-8333-4F87-9B1D-47E77789A853@nvidia.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_B4C38DB9-84A7-4953-BB67-9D9F864827AE_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?15cg+BemVk/wAAyVsUG6y04gf9wOm2nSUrpRNLdj6u5GJFienkH1ApNWtkzB?=
 =?us-ascii?Q?H5IJlBJrnJD5QGKJBJvBheQlUs0ujy7bntMIejMqYvoV+X0HbeDyfkfFi7Jg?=
 =?us-ascii?Q?pR/DESPncYJbnCQ5fmL6NBzj1tofR8a3tDvrdNfg76bMUkSxLly23hSNpQJ5?=
 =?us-ascii?Q?v3JYk2JYFohKWh6Xz2exyjlbWLNLa7tYUdSdZKdXMe5ZfDMIxMgnUCk3qMXa?=
 =?us-ascii?Q?Gu9tBceP2fLoO2PJn/chYpXoVBJMeauSgjIA+Ve2Y8fhf/6jbsdeFApo9uck?=
 =?us-ascii?Q?BYH0oo+B42M1QBi8xHbIlC/ZGwMewzGiUmC+Hm8sieqYjhCWA1REkURM2PUp?=
 =?us-ascii?Q?1XtH18owNjgaBYmHN3LKxfsl2CRHGRgn+pWXbytwEmyVVCwbiusX3XExr7Xw?=
 =?us-ascii?Q?0ju5XyqBz+ISyODV1NmIGlRyOIrtSbT0Su/2A/QoEwmRWKkjMrcJwaWOVZ0F?=
 =?us-ascii?Q?9Q5zwRVi3rRkm27t1Fd89w0/rFA71sDoXusw1Ulj6vx4QHmvLIBsygpHofXk?=
 =?us-ascii?Q?HJiRsrtGr6H1lGMzRd3lj1eJNc7AX4HBUK1UbSZT3hbK5r5EtXpdbm82hfyi?=
 =?us-ascii?Q?z6Q9Uzg8K+tZQeLyxhRp9zWy952ZeHfJDSqymiw44vfE6aVy974CxImAhV8P?=
 =?us-ascii?Q?fQCTUD5v9l/17TCCyZds5VpKJ2ew+wHiBghECbmxTHVJDwLdivA9M2aOvGiL?=
 =?us-ascii?Q?s+wixp+4yYmappNQh+ATxlDVNXuIiMnxHh2w5yJmxBadDd6p/u4euc2A0Hj/?=
 =?us-ascii?Q?ZDF5/7FCRn+giRe6AYdw+NIzZHouGZLFLN41kX7XYh+QbRf8hOmkGtbImSIR?=
 =?us-ascii?Q?SeFXlf3ioNL/Ic7DBwkFFHeTa9eCVJ0uk05Gwtc35bLPpx4QLQs1RVCAfVGY?=
 =?us-ascii?Q?c5qEgyoSHdeTu16XoSPcp1ZXYW8YZbK+NwkmbPYUuDJ+OJ7aJlNf4yCLJzfp?=
 =?us-ascii?Q?YVQsFMBKTS3sRQAMze8FHYRgftLnHvwGqt2vo40tbaoAE4o+D5f1rOKx7H7O?=
 =?us-ascii?Q?Rg1QsojShxuGXhnVe+ifW3XUa6zTkimY39nieu9Zxiu8WGuFMcOusS3uNSTG?=
 =?us-ascii?Q?l99Ca+2NvhjBof2QVNLLzDYIGgxr1d/VQuPJMbNwj8GFfOC6OvDrwE3OgZhH?=
 =?us-ascii?Q?vyZLus+EuCeE8gtF4EYjVawQVCXVgYGcQWbVxqn7ai1nF2AjgKxrXUVnOPPG?=
 =?us-ascii?Q?4h/tBmkaXRnMNZmJsMtvK+3Hua+iyWFWfeS6wtG/4DpfIGaz4po+1+bATtBP?=
 =?us-ascii?Q?eU+BDPFuKwvgHL1SoDPXYnETP/LlM05AkmcJfKNu8lbcCyEOiYFwfR/O2VsI?=
 =?us-ascii?Q?Ore2fZxz/sWI2CWu5CpD8IawEDdHbN+oBd5DsoapYL1SN07SnHd2xAvFUvlR?=
 =?us-ascii?Q?y/8bJgZra5mYqovTpHBfsm8D1KM+H57PoK5gdKfcwY8AW0H63eAwUSmY/1pO?=
 =?us-ascii?Q?jTkB1pzKMRiXi5UXB68EUimc14B+rFxdLN+wUg4BOjWMlO0Kj386vo9VMA+a?=
 =?us-ascii?Q?LZ2yZpKvdSt8hoElaQj3d0mJrNQ+uuvKaltso17btAePaRxSol3OgI0zANPN?=
 =?us-ascii?Q?8uHJM5MCWoviQ0+cbaE=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bf000668-c89f-415c-cb2c-08dc487d43a3
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2024 01:30:02.3736
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ERfYLOdgctMwsEUaDDb1o2p5BRfNMDAQP0DimIBY1qYyODv+cSag0PO5cdSTdWI3
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7685

--=_MailMate_B4C38DB9-84A7-4953-BB67-9D9F864827AE_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi Matthew,

>>>> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
>>>> index 9859aa4f7553..c6d4d0cdf4b3 100644
>>>> --- a/mm/huge_memory.c
>>>> +++ b/mm/huge_memory.c
>>>> @@ -766,28 +766,6 @@ pmd_t maybe_pmd_mkwrite(pmd_t pmd, struct vm_ar=
ea_struct *vma)
>>>>  	return pmd;
>>>>  }
>>>>
>>>> -#ifdef CONFIG_MEMCG
>>>> -static inline
>>>> -struct deferred_split *get_deferred_split_queue(struct folio *folio=
)
>>>> -{
>>>> -	struct mem_cgroup *memcg =3D folio_memcg(folio);
>>>> -	struct pglist_data *pgdat =3D NODE_DATA(folio_nid(folio));
>>>> -
>>>> -	if (memcg)
>>>> -		return &memcg->deferred_split_queue;
>>>> -	else
>>>> -		return &pgdat->deferred_split_queue;
>>>> -}
>>>> -#else
>>>> -static inline
>>>> -struct deferred_split *get_deferred_split_queue(struct folio *folio=
)
>>>> -{
>>>> -	struct pglist_data *pgdat =3D NODE_DATA(folio_nid(folio));
>>>> -
>>>> -	return &pgdat->deferred_split_queue;
>>>> -}
>>>> -#endif
>>>> -
>>>>  void folio_prep_large_rmappable(struct folio *folio)
>>>>  {
>>>>  	if (!folio || !folio_test_large(folio))
>>>> diff --git a/mm/internal.h b/mm/internal.h
>>>> index d1c69119b24f..8fa36e84463a 100644
>>>> --- a/mm/internal.h
>>>> +++ b/mm/internal.h
>>>> @@ -1107,6 +1107,29 @@ struct page *follow_trans_huge_pmd(struct vm_=
area_struct *vma,
>>>>  				   unsigned long addr, pmd_t *pmd,
>>>>  				   unsigned int flags);
>>>>
>>>> +#ifdef CONFIG_MEMCG
>>>> +static inline
>>>> +struct deferred_split *get_deferred_split_queue(struct folio *folio=
)
>>>> +{
>>>> +	struct mem_cgroup *memcg =3D folio_memcg(folio);
>>>> +	struct pglist_data *pgdat =3D NODE_DATA(folio_nid(folio));
>>>> +
>>>> +	if (memcg)
>>>> +		return &memcg->deferred_split_queue;
>>>> +	else
>>>> +		return &pgdat->deferred_split_queue;
>>>> +}
>>>> +#else
>>>> +static inline
>>>> +struct deferred_split *get_deferred_split_queue(struct folio *folio=
)
>>>> +{
>>>> +	struct pglist_data *pgdat =3D NODE_DATA(folio_nid(folio));
>>>> +
>>>> +	return &pgdat->deferred_split_queue;
>>>> +}
>>>> +#endif
>>>
>>> I found this breaks the build when CONFIG_TRANSPARENT_HUGEPAGE is not=
 set, with
>>> below error:
>>>
>>>     .../lib/../mm/internal.h: In function 'get_deferred_split_queue':=

>>>     .../lib/../mm/internal.h:1127:22: error: 'struct pglist_data' has=
 no member named 'deferred_split_queue'
>>>      1127 |         return &pgdat->deferred_split_queue;
>>>           |                      ^~
>>>
>>> Since the code was in hugepage.c, maybe the above chunk need to be wr=
apped by
>>> #ifdef CONFIG_TRANSPARENT_HUGEPAGE?  I confirmed below change is fixi=
ng the
>>> build on my setup.
>>
>> Thanks. Will fix it in the next version.
>
> Actually, since get_deferred_split_queue() is used in mm/migrate.c, tha=
t
> part needs to be guarded by CONFIG_TRANSPARENT_HUGEPAGE as well.

_deferred_list is not hidden behind CONFIG_TRANSPARENT_HUGEPAGE but
its users are all behind CONFIG_TRANSPARENT_HUGEPAGE. Should it be moved
as well? Or the other way around, moving _deferred_list users out?

Large folios should work without THP, since they would be like THP withou=
t
PMD mappings, namely mTHP. But mTHP is considered a subset of THP. It see=
ms
confusing. Maybe hiding _deferred_list behind CONFIG_TRANSPARENT_HUGEPAGE=

is better, or just do not change.

--
Best Regards,
Yan, Zi

--=_MailMate_B4C38DB9-84A7-4953-BB67-9D9F864827AE_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmX6PBgPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUwvAP/2JgpkWmP8U9vrCQeYwVNj3CKIoDD/KtxVOl
mAIEwAtehyKJjZyzUjuVNy2A6DUhn10BgLeQOT8HMHWX9jh2GmxOmoa6qEZ9ytlb
tRrSO9JmDPlw/AZ5s3QNuzuaIl+kKgSJwInxDe5TJUQptQ8grN40q8gmSq4cHkRt
9wRtoj7cUOIw4DePDSibt1132BLa/F8/E+ARqPhZoh9z3MFrxfXfPQOlkCSk14d4
1RVkUgMNg+7Iw1jX2KXAWzAau3alZZ3vReiEC4snzMxHQ/mgCBti934tfHKlbD3l
OxZEdVsBgWe4PbTd0hmNNivTYVQu8cit/XjbpbxwhC1g9CdGbQcP4bqCU7YnN2ZW
Gtx7579TcrJxTWlRblMPT3ql+/98mXp/6YnpDM9f1BGWzAMXYjFStghzr+bCD2VN
LcWDzU3z9lHSXOE1buvziIFWtWJpv40eQP6yxvo4hlm9pQrYb2s858RCnjJ2HOQl
rC26wmIjjYxHLirl0cJK1PkRjcDzhPx16V2oOP2UQSO0MBNtxAyeZpMuB93/JEec
Og9KPmyDkB9vFQc9fepjlJOueQ+2/ZA6a5YWAogyJ1I92I+32cnlNRr8TaFe82XL
QScfQ1r2aBxOKk2PmdCh/ZjuPhy3Nnebw9BDenOIj7lJtPa3n379cLqJWc0YhQWV
Lc/YfpEB
=Ki9+
-----END PGP SIGNATURE-----

--=_MailMate_B4C38DB9-84A7-4953-BB67-9D9F864827AE_=--