Received-SPF: pass (google.com: domain of linux-kernel+bounces-108325-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 20 Mar 2024 12:42:07 +1100
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Barry Song <21cnbao@gmail.com>
Cc: corbet@lwn.net, workflows@vger.kernel.org, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org, Barry Song <v-songbaohua@oppo.com>, Andrew
 Morton <akpm@linux-foundation.org>, Chris Zankel <chris@zankel.net>, Huacai
 Chen <chenhuacai@loongson.cn>, Herbert Xu <herbert@gondor.apana.org.au>,
 Guenter Roeck <linux@roeck-us.net>, Max Filippov <jcmvbkbc@gmail.com>
Subject: Re: [PATCH] Documentation: coding-style: ask function-like macros
 to evaluate parameters
Message-ID: <20240320124207.0c127947@canb.auug.org.au>
In-Reply-To: <20240320001656.10075-1-21cnbao@gmail.com>
References: <20240320001656.10075-1-21cnbao@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/1UAWAGbxRtmYwKPckeB.frs";
 protocol="application/pgp-signature"; micalg=pgp-sha256

--Sig_/1UAWAGbxRtmYwKPckeB.frs
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Barry,

On Wed, 20 Mar 2024 13:16:56 +1300 Barry Song <21cnbao@gmail.com> wrote:
>
> diff --git a/Documentation/process/coding-style.rst b/Documentation/proce=
ss/coding-style.rst
> index 9c7cf7347394..8065747fddff 100644
> --- a/Documentation/process/coding-style.rst
> +++ b/Documentation/process/coding-style.rst
> @@ -827,6 +827,13 @@ Macros with multiple statements should be enclosed i=
n a do - while block:
>  				do_this(b, c);		\
>  		} while (0)
> =20
> +Function-like macros should evaluate their parameters, for unused parame=
ters,
> +cast them to void:
> +
> +.. code-block:: c
> +
> +	#define macrofun(a) do { (void) (a); } while (0)
> +

Maybe add some comment about using a static inline function for these
simple versions instead, if at all possible, (it is suggested just
above this section) since that will still type check arguments.

--=20
Cheers,
Stephen Rothwell

--Sig_/1UAWAGbxRtmYwKPckeB.frs
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmX6Pu8ACgkQAVBC80lX
0GyEpwf/aSL+18yEkUBFWP3AATiTQvd1wmQOKwRks0Qwr95WDjRjbN/jicgyZmQ5
ZQffIXV5H8Otk5NnJHeIJ8sBu8vCnWydBwmhRpepb3rDsAB3CdccBVhMqlWznsWs
aZlcEIHYD2CJbLl56wkKd45KDGr0XjL1qVVwi3mg5wScFUtqaUDj9/v2LYVeAR2u
EtR3uTxYjfJt/dGDsIyuAvQ+8lsCFiB0z8HeUf0slh1LWfm4ZVac+wBMOAbsGpO2
kLrRGJ1fHgZR8amEdQPz1ZOHitAf6KBldPltgcF8KScD95Iz+b6tVjBkJ/bvyPbq
BpWwNvvF4gMwMciooe1yViONfXNgoA==
=U3iC
-----END PGP SIGNATURE-----

--Sig_/1UAWAGbxRtmYwKPckeB.frs--