Received-SPF: pass (google.com: domain of linux-kernel+bounces-108354-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <mvmy1aegrhm.fsf@suse.de>
In-Reply-To: <mvmy1aegrhm.fsf@suse.de>
From: yunhui cui <cuiyunhui@bytedance.com>
Date: Wed, 20 Mar 2024 10:20:12 +0800
Message-ID: <CAEEQ3wkg5kP7q6qnjV5Xmi_-jJnGBSLb2PkN1M88h5rjsif4oQ@mail.gmail.com>
Subject: Re: [External] [PATCH v2] riscv: use KERN_INFO in do_trap
To: Andreas Schwab <schwab@suse.de>
Cc: linux-riscv@lists.infradead.org, Conor Dooley <conor@kernel.org>, 
	Palmer Dabbelt <palmer@dabbelt.com>, =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn@rivosinc.com>, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Andreas,

On Tue, Mar 19, 2024 at 11:40=E2=80=AFPM Andreas Schwab <schwab@suse.de> wr=
ote:
>
> Print the instruction dump with info instead of emergency level.  The
> unhandled signal message is only for informational purpose.
>
> Fixes: b8a03a634129 ("riscv: add userland instruction dump to RISC-V spla=
ts")
> Signed-off-by: Andreas Schwab <schwab@suse.de>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> v2: clarify commit message
> ---
>  arch/riscv/kernel/traps.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c
> index a1b9be3c4332..142f5f5168fb 100644
> --- a/arch/riscv/kernel/traps.c
> +++ b/arch/riscv/kernel/traps.c
> @@ -121,7 +121,7 @@ void do_trap(struct pt_regs *regs, int signo, int cod=
e, unsigned long addr)
>                 print_vma_addr(KERN_CONT " in ", instruction_pointer(regs=
));
>                 pr_cont("\n");
>                 __show_regs(regs);
> -               dump_instr(KERN_EMERG, regs);
> +               dump_instr(KERN_INFO, regs);
>         }
>
>         force_sig_fault(signo, code, (void __user *)addr);
> --
> 2.44.0
>
>
> --
> Andreas Schwab, SUSE Labs, schwab@suse.de
> GPG Key fingerprint =3D 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D=
7
> "And now for something completely different."

Reviewed-by: Yunhui Cui <cuiyunhui@bytedance.com>


Thanks,
Yunhui