Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp1283371lqt; Tue, 19 Mar 2024 20:46:46 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXd8iVhRhIQS2KwIrw6XZNu4PqiS6txgTVMWHX4K8A8CftE7Erf2dr/nb1TclPO6nwJxwDZBs0uvl7TXtk/WhuaNOK40AbEVHrlARdjdg== X-Google-Smtp-Source: AGHT+IGt4fn/IKo1Ie+41eP+CCzLSkOsuW01s35xTdCot4QHqp+fhQfyk7STAfPYJ+GC1g878Q4L X-Received: by 2002:a17:906:a18c:b0:a46:a17b:c44e with SMTP id s12-20020a170906a18c00b00a46a17bc44emr7021125ejy.30.1710906406803; Tue, 19 Mar 2024 20:46:46 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710906406; cv=pass; d=google.com; s=arc-20160816; b=V+c+76Rqqh2VWRTvoyRIXNDfCjeCdGF05mfYQcxRt34dguNHOfvoXoiMtd/Mk2Mxm/ d4OeBl8by46DsyZj4Q6MUjCnqLbn70OkvvABq9OGF5HFp+sPcWaRPRzN1IbuzOQD4WiS h7H2cFAJcpHMeT6HyII0m/9acYCe/MGvTTJONdAjMJTYXoC5GtwnFX5L3vOZ6RSuIzZ9 DlRD6p70x1yIDGCS7/rTkC4/Tom73EirPGmNyuzOEhnsyrPkqL3Mtt3rbfXfsq6UjMMl KYFwaDjzSarQNplAgiCO/8883WKtjfTKKldZlaE2xR5RO4amOmthB2IJVIYldRrn/Scj +AwA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:user-agent:date:message-id:from :cc:references:to:subject; bh=vNlur6+7YtuDRTkFr4YKSfhCUhtmEAPdMdpe9kguans=; fh=MBNLVqyxVuOPbZnAYftoDPzflcINF4LFb68GIVAxNR4=; b=oEt0Ktor6+BvJymvYUtXR9HfabvMXJBDEJOA/SXxaLdJykwQYWk10g+91mGvqtkB1I Vj9SnAIg3hYgPT30E1g65WBVswFYpxJN0PQoZv7/3hy4g+XaPLzpnMYNbl49ZQzy7iCL h+tPRMtb7tntn/APWBNEJNY1rSkkrxvFNpT/3qjnv5lpOnTeK5DQjhUTQ3tLLxHibY62 w64KqpZbxLYNz96RETlcOaZyirjbjV7KJ0jsRPmUmB2aYKKgU/bUgKou9zu9cb87dLli m+GAHHthtzT24F36OfTTqQW0QQxzlhmGNW2IhkcUXZSBOpvT+8HOk+Yk/NsfwhUgosVO 62GA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=huawei.com dmarc=pass fromdomain=huawei.com); spf=pass (google.com: domain of linux-kernel+bounces-108413-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-108413-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id ne30-20020a1709077b9e00b00a46e13a8f73si1164926ejc.593.2024.03.19.20.46.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 20:46:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-108413-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=huawei.com dmarc=pass fromdomain=huawei.com); spf=pass (google.com: domain of linux-kernel+bounces-108413-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-108413-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 874541F22EFC for ; Wed, 20 Mar 2024 03:46:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 18C9811C92; Wed, 20 Mar 2024 03:46:39 +0000 (UTC) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DD0E1170B; Wed, 20 Mar 2024 03:46:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.191 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710906398; cv=none; b=EYg5TRgNBsnZ690qZBHfAoBuTDepkiCLIkFVALhThFDHMOgUK/FR0VEWZdDwwjyb+j8ar43/2n+EToZ2AgFhubwVVdaMQ3TB7YAmDaiYm9uqM3mwSh48Xlamn6DT9Kzrhwan+e5kwKIMAEIXjIGhx9rV5x3s65AT6ul2qjoOQZY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710906398; c=relaxed/simple; bh=l+mqYCBgZTwxi4ErekRH/lhS4Fi+295tQE8tgGy3YAM=; h=Subject:To:References:CC:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=jZBGwwYDsGx1oFRAB9uQhq8Vm0h0A3SRTdZvFLqCO1us0cYkOyDWtpeXuSS8szE7tXXGEwJMfCvTHvDDChnxnnoaPKG+8RnFYD04KAoKihFYU2FSi085ArIIRa4QnfTBu0dlQNBtHXy7TbRmFZNiFdIjZ4Sr/yO2WjjvS8+zqlk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.191 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4TzvdY0Kfqz1HBvb; Wed, 20 Mar 2024 11:46:09 +0800 (CST) Received: from canpemm500010.china.huawei.com (unknown [7.192.105.118]) by mail.maildlp.com (Postfix) with ESMTPS id 0341F1A0172; Wed, 20 Mar 2024 11:46:32 +0800 (CST) Received: from [10.67.111.82] (10.67.111.82) by canpemm500010.china.huawei.com (7.192.105.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 20 Mar 2024 11:46:31 +0800 Subject: Re: [PATCH] ARM: unwind: improve unwinders for noreturn case To: Matthew Wilcox References: <1709516385-7778-1-git-send-email-xiaojiangfeng@huawei.com> <1710901169-22763-1-git-send-email-xiaojiangfeng@huawei.com> <202403191945.661DBCE8@keescook> CC: Kees Cook , , , , , , , , , , , , , , , , , , , , , , , From: Jiangfeng Xiao Message-ID: <98468785-ed75-f812-7263-1adf677f00d2@huawei.com> Date: Wed, 20 Mar 2024 11:46:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm500010.china.huawei.com (7.192.105.118) On 2024/3/20 11:34, Matthew Wilcox wrote: > On Wed, Mar 20, 2024 at 11:30:13AM +0800, Jiangfeng Xiao wrote: >> The checkpatch.pl script reports the "WARNING: printk() should >> include KERN_ facility level" warning. >> >> That's why I changed printk to pr_warn. >> I should change printk to printk(KERN_DEFAULT). > > No, you should ignore checkpatch. For bonus points, figure out why you > should ignore it specifically in this case. > . > Thank you. I think I understand. The checkpatch.pl file is a false report because the 'loglvl' already exists. I'd better keep printk(" %s...", loglvl, ...) still.