Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp1293348lqt; Tue, 19 Mar 2024 21:22:45 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVZG/mPsyl9jWVNc0ybsUCg3yBFvLwNzUG0qt8Hhkq0EIHoQhY9hpPhrEcDELUcJVn4RqqUIWItRZL3XLXYXY2692f5x7F6JsVeHWZtMQ== X-Google-Smtp-Source: AGHT+IGcG6BahiLNUekB9K+WbrERTTeOyfRkDQha7/oBrg0vUPCkdE0pyn9yp7BYi/Ttmo/8jB/m X-Received: by 2002:a17:902:cec8:b0:1dc:8f8e:63e2 with SMTP id d8-20020a170902cec800b001dc8f8e63e2mr5323789plg.46.1710908565312; Tue, 19 Mar 2024 21:22:45 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710908565; cv=pass; d=google.com; s=arc-20160816; b=wULI4ZG1gATlRUTIJkCY9ZxBpLRuPB8HMZgsIqtXjoBr3ucNo7oGbVUCCEPC+9Cj27 Kcer0zPt4ezOwc2kWv+xVCGuP3S37S3G+2aCyuCD71aBr5SaSkOeXOmu3F8jm6uoF7mr djno/iad1/88VvNAE2hksO0lY/V2RHDgYtTsuuPAVrYebLW5CB8mn2qiN/fmO1Eoh8jI fyyHbycxiFtgNOLTU4iEz2vWFqHEVwaQitQSRyYgvG/dbULpbqq9Ub8h5sv6J1lsory8 zR77/wNZcwr6YT1eZ3EKPb09xc0ZrSjptnqc7fBp1dAjJYOuoqRiWUSG9PKX02QWeO1s bA9Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=cwil56zbTxFwL2LPEeCyDWZZ3L2Yga7AQv0iusdXD8o=; fh=Laei7Yo2M97dghKjxRid60OSyoQ8hL2UiV6xw5MWzsc=; b=TcjLmpJrzSkpD+ErLzkjRpTDdSWkUa2iexgeCs6Iq/bMon6J1/tLzznCyPMZudO1eG 4QPrCEG+dVErh3E9gn4RBxLuXKM8m7ztGNaooFp3EpPnSbW9zR6qHXwvm37WYaqo3JnO 1iIIUpt7TAZhRdZVf/qLJnbHF7Ak3ICzjJA/H9WMWJiXCOtT6+26OYAWUw7duvawYVdW 0SPmTR9HBHHqn4Tz5fX5NaXxAjGBDuH8XZ1Glm6I2MTX1twcVdvLASNSYUca5Aac4st8 ezHT8+OwCRyEbGKtVO3Az1Lr3XPyauHrNDpP6YGGDf29swJ3huz9KerVoHjDgOBuYHul /Cdw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="DVhx/D8Q"; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-108333-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-108333-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id i2-20020a170902c94200b001e01d62454csi6027595pla.56.2024.03.19.21.22.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 21:22:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-108333-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="DVhx/D8Q"; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-108333-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-108333-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id EDD20284C7E for ; Wed, 20 Mar 2024 01:57:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6E118847B; Wed, 20 Mar 2024 01:57:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="DVhx/D8Q" Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26F8B7464; Wed, 20 Mar 2024 01:57:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710899829; cv=none; b=qF5bdCZ226s/dvuMDtqWtSIqF/iCSMnS0EtXcicyt4yGICJfnvN9eSqkGW5MdaV5yRarenGq8yoDjXzNACOaYdJKP2UghpMCxRBZC/W0QxKJGXqmXw8hw4eRsR0M4I+N0u2BkppT+2zvHNVl8PVVuEr9IVcdhdMBZ0ABSqUN+iY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710899829; c=relaxed/simple; bh=XquRaUIAS0JjjCqmDwqYRxEjThd2HstdNp2LDSDJgHc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mMfuVfaTxc3z8e//KPBn9PkHbDx012I8a3qNz6w1e7pXNk43tRGMpzMK+gBnYn1df0U3DF/9mvt9Gb7kRIeRqpzHtzd1PjECVLQT5VBmJO2gAcc/gYKTw67R8nNlSY81T7xE3eMSi0zjRp6gI/4lgnuRvPdkuXDBv0+6omhYDUE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=DVhx/D8Q; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cwil56zbTxFwL2LPEeCyDWZZ3L2Yga7AQv0iusdXD8o=; b=DVhx/D8QKsz5jAE/7m6SGqpkvd oh5RLmT6mKAaLxqxbr1q4q7lgd6bgs0KnVHUQL0cmpeF0hD4/XgGnaupim4aAj0uHKmCzvrjG0b8b Xs4P5OXSxePl0W0hq8hVy1GwbJvIrA4WdHnM7aVCCJ0hgCdkjGzfrEmB2AQUpfxYUDXOADnpOTu60 shuyfgsMjWfSLAYxiWUay5uwfpMEhWGFbJIW7rEAh96x+QOZmNA2Ull+h/Mi+fmtlF3j2Ce83V7xC WQ9jZtQmNnYJ6o6fGBRJRXd/o/miOh+D05FlqKBCsoR6kYYeQ8POjnZCxr4F6cG+ioijZG2Et5vYD 4lJX2o+Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmlCU-0000000EygN-3n7R; Wed, 20 Mar 2024 01:57:06 +0000 Date: Tue, 19 Mar 2024 18:57:06 -0700 From: Christoph Hellwig To: Zhang Yi Cc: "Darrick J. Wong" , hch@infradead.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, brauner@kernel.org, david@fromorbit.com, tytso@mit.edu, jack@suse.cz, yi.zhang@huawei.com, chengzhihao1@huawei.com, yukuai3@huawei.com Subject: Re: [PATCH v3 3/9] xfs: make xfs_bmapi_convert_delalloc() to allocate the target offset Message-ID: References: <20240319011102.2929635-1-yi.zhang@huaweicloud.com> <20240319011102.2929635-4-yi.zhang@huaweicloud.com> <20240319204552.GG1927156@frogsfrogsfrogs> <054ac072-4ccf-b83c-cc9c-cbb5d6f5dbdb@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <054ac072-4ccf-b83c-cc9c-cbb5d6f5dbdb@huaweicloud.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Wed, Mar 20, 2024 at 09:51:26AM +0800, Zhang Yi wrote: > Thanks for your suggestions, all subsequent improvements in this series are > also looks fine by me, I will revise them in my next iteration. Christoph, > I will keep your review tag, please let me know if you have different > opinion. Yes, please keep them. All changes so far remain pretty trivial.