Received-SPF: pass (google.com: domain of linux-kernel+bounces-108245-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 20 Mar 2024 07:55:55 +0800
From: Xu Yilun <yilun.xu@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Marco Pagani <marpagan@redhat.com>, Moritz Fischer <mdf@kernel.org>,
	Wu Hao <hao.wu@intel.com>, Xu Yilun <yilun.xu@intel.com>,
	Tom Rix <trix@redhat.com>, Jonathan Corbet <corbet@lwn.net>,
	Alan Tull <atull@opensource.altera.com>,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-fpga@vger.kernel.org
Subject: Re: [PATCH v6] fpga: manager: add owner module and take its refcount
Message-ID: <ZfomC4W8f6id5gRa@yilunxu-OptiPlex-7050>
References: <20240305192926.84886-1-marpagan@redhat.com>
 <ZfkOvXslEjgU+fc1@yilunxu-OptiPlex-7050>
 <2024031906-radish-handbrake-93b4@gregkh>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2024031906-radish-handbrake-93b4@gregkh>

On Tue, Mar 19, 2024 at 09:01:32AM +0100, Greg Kroah-Hartman wrote:
> On Tue, Mar 19, 2024 at 12:04:13PM +0800, Xu Yilun wrote:
> > On Tue, Mar 05, 2024 at 08:29:26PM +0100, Marco Pagani wrote:
> > > The current implementation of the fpga manager assumes that the low-level
> > > module registers a driver for the parent device and uses its owner pointer
> > > to take the module's refcount. This approach is problematic since it can
> > > lead to a null pointer dereference while attempting to get the manager if
> > > the parent device does not have a driver.
> > > 
> > > To address this problem, add a module owner pointer to the fpga_manager
> > > struct and use it to take the module's refcount. Modify the functions for
> > > registering the manager to take an additional owner module parameter and
> > > rename them to avoid conflicts. Use the old function names for helper
> > > macros that automatically set the module that registers the manager as the
> > > owner. This ensures compatibility with existing low-level control modules
> > > and reduces the chances of registering a manager without setting the owner.
> > > 
> > > Also, update the documentation to keep it consistent with the new interface
> > > for registering an fpga manager.
> > > 
> > > Other changes: opportunistically move put_device() from __fpga_mgr_get() to
> > > fpga_mgr_get() and of_fpga_mgr_get() to improve code clarity since the
> > > manager device is taken in these functions.
> > > 
> > > Fixes: 654ba4cc0f3e ("fpga manager: ensure lifetime with of_fpga_mgr_get")
> > > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Suggested-by: Xu Yilun <yilun.xu@intel.com>
> > > Signed-off-by: Marco Pagani <marpagan@redhat.com>
> > 
> > Acked-by: Xu Yilun <yilun.xu@intel.com>
> > 
> > Will apply to v6.9-rc1
> 
> It is way too late for -rc1, sorry, this needs to wait for the next
> release.

You're right. I'm sorry, I mean I will apply when v6.9-rc1 comes.

> 
> thanks,
> 
> greg k-h