Received-SPF: pass (google.com: domain of linux-kernel+bounces-108433-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <832ec5e1-db5c-4123-8768-39ba9e6cca82@intel.com>
Date: Tue, 19 Mar 2024 21:50:51 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 01/13] selftests/resctrl: Convert get_mem_bw_imc() fd
 close to for loop
Content-Language: en-US
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	<linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>, Babu Moger
	<babu.moger@amd.com>, =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?=
	<maciej.wieczor-retman@intel.com>
CC: Fenghua Yu <fenghua.yu@intel.com>, <linux-kernel@vger.kernel.org>
References: <20240311135230.7007-1-ilpo.jarvinen@linux.intel.com>
 <20240311135230.7007-2-ilpo.jarvinen@linux.intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240311135230.7007-2-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bE9RVXY5MnFZaHhvai9xQWZWYWRUclVvQ2FzUjlnS1J2bzF0YnhzSDZydnlq?=
 =?utf-8?B?T0I0V29FbzhFa08zT0ZDU0ZZMkU3Qm56SGVVTjFId3RlaUJNUGdKNTUxVFY5?=
 =?utf-8?B?UlVJVlJNcEI2WlZJVFNwTktkNVphb3ZlQ2RWZTBVTWtiQjVvQ29WTXRXOWpW?=
 =?utf-8?B?bG1iMUtGQTNOQWN0emZ5M2pDM0RTTjJNcEc4YWdPZTZmUjdiakdVcjNETnBz?=
 =?utf-8?B?cVgwUkdKV3FVYVVGbTZwcXM1aFU0c0FjcDRiUUZCc1JVNWxuYmtSTTU4UUI5?=
 =?utf-8?B?ODhieGZhczNvTnBTZnNNbXZzSVlQOVZ6M3hvcmN0eDNEb3VxY0xDdkJ4eTFT?=
 =?utf-8?B?dmJqV014aTRDVFY5NkplR3NWV2NGQWh6dGY3NURTdGsrdS9pZ1dLeW9UTWEv?=
 =?utf-8?B?Ny9ZWGhOdlFLQ0lkZkh3QS9Lb1hnbUF2S2c3RS9zdnQwa0JPQjdMaDZuZWxO?=
 =?utf-8?B?WjJocTlZclVtdGI1Sm54cXF1WVdUamh5Rkx0R09ER0p2K3djdVVUNVNJbThQ?=
 =?utf-8?B?b0ZXRFZPMWtSV3o1OGtHOEp4S1VDcDd2aGsrR014eFFUZHJtZHZnTTlwaVU1?=
 =?utf-8?B?VENjK3pCS0JycFJzR0JQMHNuYnB1YkxzNWNZZm4rdUExZkJ2S04wNHZoMWR1?=
 =?utf-8?B?SGpzQlVZUW5PcW0xa2xETHhJS1Y4YW1DWEVEWU8vbXJKWHNJcS81VWFKbUwz?=
 =?utf-8?B?NzdjZUtZQlFrUUJrOVluRmRmOHpDZnM5N1hPSitXRDNMTER1VVh1Y0p6aklP?=
 =?utf-8?B?T0RHWnh1WFZuMkJSenZrbzNHejlZR3dMcXgwQW9tcTNWaVlPS29QVXR3S1ZS?=
 =?utf-8?B?VnZEQ1YzelB3Y3FnT1pJUGRiK2s4bU1kRmZFT1FjQlRHdVNVWTNUd0pTT2NY?=
 =?utf-8?B?ZDRuOXkvYmRWdE0wZ2Z6TlJmN2lIeTRCWE9EdUc4SnBlRmZqZlJJT21SRXRp?=
 =?utf-8?B?cmJTWW5zUFpFYnpHRWFTcWx0MitTRlN1ZktlYXhCajRydjZ5bmNSdDFnK3Iw?=
 =?utf-8?B?MXdSL2hYbmpxTmoxKzlmYUNXN0g1VGZaNW1WRXhTTFJsb0hWcENtdmFwZ0Y4?=
 =?utf-8?B?RG4rY2VUVWJ3MzAxenVqWlNZeU9Da3Y1N3RSOXRMMVVmU1B6Z3dUcWdLeGpn?=
 =?utf-8?B?QjdaNFphTmE0NzErZXhyT0IxZnFtSTErOE16OG5tSXoySFlJR0JWMnNKaGd6?=
 =?utf-8?B?L2dhNTJhSVEvbndqN0JIVFFFcXVwSDhNdWZuQWIzR1JIRUFMTnk3YUFtWC91?=
 =?utf-8?B?bnphb0dReUpLaHR2RFJMRkNpem1MSFNIMGcrZlBsRDRtK1RteHJ5WW44QWpB?=
 =?utf-8?B?bFllaXlHWGROcWtzS1pqZWVvc09MczUweExPa0VhaE5oNlplS0dHNHNMdHFQ?=
 =?utf-8?B?NU15cERISUlqNUJZeFo1MlVyUkRMTW9ZekNNbjBPZDlPRWRxRlJxSnNoYUFZ?=
 =?utf-8?B?am93cXZDZ2RoNENxUUZCSHdPQ2hMTldYZjBDN1lKZEM2ZHBrQ1E4NkJ0enRz?=
 =?utf-8?B?QXovYUhjQ3g4K0s1VWl6Vk43RVRiTHFvdU9UWjVDSUlxK3ltdE9LNDRBcG1m?=
 =?utf-8?B?RG45SUU3eEZSUWpZdmprU3Q2SDhCNEJoYUFGdVdqTVkxbno3eG9CYjRFUmk5?=
 =?utf-8?B?U2ROTkZzTFMwaktiblR4ckUwZURPZXFSc2tkQ1dZemhIME5ydnl2QTNqQVVW?=
 =?utf-8?B?OCtsTzRYYTI3ZmFjTWtMZExpSHVwTCtILzZQRE8wUkg2alp0UXpzYzRXVFNi?=
 =?utf-8?B?UXpIOUdjWGxOeE1XeGFWOHhzSXJyRUZONlZvZEUvUVFRbVdHcjhPbXRWVFRK?=
 =?utf-8?B?UkxwT0ZkU1A3K1BEZW9EWC9WUjFCcGduRnhKeTZlSzQ4K2puQ0M1Y3BvTDR5?=
 =?utf-8?B?anplN2o2NC9qa2Q3dmVJd3ovRFFhVHBjMVAwYjFWV2wyRUhuZ0hJb2lVUE5F?=
 =?utf-8?B?SkdYNFptWXhYY09Cc0l6dUFuL3VYWHZzRDcwcmlrdmZDQm1OZXViMzM5QmZy?=
 =?utf-8?B?ck00OFJ3Y0l3VlJwem5hMElLdXhlUXRzR1lJd2NCSkRvblhEbUVNZnZrTGIx?=
 =?utf-8?B?SzJWaU95THJYTUYrTXhEZFh1YkRuMWRVQmJXQjcwQS9GbFdMcWptU1hLVmJF?=
 =?utf-8?B?a0o3YUN1MU1kZHVKUFNCemNZazF3MWNiRVBPZGVHcXJ2UzRrbWplUkxSOWRu?=
 =?utf-8?B?V3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a5e9d42a-0e42-4613-a5a9-08dc489952f8
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2024 04:50:53.9980
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: idOOA4Vq+vBrHfYrJ6VYi8i3H+s2AiT3Hzl/NgJWnULAiKVCee14rsZf0LjCrT2RJPCDMnYdDGuvnH1UeZxIHCc0ZkMN2msqzoIZVolKV3M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7863
X-OriginatorOrg: intel.com

Hi Ilpo,

On 3/11/2024 6:52 AM, Ilpo Järvinen wrote:
> The open() side handles fds in a for loop but close() is based on two
> fixed indexes READ and WRITE.
> 
> Match the close() side with the open() side by using for loop for
> consistency.

I find the close() side to be more appropriate. I say this for two
reasons: (a) looking at the close() calls as they are now it is
obvious what the close() applies to and transitioning to a loop
adds a layer of unnecessary indirection, (b) I do not think a loop
is appropriate for the READ/WRITE define that just happen to be 0
and 1 ... there should not be an assumption about their underlying
value.

Reinette