Received-SPF: pass (google.com: domain of linux-kernel+bounces-108298-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Feedback-ID: i5ec1447f:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-332-gdeb4194079-fm-20240319.002-gdeb41940
Precedence: bulk
MIME-Version: 1.0
Message-Id: <22dfda61-6feb-49b1-a2dc-3f4eb0f7ec60@app.fastmail.com>
In-Reply-To: <42f1c0d5-e7ac-4efb-fef7-75d07ad2ffaa@linux.intel.com>
References: <20240310055750.13160-1-luke@ljones.dev>
 <20240310055750.13160-2-luke@ljones.dev>
 <42f1c0d5-e7ac-4efb-fef7-75d07ad2ffaa@linux.intel.com>
Date: Wed, 20 Mar 2024 14:08:10 +1300
From: "Luke Jones" <luke@ljones.dev>
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: platform-driver-x86@vger.kernel.org,
 "Hans de Goede" <hdegoede@redhat.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/1] platform/x86: asus-wmi: add support variant of TUF RGB
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Wed, 20 Mar 2024, at 1:31 AM, Ilpo J=C3=A4rvinen wrote:
> On Sun, 10 Mar 2024, Luke D. Jones wrote:
>=20
> > Adds support for a second TUF RGB wmi call that some versions of the=
 TUF
> > laptop come with. Also adjusts existing support to select whichever =
is
> > available.
> >=20
> > Signed-off-by: Luke D. Jones <luke@ljones.dev>
> > ---
> >  drivers/platform/x86/asus-wmi.c            | 12 +++++++++++-
> >  include/linux/platform_data/x86/asus-wmi.h |  1 +
> >  2 files changed, 12 insertions(+), 1 deletion(-)
> >=20
> > diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/=
asus-wmi.c
> > index 2cf695289655..ca8c73c15fcc 100644
> > --- a/drivers/platform/x86/asus-wmi.c
> > +++ b/drivers/platform/x86/asus-wmi.c
> > @@ -280,6 +280,7 @@ struct asus_wmi {
> >  bool nv_temp_tgt_available;
> > =20
> >  bool kbd_rgb_mode_available;
> > + u32 kbd_rgb_dev;
> >  bool kbd_rgb_state_available;
> > =20
> >  bool throttle_thermal_policy_available;
> > @@ -870,6 +871,7 @@ static ssize_t kbd_rgb_mode_store(struct device =
*dev,
> >  struct device_attribute *attr,
> >  const char *buf, size_t count)
> >  {
> > + struct asus_wmi *asus =3D dev_get_drvdata(dev);
> >  u32 cmd, mode, r, g, b, speed;
> >  int err;
> > =20
> > @@ -906,7 +908,7 @@ static ssize_t kbd_rgb_mode_store(struct device =
*dev,
> >  speed =3D 0xeb;
> >  }
> > =20
> > - err =3D asus_wmi_evaluate_method3(ASUS_WMI_METHODID_DEVS, ASUS_WMI=
_DEVID_TUF_RGB_MODE,
> > + err =3D asus_wmi_evaluate_method3(ASUS_WMI_METHODID_DEVS, asus->kb=
d_rgb_dev,
> >  cmd | (mode << 8) | (r << 16) | (g << 24), b | (speed << 8), NULL);
> >  if (err)
> >  return err;
> > @@ -4537,6 +4539,14 @@ static int asus_wmi_add(struct platform_devic=
e *pdev)
> >  asus->gpu_mux_dev =3D ASUS_WMI_DEVID_GPU_MUX_VIVO;
> >  }
> > =20
> > + if (asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_TUF_RGB_MODE)) {
> > + asus->kbd_rgb_mode_available =3D true;
> > + asus->kbd_rgb_dev =3D ASUS_WMI_DEVID_TUF_RGB_MODE;
> > + } else if (asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_TUF_RGB_MO=
DE2)) {
> > + asus->kbd_rgb_mode_available =3D true;
> > + asus->kbd_rgb_dev =3D ASUS_WMI_DEVID_TUF_RGB_MODE2;
> > + }
>=20
> Hi,
>=20
> Why are you leaving this line there (unlike in the GPU MUX patch where=20
> you replaced it with the similar if()s as above):
>=20
> asus->kbd_rgb_mode_available =3D asus_wmi_dev_is_present(asus, ASUS_WM=
I_DEVID_TUF_RGB_MODE);

Missed it I guess. Thanks for catching, I'll submit next version.

>=20
> ?
>=20
> --=20
> i.
>=20
>=20