Received-SPF: pass (google.com: domain of linux-kernel+bounces-108469-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 20 Mar 2024 06:00:03 +0000
In-Reply-To: <20240126075547.1521556-1-mengfanhui@kylinos.cn>
Precedence: bulk
Mime-Version: 1.0
References: <20240126075547.1521556-1-mengfanhui@kylinos.cn>
Message-ID: <Zfp7Y9x2iOE_prpp@google.com>
Subject: Re: [PATCH] config/mips: support zswap function
From: Yosry Ahmed <yosryahmed@google.com>
To: mengfanhui <mengfanhui@kylinos.cn>
Cc: tsbogend@alpha.franken.de, geert+renesas@glider.be, 
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, 
	linux-mm@vger.kernel.org, hannes@cmpxchg.org, nphamcs@gmail.com, 
	chengming.zhou@linux.dev
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 26, 2024 at 03:55:47PM +0800, mengfanhui wrote:
> Solution /sys/module/zswap/parameters/enabled attribute node
> does not exist issue=EF=BC=8Chandle zpool zbud initialization failed,
> open CONFIG_ZSWAP CONFIG_ZPOOL CONFIG_ZBUD configuration,manual
> zswap function by /sys/module/zswap/parameters/enabled file
>=20
> Signed-off-by: mengfanhui <mengfanhui@kylinos.cn>
> ---
>  arch/mips/configs/generic_defconfig | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/arch/mips/configs/generic_defconfig b/arch/mips/configs/gene=
ric_defconfig
> index 071e2205c7ed..14884df392f4 100644
> --- a/arch/mips/configs/generic_defconfig
> +++ b/arch/mips/configs/generic_defconfig
> @@ -13,6 +13,9 @@ CONFIG_CGROUP_DEVICE=3Dy
>  CONFIG_CGROUP_CPUACCT=3Dy
>  CONFIG_NAMESPACES=3Dy
>  CONFIG_USER_NS=3Dy
> +CONFIG_ZSWAP=3Dy
> +CONFIG_ZPOOL=3Dy
> +CONFIG_ZBUD=3Dy

Any reason for choosing zbud over zsmalloc, the default zswap allocator?

>  CONFIG_SCHED_AUTOGROUP=3Dy
>  CONFIG_BLK_DEV_INITRD=3Dy
>  CONFIG_BPF_SYSCALL=3Dy
> --=20
> 2.25.1
>=20