Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp1324218lqt; Tue, 19 Mar 2024 23:14:46 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUoDFGpbCayTRTh85tvFiUfyWcuRodMY+cJe6jtOpE0t9QO52kb8QKzCc9J9hr/G9liRPyQnynkUM/KHtsRzWj3b484G0VOOajRMCEs3g== X-Google-Smtp-Source: AGHT+IH9HxQO7Qg7h7MZIl2D4w8Su/z9gtI/O1qtEvCaobAB9ABleUScurAyGdV12MN+qt6yo5ws X-Received: by 2002:a05:620a:4509:b0:78a:8cb:f298 with SMTP id t9-20020a05620a450900b0078a08cbf298mr7649119qkp.33.1710915286663; Tue, 19 Mar 2024 23:14:46 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710915286; cv=pass; d=google.com; s=arc-20160816; b=rJJeY6s2gNnbzSGLuJVi9C13CrScteeFF5glCL4Cm8kV92/polnhsLtQjPp/P2lanT 4L78CfHeWDzCZ287HQR5gRl8A1JljSfKVgPu7NblJ2MyN2OwZNntuYLg4ts47kX/1Hyo 4Uf6Z1PrMgOvfdEfcAnSEhVCjxocDIQ1p3Xdj79fCnoBN3VfB0EqiE+Fl1k6qL/6X+2d s42rO4JYaXSa0jWiB8a78aaae9gIxTVJ0ZFntBKi/a9PbGCWbCFQJLVKgg7p2uBewOVB 2gVcU4ImshPB9/+iV2giO3YLwkwbNYh5zCHu0nHFMCf8PJcC7HcrXW8hnwnYIcoKu4XD mrMQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=Lif/BQbrb6h/PF0d7/WMWEzXs4USXv3wbzbR/YNq5MY=; fh=Sv21hewKtHYI7qJY7/b33IF0Rz5vBh+Kj+U1zVx7IjI=; b=ERzI5IsMsBj7yMTJRSmNzN5mFn+PcYSCgCqjvUmdponEvQDHwg/B4xQEUBG/QJMCFo jBjfdVWP5H/TGdha1E71AiRjIxhthAj7G/I/8u2qusvIK6HiXy53Fd5zAasPArCG+HyN jCVEr/xcZQRRC4AvAGvKGDWSmsi4eickHWTn2IZkzNQwtOQqw9EVPF2y8jXWeCeRFJQW KadtDS+pAEOL8xrvtcxAzRRys2gF7O39xsvLUpq7SW34Sa970MTL5KGkVNk12PfhMeJU 1FhB5S7H0tBfB2xkeBYMUlzQO2SlseHocg3jOaKPjgS5omx5lp4E6xWk7e9lUIjIhFKj BJiw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=i8lipXK4; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-108486-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-108486-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id n8-20020ac85a08000000b00430eea17489si2185773qta.454.2024.03.19.23.14.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 23:14:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-108486-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=i8lipXK4; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-108486-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-108486-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 579F81C20CB0 for ; Wed, 20 Mar 2024 06:14:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 77BC61A27D; Wed, 20 Mar 2024 06:14:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="i8lipXK4" Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DC53182C5; Wed, 20 Mar 2024 06:14:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710915277; cv=none; b=dC0J8PFJ3lxRsy0j1HCwr322cUtCPkqZuh/kETADj1/ID+e05hjlkU0Dxsmy1K/+g8tHiYfueAixYy/atw5mVppRwnqeI5/U+hgkaR/eJaZ/7/tJXLnFHACJrVaKsTIlil4UWH5p4DDAsl83PM4M9wcvUZfliUZj5Puf2lLNhNk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710915277; c=relaxed/simple; bh=sYjgMXmmRIeUswy8yAn2bF1ZX+zugdRaoOqJPs8SWpM=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=UlSFu99vvv6TDlxpaGZtb5Iyq14hJhT/l9KKpqRTAYIYybe2DuHeJ56gQFlFeHeuYCVKhubFgrxGBrBBYRM/6vJ12ytOm1xbbIGT2xY23556g3k84oKoUptfQYk33O4K77hnOLo1fp8n9JB/yy5H6llRODzksMOd8NBqE0cNgdE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=i8lipXK4; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 42K4Tn5h003074; Wed, 20 Mar 2024 06:14:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=Lif/BQbrb6h/PF0d7/WMWEzXs4USXv3wbzbR/YNq5MY=; b=i8 lipXK4QmQsjrrcC/1yW0ceum9ADlCnY6tthU5tkJZNsyPNerczg2ADIqxYBT/VUX 3A+EwwiCbCNa5zuuC4Nn0XJWoESzwjh2JmdVNE7EQLay2ga95tFVV28Jm+rH0G9V aZN9Paowz+yhAmBFWYK1B5tJOCcTcEOvH4rdzrm7FIfCSMUftBjqSeC5x/Rgv4W0 5Igrv/tPYSs++C8WGd1Ib51RSFAmPjZIJf2TpZSkEPVWM/CZJrVlE0bCLcp6j4gH iTVk3fox6NNSEIV20wdRiaG15DgnMtG0NU3OH2woNXc2nQeDa4tZIIfe/+YfMF/t vpBXUm75OXLWm4CZBOoA== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3wyqh609rr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 20 Mar 2024 06:14:31 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 42K6EU74018131 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 20 Mar 2024 06:14:30 GMT Received: from [10.216.4.119] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Tue, 19 Mar 2024 23:14:26 -0700 Message-ID: <8b1da227-ad6b-4fec-b9e9-d07b8bcbd813@quicinc.com> Date: Wed, 20 Mar 2024 11:44:22 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] rpmsg: glink: Add bounds check on tx path Content-Language: en-US To: =?UTF-8?Q?Michal_Koutn=C3=BD?= CC: , , , Bjorn Andersson , Konrad Dybcio , Mathieu Poirier , , References: <20240113002505.15503-1-mkoutny@suse.com> <151f5738-791e-42cb-b8fe-e0cfbf9f7dca@quicinc.com> From: Deepak Kumar Singh In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: Ol2m4hLgpHUiR9bNXbXqpc3G4pfj9RU2 X-Proofpoint-GUID: Ol2m4hLgpHUiR9bNXbXqpc3G4pfj9RU2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-20_03,2024-03-18_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 mlxlogscore=547 malwarescore=0 spamscore=0 clxscore=1011 priorityscore=1501 lowpriorityscore=0 adultscore=0 phishscore=0 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2403140001 definitions=main-2403200048 On 1/29/2024 10:03 PM, Michal Koutný wrote: > On Mon, Jan 29, 2024 at 04:18:36PM +0530, Deepak Kumar Singh wrote: >> There is already a patch posted for similar problem - >> https://lore.kernel.org/all/20231201110631.669085-1-quic_deesin@quicinc.com/ > > I was not aware, thanks for the pointer. > > Do you plan to update your patch to "just" bail-out/zero instead of > using slightly random values (as pointed out by Bjorn)? > > Michal Hi Michal, Yes, i will be fixing those comments and re post patch.