Received-SPF: pass (google.com: domain of linux-kernel+bounces-108520-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 20 Mar 2024 15:01:48 +0800
From: Chao Gao <chao.gao@intel.com>
To: <isaku.yamahata@intel.com>
CC: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<isaku.yamahata@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>,
	<erdemaktas@google.com>, Sean Christopherson <seanjc@google.com>, Sagi Shahar
	<sagis@google.com>, Kai Huang <kai.huang@intel.com>, <chen.bo@intel.com>,
	<hang.yuan@intel.com>, <tina.zhang@intel.com>
Subject: Re: [PATCH v19 040/130] KVM: TDX: Make pmu_intel.c ignore guest TD
 case
Message-ID: <ZfqJ3LkYrwR/qpsX@chao-email>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <2eb2e7205d23ec858e6d800fee7da2306216e8f0.1708933498.git.isaku.yamahata@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <2eb2e7205d23ec858e6d800fee7da2306216e8f0.1708933498.git.isaku.yamahata@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FyrfRcrngTd2UaVEbFtJY8DwqtoVNGyhi8QsQ5PR0VIDFuLreu3rVpRglRD3?=
 =?us-ascii?Q?QOItqNnEGgsZTD9GWChus0PBkFhTG9nlZtCPQkUmnA+ryKuXJPnlsBWpAJic?=
 =?us-ascii?Q?2RdPXmOGOm+dO/ELS85PcGUw1uV3/df31BfPKOV1eyKiSWE7bHB2Jr7ARAQf?=
 =?us-ascii?Q?o//rVOKv7wdeYRr76Bs67YBxMbRNxTQArjzu1tpaGDs2u+ujv7hzyylKe39N?=
 =?us-ascii?Q?1NhyJfSVWE6cIL6aFPzUAXyppQLZuug+CxJk12yxG69Fh2dlS/3dxucWorfB?=
 =?us-ascii?Q?ILJ25jkfVstqFc+792a6BT4LAJY/GK1bAgHraRjE5vw/s2aWydIwJsmpWcp2?=
 =?us-ascii?Q?0bzrV/MHV9XyOYgRu1/nr8tvU7WCitFp5838RQ3fBaO+M+ODCrKd08k7jgpg?=
 =?us-ascii?Q?ITrmSsmqVze1/9kaw+LVaJxtxkMZnMZi4ZFCfwknDHDum5jkMcGzqKXzLn7w?=
 =?us-ascii?Q?pZ0Z5ciNe+weujSdJPG7oIm2WAf3gH9GvoTPrL0gQgTJ4o3E8ipVfYgKI8qq?=
 =?us-ascii?Q?tJylBP6G+4jFwoeu8OlfTnLyoT8e75waERgT5XKxhMOHWUgRFsIoc0cJkLhz?=
 =?us-ascii?Q?vyIR59kUwTPJZRieVYrrZFmtjmFf+joUHUdRdln5sTLadeFk2GAb25N1Y316?=
 =?us-ascii?Q?2sK78/u7N3CoZxaYgVrr8Dz6IyNsW92PQqtPb/cC0rzhihD93j+TsmEH8MVN?=
 =?us-ascii?Q?TtQUZIvio3BGhNgZpzcA9TcnUJra9yVYTzGD4rv9qqYH3SZDlKCPoUWYPSm9?=
 =?us-ascii?Q?2qmPmv/2pnjg/d4oz+1DPGCK24JVT9m+7/woTMi4rHcP1v3cFlT6tajZOgeD?=
 =?us-ascii?Q?ZtuI4KC92bT/qU/n6JzkRrTt51K7jUvrkInrsbon80l0lxvjMqg0DB5AiDHT?=
 =?us-ascii?Q?cbteBREdARG47Spi3PdDzVWW9qpip/RDMnn8fbOWNu4s+vxcWmrfnKobb3tq?=
 =?us-ascii?Q?qSQZ3Jr7glt8BtGZBtSHK3LPDHxO9x6C2O5V4+wGNlvyYtYVst4rmp1jfSiZ?=
 =?us-ascii?Q?7X1ICLSHZW0mUHtmwMl426Nawno36Cf2SJg14GgHa9rj930RSwq0810ejZny?=
 =?us-ascii?Q?djjcoIxRcOOg5ZgZocgnwrTJVJizL3xdfHIbVhYlFaeg+uBkahUzdIIG7ZMe?=
 =?us-ascii?Q?cxwcHoLOhIYJ9LnOA3r8qMRfc5LEVDjRoS1MCtxK1h/sN6ge59ndd2GY5XK9?=
 =?us-ascii?Q?NSgFyL/EWqMdZObperDlDbL3LYtNZJX6HY3+skNHuIdTuBRWJqcyn3RbffCf?=
 =?us-ascii?Q?jSqvAgWjIX/wF+3ikz3ODTrqbGAHq0d752y3MoKlWgbXk1dpeCcANvry94D5?=
 =?us-ascii?Q?0AP5JZaRJ+VYAV8j3DGwIEaCnoOwvcKsZsq7ACILj/qHkzTEz96b77+yaq/K?=
 =?us-ascii?Q?+MIzmQ3KLmVUMKvimZ9+/kgNxP/b7QDZqR9Tm37KHZNiFCh7qbi8GUrEIGIE?=
 =?us-ascii?Q?tub6dU7Z07j+kKwdA6ox8ZtKW90GBHkIYxyHmMrdj59QxWXM8t1mXt0VTjEX?=
 =?us-ascii?Q?uf5wGtr7ARFISEMD6UusJLq51ncvnVBr0tfAK+2+BDOB+7uCYCiAR2FgUVcq?=
 =?us-ascii?Q?iQ5KvH+C20xMbIsY+hoh8t4mQWlTbiwRRRArIMAV?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0e8e89f5-94e7-495e-8c2c-08dc48aba2ac
X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8660.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2024 07:01:58.7043
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: v6vQgUZ+pYy1cKmCrEmfnIC21RocAXR41si1uCc4Iw3lGq8uVkXN9QLCouaWqqmjOvSrzh/Dc7HxTt+YBGI/zQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7795
X-OriginatorOrg: intel.com

On Mon, Feb 26, 2024 at 12:25:42AM -0800, isaku.yamahata@intel.com wrote:
>From: Isaku Yamahata <isaku.yamahata@intel.com>
>
>Because TDX KVM doesn't support PMU yet (it's future work of TDX KVM
>support as another patch series) and pmu_intel.c touches vmx specific
>structure in vcpu initialization, as workaround add dummy structure to
>struct vcpu_tdx and pmu_intel.c can ignore TDX case.

Can we instead factor pmu_intel.c to avoid corrupting memory? how hard would it
be?

>+bool intel_pmu_lbr_is_enabled(struct kvm_vcpu *vcpu)
>+{
>+	struct x86_pmu_lbr *lbr = vcpu_to_lbr_records(vcpu);
>+
>+	if (is_td_vcpu(vcpu))
>+		return false;
>+
>+	return lbr->nr && (vcpu_get_perf_capabilities(vcpu) & PMU_CAP_LBR_FMT);

The check about vcpu's perf capabilities is new. is it necessary?

>-static inline bool intel_pmu_lbr_is_enabled(struct kvm_vcpu *vcpu)
>-{
>-	return !!vcpu_to_lbr_records(vcpu)->nr;
>-}
>-