Received-SPF: pass (google.com: domain of linux-kernel+bounces-108644-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <000000000000e40a2906072e9567@google.com> <ab273ae2-80ec-45da-910a-e74298c71d50@I-love.SAKURA.ne.jp>
 <CAADnVQLmLMt2bF9aAB26dtBCvy2oUFt+AAKDRgTTrc7Xk_zxJQ@mail.gmail.com>
 <596aad11-ee69-4ef1-b945-7b67a9fb22d7@I-love.SAKURA.ne.jp>
 <CAADnVQL6Q3k0+-5X3Xjov7W_xESxkmVXcsCxQRWitQvhTBsf7A@mail.gmail.com> <dd264bf7-821b-4cf4-802b-60ae3c7b83bd@I-love.SAKURA.ne.jp>
In-Reply-To: <dd264bf7-821b-4cf4-802b-60ae3c7b83bd@I-love.SAKURA.ne.jp>
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Date: Wed, 20 Mar 2024 01:47:55 -0700
Message-ID: <CAADnVQJt+aP=Zo4edCu4iQEmdQjiruR1pJn0qyZZboNym+zd0w@mail.gmail.com>
Subject: Re: [syzbot] [kernel?] possible deadlock in console_flush_all (2)
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>, 
	John Fastabend <john.fastabend@gmail.com>
Cc: syzbot <syzbot+f78380e4eae53c64125c@syzkaller.appspotmail.com>, 
	syzkaller-bugs <syzkaller-bugs@googlegroups.com>, Alexei Starovoitov <ast@kernel.org>, 
	Daniel Borkmann <daniel@iogearbox.net>, Petr Mladek <pmladek@suse.com>, 
	Steven Rostedt <rostedt@goodmis.org>, John Ogness <john.ogness@linutronix.de>, 
	Sergey Senozhatsky <senozhatsky@chromium.org>, Thomas Gleixner <tglx@linutronix.de>, 
	LKML <linux-kernel@vger.kernel.org>, bpf <bpf@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 20, 2024 at 12:30=E2=80=AFAM Tetsuo Handa
<penguin-kernel@i-love.sakura.ne.jp> wrote:
>
> On 2024/03/20 16:12, Alexei Starovoitov wrote:
> > On Wed, Mar 20, 2024 at 12:05=E2=80=AFAM Tetsuo Handa
> > <penguin-kernel@i-love.sakura.ne.jp> wrote:
> >>
> >> On 2024/03/20 15:56, Alexei Starovoitov wrote:
> >>> This has nothing to do with bpf.
> >>> bpf never calls printk().
> >>
> >> Please see the Sample crash report in the dashboard.
> >> bpf program is hitting printk() via report_bug().
> >
> > Exactly. local_bh_neable is simply asking for a splat.
> > _this_ bug is in printk.
> > It's a generic issue.
>
> I can't catch. printk() is called due to report_bug().
>
> If the reason report_bug() is called is that spin_unlock_bh() is bad,
> this is a bug in sock_map_delete_elem() rather than a bug in printk(), is=
n't it.

There are two bugs.
The one you've started the thread about is in printk.

The sockmap bug that triggered report_bug() is separate.

>
> >
> > sockmap bug is orthogonal.
> > It's already being looked at.
>
> Then, can we expect that this bug is also fixed shortly?

cc-ing John.
I don't think it's hi-pri.