Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753264AbYAIHpL (ORCPT ); Wed, 9 Jan 2008 02:45:11 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751500AbYAIHpA (ORCPT ); Wed, 9 Jan 2008 02:45:00 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:56615 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750824AbYAIHo7 (ORCPT ); Wed, 9 Jan 2008 02:44:59 -0500 Date: Tue, 08 Jan 2008 23:44:58 -0800 (PST) Message-Id: <20080108.234458.94292389.davem@davemloft.net> To: lizf@cn.fujitsu.com Cc: johnpol@2ka.mipt.ru, linux-kernel@vger.kernel.org Subject: Re: [PATCH] CONNECTOR: don't touch queue dev after decrement of ref count From: David Miller In-Reply-To: <47845F27.6020305@cn.fujitsu.com> References: <47845F27.6020305@cn.fujitsu.com> X-Mailer: Mew version 5.2 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 536 Lines: 17 From: Li Zefan Date: Wed, 09 Jan 2008 13:44:07 +0800 > > cn_queue_free_callback() will touch 'dev'(i.e. cbq->pdev), > so it should be called before atomic_dec(&dev->refcnt). > > Signed-off-by: Li Zefan Excellent catch, patch applied. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/