Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753814AbYAIH5t (ORCPT ); Wed, 9 Jan 2008 02:57:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751607AbYAIH5l (ORCPT ); Wed, 9 Jan 2008 02:57:41 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:54461 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751424AbYAIH5l (ORCPT ); Wed, 9 Jan 2008 02:57:41 -0500 Date: Wed, 9 Jan 2008 07:57:32 +0000 From: Christoph Hellwig To: Harvey Harrison Cc: Andrew Morton , LKML , Masami Hiramatsu , Ananth N Mavinakayanahalli , David Miller , hskinnemoen@atmel.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, tony.luck@intel.com, Ingo Molnar , Paul Mackerras Subject: Re: [PATCHv3] kprobes: Introduce kprobe_handle_fault() Message-ID: <20080109075731.GA32560@infradead.org> References: <1199737486.7666.12.camel@brick> <18307.64807.204087.375733@cargo.ozlabs.ibm.com> <1199833324.6424.12.camel@brick> <1199852360.6424.39.camel@brick> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1199852360.6424.39.camel@brick> User-Agent: Mutt/1.5.17 (2007-11-01) X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1068 Lines: 23 On Tue, Jan 08, 2008 at 08:19:20PM -0800, Harvey Harrison wrote: > Use a central kprobe_handle_fault() inline in kprobes.h to remove > all of the arch-dependant, practically identical implementations in > avr32, ia64, powerpc, s390, sparc64, and x86. > > avr32 was the only arch without the preempt_disable/enable pair > in its notify_page_fault implementation. > > This uncovered a possible bug in the s390 version as that purely > copied the x86 version unconditionally passing 14 as the trapnr > rather than the error_code parameter. This is not an equivalnet transformation. The old code always made sure to disable preemption and the new one just skips the whole kprobes handler if preemption is enabled. Please separate code consolidation from changing semantics _and_ describe the semantics changes in detail. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/