Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754110AbYAIH6V (ORCPT ); Wed, 9 Jan 2008 02:58:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751607AbYAIH6M (ORCPT ); Wed, 9 Jan 2008 02:58:12 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:54474 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751424AbYAIH6K (ORCPT ); Wed, 9 Jan 2008 02:58:10 -0500 Date: Wed, 9 Jan 2008 07:58:03 +0000 From: Christoph Hellwig To: Heiko Carstens Cc: Harvey Harrison , Andrew Morton , LKML , Masami Hiramatsu , Ananth N Mavinakayanahalli , David Miller , hskinnemoen@atmel.com, schwidefsky@de.ibm.com, tony.luck@intel.com, Ingo Molnar , Paul Mackerras Subject: Re: [PATCHv3] kprobes: Introduce kprobe_handle_fault() Message-ID: <20080109075803.GB32560@infradead.org> References: <1199737486.7666.12.camel@brick> <18307.64807.204087.375733@cargo.ozlabs.ibm.com> <1199833324.6424.12.camel@brick> <1199852360.6424.39.camel@brick> <20080109061408.GA9486@osiris.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080109061408.GA9486@osiris.ibm.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 490 Lines: 13 On Wed, Jan 09, 2008 at 07:14:08AM +0100, Heiko Carstens wrote: > I like this better (not including any other changes): > > if (!user_mode(regs) && !preemptible() && kprobe_running()) > return kprobe_fault_handler(regs, trapnr); seconded. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/