Received-SPF: pass (google.com: domain of linux-kernel+bounces-108704-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 20 Mar 2024 15:13:57 +0530
From: "Gautham R. Shenoy" <gautham.shenoy@amd.com>
To: Perry Yuan <perry.yuan@amd.com>
Cc: rafael.j.wysocki@intel.com, Mario.Limonciello@amd.com,
	viresh.kumar@linaro.org, Ray.Huang@amd.com, Borislav.Petkov@amd.com,
	Alexander.Deucher@amd.com, Xinmei.Huang@amd.com,
	oleksandr@natalenko.name, Xiaojian.Du@amd.com, Li.Meng@amd.com,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 0/6] AMD Pstate Driver Core Performance Boost
Message-ID: <Zfqv3ckVU4km+RLr@BLR-5CG11610CF.amd.com>
References: <cover.1710754236.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1710754236.git.perry.yuan@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?7hOOgbqE/pDQcGUebUkS0r6LQuhUzm9YWWltJV3xM0Lm9v8wz16XacxJLI6E?=
 =?us-ascii?Q?tnZC7QA3WAQtTW4DojwroJ8C5C8kjVcCUV+hUoISmtXEYg1ZzS/xIHFf02p7?=
 =?us-ascii?Q?ds3+RD9DZaqpFYlvqLKPrHreiuoohNUX1/sb4AW7yIEIWRxOcNv2Uz03EOPt?=
 =?us-ascii?Q?8yb/iQRw2lahN6yaC8OAr30Fbo32Ed9FovgiQpI+NaAtEN15V9XjH6xQVYQs?=
 =?us-ascii?Q?vn22kTQAbRanjDWqj0C6J3CibTGKHY/Z8u6D04mVkYh56DOfJeku3jOnKYVC?=
 =?us-ascii?Q?2JcRglnpyrGdW2z0TXYLWRsa+3+PveWjIqT174IwHCZyioGHvRrPGNK3b1zk?=
 =?us-ascii?Q?hIfzF7zS0Wo8RP+u5mhppAvk6Ap/+nMQyy71vIEFn8AX5c5edyGqXdPeq/++?=
 =?us-ascii?Q?MgptjtJKasABFdFfpTB36So/v1B2bMHwxgXMq3PdeagmAKutqhN6xeDCL8+q?=
 =?us-ascii?Q?UfDsiOWQtOVsd5yuOZFzMmJptjA0XyNV9SOUwDlvkNwrDrOhiHNIsyOiC9Zy?=
 =?us-ascii?Q?KrvC+wgbmZe1STY8NPjlzu7eDZ24RTVsD/0DPVIQU+FqBtJH7vDnD6MAtebw?=
 =?us-ascii?Q?pA3k31+lABCzG+cl6/dRSu5zInvlSMluRSMqq3iqbHVP+kGZcdLKmV+Wpuj9?=
 =?us-ascii?Q?NgGYTmB85lM0QJsfinIehrNLFEZzd6GSCDQor3zU5lzI6LAQ9N1fTOo3NeoN?=
 =?us-ascii?Q?xkRvZ6T/X7KXgartc1zAHVgGCaJVR4wbhBR1r/r1jtu9Dq043IMtc9eP0Avj?=
 =?us-ascii?Q?zWwaSIFbf5fM2vQXR76jhx86Q7jRgUr7HMwNTC+Iw2qiQcdAy7E6WLJPvqxl?=
 =?us-ascii?Q?vJ1EeRJU0esYCui7KRpdVkj2IRNgE0pz1a6tsMdjEvE2NpqMKVH5pgv31GTM?=
 =?us-ascii?Q?1rd8BTrk3nhqOALwGb7KtRavWg31g989TYGCmmYO9Ub+/AVvmpHNJQGvhwZi?=
 =?us-ascii?Q?bCEbJdlwxu/z4JAMWHcmyaRO6WRX/KsI8pNrGVQzGKXFUsyh3zc+fSp4/LTx?=
 =?us-ascii?Q?6gyBh7eNB2mo13NmHTbhg3x9ib11ca6aRf1fEJkt/LMvkbkSTlmhhZ70rgdG?=
 =?us-ascii?Q?m5k26sMOsRjHYFyLM4k99pu/PYRg3/yvWMRZC0K0BxaMiOKIooGmm1E/EvEA?=
 =?us-ascii?Q?Dewxmz7r/0DUfDXQNjjtDeihbKsdiXcS1EmU+DnRPtfZuhXiJEyBnsQ43ET9?=
 =?us-ascii?Q?5xDUFBxYHd0lVzfvVHtN5asK9tZG7JWZZlLwuuOjkrnQitYceFtoOK4EO5Ox?=
 =?us-ascii?Q?iWcJXngv07t0a+N066SWG/aDuKWB72UuDDCikWDs/a9uc58kEtW4na5S+XBJ?=
 =?us-ascii?Q?ZBVKtCIH5+YVhDZ8r+uBHELRZKEpS2P3KbN9MiK4/LMQKOB94iGeSJE/uDMR?=
 =?us-ascii?Q?bXZZlC7e57SVfUbdqja25P6WNE/B3vXc2yAD3iwdEvkWgxhttvEI2DrwFWDj?=
 =?us-ascii?Q?4IP1l6VME6VYew77XBC3R5mymrhO/XfEvOE6hQB3vOGqAlNks/VJkA5Fk5+y?=
 =?us-ascii?Q?371mWzqKq+bGzHqpD8MpRCp5ix6apbbvnq6pU1IyhlXR4SEwOXGISrSiFx2j?=
 =?us-ascii?Q?s9l+qii168wXCMvR/xC5jPyBOaPJAbuleiQ8ZwDe?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 73551cc4-ce77-4287-a678-08dc48c24861
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB8252.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2024 09:44:05.8817
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: u3nJXVgzbaNU4nm3TDJuhiAxdUp4HZx4YyFbPNt+mDk90PrecONy+z6JTY6neXsNc+75JfM/k7sA6z9IIU4/gQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5712

Hello Perry,

On Mon, Mar 18, 2024 at 06:11:07PM +0800, Perry Yuan wrote:
> Hi all,
> The patchset series add core performance boost feature for AMD pstate
> driver including passisve ,guide and active mode support.
> 
> User can change core frequency boost control with a new sysfs entry:
> 
> "/sys/devices/system/cpu/amd_pstate/cpb_boost"
> 
> The legancy boost interface has been removed due to the function
> conflict with new cpb_boost which can support all modes.
> 
> 1). enable core boost:

You meant disable core boost here.

> $ sudo bash -c "echo 0 > /sys/devices/system/cpu/amd_pstate/cpb_boost"
> $ lscpu -ae
> CPU NODE SOCKET CORE L1d:L1i:L2:L3 ONLINE    MAXMHZ   MINMHZ      MHZ
>   0    0      0    0 0:0:0:0          yes 4201.0000 400.0000 2983.578
>   1    0      0    1 1:1:1:0          yes 4201.0000 400.0000 2983.578
>   2    0      0    2 2:2:2:0          yes 4201.0000 400.0000 2583.855
>   3    0      0    3 3:3:3:0          yes 4201.0000 400.0000 2983.578
>   4    0      0    4 4:4:4:0          yes 4201.0000 400.0000 2983.578
> 
> 2). disabble core boost:

.. and enable core boost here.

> $ sudo bash -c "echo 1 > /sys/devices/system/cpu/amd_pstate/cpb_boost"
> $ lscpu -ae
>    0    0      0    0 0:0:0:0          yes 5759.0000 400.0000 2983.578
>   1    0      0    1 1:1:1:0          yes 5759.0000 400.0000 2983.578
>   2    0      0    2 2:2:2:0          yes 5759.0000 400.0000 2983.578
>   3    0      0    3 3:3:3:0          yes 5759.0000 400.0000 2983.578
>   4    0      0    4 4:4:4:0          yes 5759.0000 400.0000 2983.578
> 
> 
> The patches have been tested with the AMD 7950X processor and many users
> would like to get core boost control enabled for power saving.
> 
> If you would like to test this patchset, it needs to apply the patchset
> based on below one latest version patchset.
> https://lore.kernel.org/lkml/cover.1710754409.git.perry.yuan@amd.com/

Thanks. Will test this on EPYC platforms. 
>
> Perry.

--
Thanks and Regards
gautham.

> 
> Changes from v4:
>  * drop the legacy boost remove patch, let us keep the legacy interface
>    in case some applications break.
>  * rebase to linux-pm/bleeding-edge branch
>  * rework the patchset base on [PATCH v8 0/8] AMD Pstate Fixes And
>    Enhancements which has some intial work done there.
> 
> Changes from v4:
>  * move MSR_K7_HWCR_CPB_DIS_BIT into msr-index.h
>  * pick RB flag from Gautham R. Shenoy
>  * add Cc Oleksandr Natalenko <oleksandr@natalenko.name>
>  * rebase to latest linux-pm/bleeding-edge branch
>  * rebase the patch set on top of [PATCH v7 0/6] AMD Pstate Fixes And Enhancements
>  * update  [PATCH v7 2/6] to use MSR_K7_HWCR_CPB_DIS_BIT 
> 
> Changes from v3:
>  * rebased to linux-pm/bleeding-edge v6.8
>  * rename global to amd_pstate_global_params(Oleksandr Natalenko)
>  * remove comments for boot_supported in amd_pstate.h
>  * fix the compiler warning for amd-pstate-ut.ko
>  * use for_each_online_cpu in cpb_boost_store which fix the null pointer
>    error during testing
>  * fix the max frequency value to be KHz when cpb boost disabled(Gautham R. Shenoy)
> 
> Changes from v2:
>  * move global struct to amd-pstate.h
>  * fix the amd-pstate-ut with new cpb control interface
> 
> Changes from v1:
>  * drop suspend/resume fix patch 6/7 because of the fix should be in
>    another fix series instead of CPB feature
>  * move the set_boost remove patch to the last(Mario)
>  * Fix commit info with "Closes:" (Mario)
>  * simplified global.cpb_supported initialization(Mario)
>  * Add guide mode support for CPB control
>  * Fixed some Doc typos and add guide mode info to Doc as well.
> 
> v1: https://lore.kernel.org/all/cover.1706255676.git.perry.yuan@amd.com/
> v2: https://lore.kernel.org/lkml/cover.1707047943.git.perry.yuan@amd.com/
> v3: https://lore.kernel.org/lkml/cover.1707297581.git.perry.yuan@amd.com/
> v4: https://lore.kernel.org/lkml/cover.1710322310.git.perry.yuan@amd.com/
> v5: https://lore.kernel.org/lkml/cover.1710473712.git.perry.yuan@amd.com/
> 
> 
> Perry Yuan (6):
>   cpufreq: acpi: move MSR_K7_HWCR_CPB_DIS_BIT into msr-index.h
>   cpufreq: amd-pstate: initialize new core precision boost state
>   cpufreq: amd-pstate: implement cpb_boost sysfs entry for boost control
>   cpufreq: amd-pstate: fix the MSR highest perf will be reset issue
>     while cpb boost off
>   Documentation: cpufreq: amd-pstate: introduce the new cpu boost
>     control method
>   cpufreq: amd-pstate-ut: support new cpb boost control interface
> 
>  Documentation/admin-guide/pm/amd-pstate.rst |  11 ++
>  arch/x86/include/asm/msr-index.h            |   2 +
>  drivers/cpufreq/acpi-cpufreq.c              |   2 -
>  drivers/cpufreq/amd-pstate-ut.c             |   2 +-
>  drivers/cpufreq/amd-pstate.c                | 143 ++++++++++++++++++--
>  include/linux/amd-pstate.h                  |  13 ++
>  6 files changed, 160 insertions(+), 13 deletions(-)
> 
> -- 
> 2.34.1
>