Received-SPF: pass (google.com: domain of linux-kernel+bounces-108721-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <a2f64005-bb50-4d3a-afc3-a8db57f4b2b4@amlogic.com>
Date: Wed, 20 Mar 2024 17:55:48 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 3/5] dt-bindings: serial: amlogic,meson-uart: Add
 compatible string for A4
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>,
 Neil Armstrong <neil.armstrong@linaro.org>,
 Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
 Jerome Brunet <jbrunet@baylibre.com>, Kevin Hilman <khilman@baylibre.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Jiri Slaby <jirislaby@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org,
 linux-serial@vger.kernel.org
References: <20240320-basic_dt-v2-0-681ecfb23baf@amlogic.com>
 <20240320-basic_dt-v2-3-681ecfb23baf@amlogic.com>
 <402e56ec-7fee-40a9-995b-b737d4a53d60@linaro.org>
From: Xianwei Zhao <xianwei.zhao@amlogic.com>
In-Reply-To: <402e56ec-7fee-40a9-995b-b737d4a53d60@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NlB4cUprRGh3NzczQ1JKUTg5bzBVTW5ZdUFRZndTZlhyL3JJRzRCSGs2clNj?=
 =?utf-8?B?TUlmVU4wb0Mxek5vNG9NUUszai9Xd3pMSVB2ZFVpSEZVUWRMTWZjUk9wNUhx?=
 =?utf-8?B?MVB4ZUdUTFBxcXp6UzR4MHVBUU81MEFNUUlJQkJkQ0NKYUEreFBhS01aY3NO?=
 =?utf-8?B?YXB2bng5cVdTcmczMFVwYzM3dlJWU29RamZnSzJLcnljcjAvMW5kaENFZDVm?=
 =?utf-8?B?bzlrL05vMElsQk1PdCtwV3krQXFiSzJFZE82eDViMWNZTEdxdmU5Q1ZLWk5L?=
 =?utf-8?B?OHoxZ0xzR0hKa3RGUjdDaS9BS1ZhU21tZ3NFR2owcFFpUHR4OHRvZVA5NXB2?=
 =?utf-8?B?UlNiNEloR2Fyb1FZalhlVWhrWisrK3BiMHVrNlRXTmFDWEkyMHdkdmNuMjlD?=
 =?utf-8?B?U0hFMUl1WHRaT2lFUDJaQ1pVL29Ea1htdnFFTGhxM3VIQXk5RkpIK1lWS3Vh?=
 =?utf-8?B?MmtRYVZPa2VzWnBhVXZBVjV5a1VvdXAzenFvUkRVenZCQ1RKalVJbTZWL0s2?=
 =?utf-8?B?dmd4cEVVTForMDZrWmZxZU9rdEFjeThSK1hsQzVVa2t5UWJWSXZjZnUrakZo?=
 =?utf-8?B?OGxIQktxcU9OZE5wYlc3QlRpTmpzeDVMUEFkSGNRUS9QSEYwOUgzL2xySDdJ?=
 =?utf-8?B?dHdzTXhqUVhrc3U4OVFBa3I4VG42TUFlU1BPbm45NGVhVElvdnFQZExoSklS?=
 =?utf-8?B?SkNKdDJJMThlazVaaFJiTGx0SVo4TTdncld0SW5uQkxsaWZJaCswUkRqMVhq?=
 =?utf-8?B?Q1RpT0s3dlVOTUpJa1VCZXNOalp0U3puMjlUZVV6YVJmYng4N0VNT0ZQM3NQ?=
 =?utf-8?B?ckQ4Y0xjS0tVaVJJVXRWS1NzRXhFVHl2SVR0M3V4Y1VLTG1XWEhtSWVZeW9x?=
 =?utf-8?B?VnNrVWtJd05EdTVuQ09yTnVZMGxnS0EzajRwNGlTTGZhZFU1SlpoVFhoWVRh?=
 =?utf-8?B?a3hJUGxEZUV0OWUwU3Z5SFhvM2J2V3FJUEFTWTJFa3VqdzJ3bHJ1aGFqWU8x?=
 =?utf-8?B?TXBtbk9ac2FHOFUvSXZRUzlrV3ZiME45cjB5MEJpRFVjWDZuQjB2YnA3bkRJ?=
 =?utf-8?B?dE5ZSGpwZnpWUVd1aVg4VVBzeTljRDBtWVUvMlc0U0JJOS93bkpucFVQVTU4?=
 =?utf-8?B?ZmkrNlRvQ0gvSFRDREI3N1JIVEdTNExCVERTZEJiRWtMNk5ZRjZWVXJvSTZ3?=
 =?utf-8?B?SU1COVhTNVpPUGdJNmZwUG1vYjBZOG1LMGpNZ2IydnltVUR5UTFIaGJwZDN2?=
 =?utf-8?B?SEtxL3ZzNTdIaU5HOElNU0QzcUxSeHZIZHZla0xLYnVseVVPemRNeUFKeStT?=
 =?utf-8?B?ais2Y3NHcnkyMUI4RlEzczV0RStjZGVEZWZ4N2xDSkQrRlBMUUhuYm1YMTQv?=
 =?utf-8?B?T3MzQ0VEQXltZTA2bEZNNk1raTFPd1VJd1oxa3RRTUl3UUpiOVd3b0VZeGor?=
 =?utf-8?B?N280RjJVckNGd0xaK2t2RDZkY3M5VitZZEJKTzFFV0x2amlVK2Z3bFdDL2J2?=
 =?utf-8?B?S2l2Y0pxSE5VM01jd2dnRzU3WTc5TjI4R0p1UGc0dVNINy93Z2t2dlJjV29T?=
 =?utf-8?B?VFVncHBVTk1aeE1yUEx6VFFnVDBrTUgzVkFZRGI3REw5T1cydWJRYUhOUExp?=
 =?utf-8?B?eVAvSHljRktwNStUUndxMnlIMHB1VU94aW5OMjZjVUY2OU1QTWQzUGZaQUVK?=
 =?utf-8?B?NisrMFdFZ3VKbUNJSnFMTmdRN05DMkVyWHNTcUNKRmJDL3ZZOXZFUHdaZ2Va?=
 =?utf-8?B?Zi81K1FwNkJCRDdpWmpBTlJSU09Bb1FTV0hoMmNzckFQd3NxcUJQckJoQmta?=
 =?utf-8?B?eUdFOWxEOHBCc2dkNjFWSk1RTGtxMk9HSTJJQThGWTVQTjI5SkdncDJpdEl3?=
 =?utf-8?B?eVB0OHdpa1A3encxTDNHVUxLLzkwTWlXS1czVXhTeUw4Y2liK3Yxb3c1T1hw?=
 =?utf-8?B?UWNTMmtlMEFZVnpnY29vdXYyRVB6RkIrcEM2aThlSC9VeW13TkcwaWtIcm5G?=
 =?utf-8?B?N0VNU2xNUFV5Y2JsRkpFN2t3R2h0V1FPZkMzenRyNzE0VEZpd1RLRzJkcWFR?=
 =?utf-8?B?bkRuNVNWc1N2SnpQaTFJa3J3YmlGeG5zM1JIckh3VlBaenZpN0dNUERidzdM?=
 =?utf-8?B?Mm9ETjhUWk5XaDZRdktVOWtncHFhT2RMQVhJUldkUHYzRmN5MVllTnlKbXRS?=
 =?utf-8?B?RWc9PQ==?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b167fe6-8b9d-43a4-ee60-08dc48c3ee1c
X-MS-Exchange-CrossTenant-AuthSource: PUZPR03MB6888.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2024 09:55:53.1270
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r2k4TONygbQnIETObjg1WVErH2kkd48umLdAhiJ/Dgc5GTjTFW/+MO2sdCbjAmjvpk+mKKX5H/AfacK12fEUlC3dImZkL9GpjKiKukM37Vc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR03MB6882

Hi Krzysztof,
     Thanks for reply.

On 2024/3/20 17:47, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
> 
> On 20/03/2024 10:44, Xianwei Zhao via B4 Relay wrote:
>> From: Xianwei Zhao <xianwei.zhao@amlogic.com>
>>
>> Amlogic A4 SoCs uses the same UART controller as S4 SoCs and G12A.
>> There is no need for an extra compatible line in the driver, but
>> add A4 compatible line for documentation.
>>
>> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
>> ---
>>   Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
>> index 2e189e548327..d05c45815dc2 100644
>> --- a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
>> +++ b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
>> @@ -54,7 +54,9 @@ properties:
>>             - const: amlogic,meson-gx-uart
>>         - description: UART controller on S4 compatible SoCs
>>           items:
>> -          - const: amlogic,t7-uart
>> +          - enum:
>> +              - amlogic,t7-uart
>> +              - amlogic,a4-uart
> 
> Keep alphabetical order. Don't add stuff to the end of lists. This
> comment applies in general, for almost all your patches, so also future
> submissions.
> 
Will do. Thanks, I remembered.
> Best regards,
> Krzysztof
>