Received-SPF: pass (google.com: domain of linux-kernel+bounces-108730-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <5143565f-2865-4d3a-a848-7aa700fa26d4@amlogic.com>
Date: Wed, 20 Mar 2024 18:06:42 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 4/5] arm64: dts: add support for A4 based Amlogic BA400
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>,
 Neil Armstrong <neil.armstrong@linaro.org>,
 Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
 Jerome Brunet <jbrunet@baylibre.com>, Kevin Hilman <khilman@baylibre.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Jiri Slaby <jirislaby@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org,
 linux-serial@vger.kernel.org
References: <20240320-basic_dt-v2-0-681ecfb23baf@amlogic.com>
 <20240320-basic_dt-v2-4-681ecfb23baf@amlogic.com>
 <f0050b33-c4fb-4263-aee6-4542e2be39e8@linaro.org>
From: Xianwei Zhao <xianwei.zhao@amlogic.com>
In-Reply-To: <f0050b33-c4fb-4263-aee6-4542e2be39e8@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VytTeUJrTFdiVGxQdUlxb29sWTlTM2lWb2c0VE1mUzFSS0duejNSNnJuZDB3?=
 =?utf-8?B?MkoyVU96dWJnOWRXN3VNeCtUbHhiMTdSWi9JSVQybDZmZG91MzVDSXRxU3VP?=
 =?utf-8?B?QjdyUTdFck52Y2FUMitoS0FWb25aQUJDWkoweUNLNUpYSHNWQlo1elN4c0ps?=
 =?utf-8?B?K1BsalMyUmV3eXJXZG5MNDloMlJFWE9ISXdjVGFKZjJ2VTJVOGprR1ZwNkgv?=
 =?utf-8?B?NWR4RjB5NStmdUEzbmxHOTZUSzBwNEIzb1V0VENwL0pEVFRUNUNKZCtEeG5w?=
 =?utf-8?B?UEVPRWlFcnpyKzd2VHQ2MWV3c2VVRDR3ZlVjMEZPZEhDczRUd2hyZW5lbGVY?=
 =?utf-8?B?MENkMEF5UjJxTnJHUERaS2kxKzNuRDlNeHVtMjlFcVZOOVR4VXpPOFkraFFk?=
 =?utf-8?B?QWV5WWgvR1I4VkNxRU80M0UwUnVjcXdCYlV4ZjRxTERPWHZUdldnMEZwZXZv?=
 =?utf-8?B?bThNQlhPWXhDUS8yRkFUU3h2cmNuOHYyWXU4V3dTWFpUS0dDWG8xN0N5NFhO?=
 =?utf-8?B?aUVXQXRoNXFweEt4RTJWR291UERzSmNxa1lrbXJlYlhVT0Vzek5iL3IrYXFW?=
 =?utf-8?B?QVdvbkJKOG4rT3VuZzhFc3N2WGZTdjhUOVB4WDdtdVF4OHZBRTRlaEYwMlVo?=
 =?utf-8?B?Umcza09YaWJrRXA0SHpvNWE4ZjNNRG9ubzdvMmFiRksyWXhGblFHQnBka0ZF?=
 =?utf-8?B?RWloNWNQWDkrUzZwc3JvbENMNXl3dEtoMjVuSjN3NWN0T2NoeHFkQjIxYkdn?=
 =?utf-8?B?enhqNE1ZWlEyRXA5dHhTNitBb1FVTTNmYzZiK3NuQ3k1NmVuSUVDbzFEUlVw?=
 =?utf-8?B?LzRJNUxVdHdETUJSSW1zNFhRNldhWmhmMjJmYjBNL2FBenVDVDZUK2NjVmFw?=
 =?utf-8?B?WEJ2VVg3Z294aXltMldQZW5wb1ZEZGtWQjdoVUlGQkdMSzcvUktsOHkvS3k5?=
 =?utf-8?B?N3Y3cjJ1Rnd0dnBDNHBaejdRSk9ENmVBd2Z6VXZ0VXlIbjZhZGdMckduRkhq?=
 =?utf-8?B?cHRjSUZ1V242dFhOVE91THJCUWUwT1o1bG9vSU9CL0drTXR2ZmlQLzdpMUZV?=
 =?utf-8?B?TVJCUUFGNHZqblNBRFpqMkpLQnBockhEQm1wZXRzWEdSWjFZY1dlYytpWGl2?=
 =?utf-8?B?QXN4R1R6WGZyMVVKYktadDF2eW53Q1N0by9vZEg5bTlWb04rWTRybHZCR01z?=
 =?utf-8?B?NWlwQTFJRWk0ZVVZK1RwdjNtSjFlY3RuaUNaeDhYOUh6dkhYcHQ1K2crbzdI?=
 =?utf-8?B?UExuSm9nanhlR0ZWeDdORlJ1TzB1VloyRHE1czNPN0hsUHZHTmFkMVY0bFVF?=
 =?utf-8?B?cG9OcE1aOExKbFBnZ0lEK1BLYU1EWStzN0JjanVnYzRkZk5oeExTYmFucmtr?=
 =?utf-8?B?Rkg1Y3EzVTlZVWRVUHFyLytzelhTcnNYdEl3bmFiNUprYkJoNlNMc3Y5SUhT?=
 =?utf-8?B?WHhVN3dSYnBmY1VPUktObk9zc0FUY3VqRUo1aVJHT1dBclRaMDJhVXhxRFQz?=
 =?utf-8?B?K3U2dGZMOVlKTkpTZk1LcC96cGhQU0VoekpKeGxDVVdjZnZqWTg0TytXRGlm?=
 =?utf-8?B?ZjF0WXJNdGVRNUdKSlpXNWRqYThDeHMwUEJhY2FINW5YYlM3aEUyUTFiVWEy?=
 =?utf-8?B?VE9sV1cxc29PT2I3blNJOFJ5Ny95czRUNVkzSGlkZUpIbVU3OWs4amNoaU82?=
 =?utf-8?B?WWh4ODRTUTA2a3NyUkR4TDd3bFFKcnRsbDFxR3pvM1c0N3p6aThTeEl6OHps?=
 =?utf-8?B?ZGJNQ0U2RDNDKzlDdUR4Z2N1TWlqN2t4clFxMGJHdVh3MGU2RG9ZMXhNTlJH?=
 =?utf-8?B?SHA0TUdMS2doNmNSUVoyOVpkL0pvYXA2ZEx3V05odDIzLzBGQUNBbkFWcEJ4?=
 =?utf-8?B?bWxRZzNRT21hZWxGMmt4OFRCaHBaOGo0WDFhbG1iWU5zTC9BeG5Wb1UxV1pO?=
 =?utf-8?B?Zjg3aVIzZVY1dHpGd09yS1hFanpNaW13dGhDK0VUeWY0c2QxSURnYWlQc2Mr?=
 =?utf-8?B?ejlBc1JTY3NhTlowWGRxN1o5SmxTeU0rdW1oK1NxNDNTYVpKMWVOc3kvSzlu?=
 =?utf-8?B?cFJwakZTUDNMZUpVR0ZuOE55SUpkN3pFVkRmOS9TUkRBdVBCUW5EUjRaZUh3?=
 =?utf-8?B?SytHWHlhdE1OWHZueG11ckZ3RFZUeXJtRTk5MTYrT3ZxQWlVOUlnY3dKMHNJ?=
 =?utf-8?B?ZEE9PQ==?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 42f03aaf-4f63-4601-93cb-08dc48c574d2
X-MS-Exchange-CrossTenant-AuthSource: PUZPR03MB6888.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2024 10:06:48.7108
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G96d2r3vIJBHw1zTrvey1aI4VNpbxsIKKKV+NTzdUllgvRLH6x0PURyMTLIO4tMaFpne863re2fApmydzR5LLH2niLQ4E1YQQn6YwarkPxw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS8PR03MB9007

Hi Krzysztof,
     Thanks for your reply.

On 2024/3/20 17:48, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
> 
> On 20/03/2024 10:44, Xianwei Zhao via B4 Relay wrote:
>> From: Xianwei Zhao <xianwei.zhao@amlogic.com>
>>
>> Amlogic A4 is an application processor designed for smart audio
>> and IoT applications.
>>
>> Add basic support for the A4 based Amlogic BA400 board, which describes
>> the following components: CPU, GIC, IRQ, Timer and UART.
>> These are capable of booting up into the serial console.
>>
>> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
>> ---
>>   arch/arm64/boot/dts/amlogic/Makefile               |  1 +
>>   .../boot/dts/amlogic/amlogic-a4-a113l2-ba400.dts   | 42 ++++++++++++++
>>   arch/arm64/boot/dts/amlogic/amlogic-a4-common.dtsi | 66 ++++++++++++++++++++++
>>   arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi        | 40 +++++++++++++
>>   4 files changed, 149 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
>> index 1ab160bf928a..9a50ec11bb8d 100644
>> --- a/arch/arm64/boot/dts/amlogic/Makefile
>> +++ b/arch/arm64/boot/dts/amlogic/Makefile
>> @@ -1,4 +1,5 @@
>>   # SPDX-License-Identifier: GPL-2.0
>> +dtb-$(CONFIG_ARCH_MESON) += amlogic-a4-a113l2-ba400.dtb
>>   dtb-$(CONFIG_ARCH_MESON) += amlogic-c3-c302x-aw409.dtb
>>   dtb-$(CONFIG_ARCH_MESON) += amlogic-t7-a311d2-an400.dtb
>>   dtb-$(CONFIG_ARCH_MESON) += amlogic-t7-a311d2-khadas-vim4.dtb
>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-a4-a113l2-ba400.dts b/arch/arm64/boot/dts/amlogic/amlogic-a4-a113l2-ba400.dts
>> new file mode 100644
>> index 000000000000..43a9c666e1de
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-a4-a113l2-ba400.dts
>> @@ -0,0 +1,42 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +/*
>> + * Copyright (c) 2024 Amlogic, Inc. All rights reserved.
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "amlogic-a4.dtsi"
>> +
>> +/ {
>> +     model = "Amlogic A113L2 ba400 Development Board";
>> +     compatible = "amlogic,ba400","amlogic,a4";
> 
> Still missing space.
> 
> You received comment about this. Fix entire file, not just one occurrence.
> 
Will fix. I got it.
> 
> Best regards,
> Krzysztof
>