Received-SPF: pass (google.com: domain of linux-kernel+bounces-108788-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <cc86991d-1c8c-4d49-bdf2-a8d451ddd039@amlogic.com>
Date: Wed, 20 Mar 2024 18:31:09 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 5/5] arm64: dts: add support for A5 based Amlogic AV400
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>,
 Neil Armstrong <neil.armstrong@linaro.org>,
 Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
 Jerome Brunet <jbrunet@baylibre.com>, Kevin Hilman <khilman@baylibre.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Jiri Slaby <jirislaby@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org,
 linux-serial@vger.kernel.org
References: <20240320-basic_dt-v2-0-681ecfb23baf@amlogic.com>
 <20240320-basic_dt-v2-5-681ecfb23baf@amlogic.com>
 <98b3fb64-2256-4280-bbfd-c944e5df829b@linaro.org>
From: Xianwei Zhao <xianwei.zhao@amlogic.com>
In-Reply-To: <98b3fb64-2256-4280-bbfd-c944e5df829b@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SU1EcFVLazFyYTIwa1E0K2NOdWppUlV2RzBoTUdEZk5Xd3Z5ajFwaDN6RStq?=
 =?utf-8?B?bFQ4WEZxbitNdHNFS3l5Wkt3c0dBR3lZWTgwMlI0SDEvYmpkV0FVMEwrenNI?=
 =?utf-8?B?VVg5SExBVU9KU2xEN0Q0SnhSMlowZnM5aFJWdEt6RGVISEV5TnZ0TFR5QTZn?=
 =?utf-8?B?aHpKSDZnWjZvdWQzSFlQRmFFN2swSUtQVU9KMEo0NnJaYXpVRlo5Y1pMRVdI?=
 =?utf-8?B?alBNdWsxM1VqRzF1RklwNUdQWDN5ZUx3bE9ocXVFeUtkZGY5QXowZnRrTHpG?=
 =?utf-8?B?eFJiRVk2aU1DT1JYcnp3TllWTWEzUHo1bG9Eejc3WHpON0QyZ0lKbHZaKzVw?=
 =?utf-8?B?Qnc5eVI1cXV5S0ZNZThNRTNFRFYycHRrcysyOGxONXVBNzA1NTQyT0tSNjZG?=
 =?utf-8?B?SkF5U09YV1ROdW51aHJId1hVcm00SXF0WnhyM0ptL0puQWVwQUJLWFVIekY5?=
 =?utf-8?B?clM4TGNGc3h3WVZYREVHeWdyWThaQ0E0bTljM0g5Q1NOaFI2cnFEaHl1UE9M?=
 =?utf-8?B?ZTFHOUxvZTBZVFVDUWxNT1RRdi9MbVB5T2YxRmc1aWlzTEtDRVNOSXZieWxW?=
 =?utf-8?B?TnBEalVBa05VS2JMazkxNGFGK3l0SmlCbGhTL3A4L2ZyWEwxS09uYnhrUm1O?=
 =?utf-8?B?U0ZmUENBM3ZGMmRpOWFYNjUxYS81dVhGZ1JQeXpKd3ZYMVJET0ZHa25rVHp1?=
 =?utf-8?B?azFPcll6SWV5Y05rZmgyc2s2NmlEWWVSa0xheVVlVnZ0TkFyeWpBTkNVZ0dJ?=
 =?utf-8?B?bEtxQXM1NEp0b0R5anJMY09zL0ZRWXo1Z25yaVF2aVphTUlGc25PR0NGZkNx?=
 =?utf-8?B?dWw5Ry9pTUpxdFoyTXZZN2gyTmE0TFJ3YmxVUDRFMGhvRlVsL1E0S0kwSzht?=
 =?utf-8?B?YmJLWTRwVXZIS2JhNDN5Vk9CTk5JRUE2OE1vaXUzUHNOSjZ1Mi9DMFBIMWJB?=
 =?utf-8?B?OVZ2NU5NNElPN2xiNjBHL2NQZ0V6VW5lNVZLd3dXYnh5UjVPTmRmSWNlekx0?=
 =?utf-8?B?WEFKOUN5R1l4Ty8xK21vK2NYWXJvVGVGZUdodUVYK2UwZGJna2xNdDY0RXFz?=
 =?utf-8?B?SWswOXJCMDFLLzFUa1BYcWk0ajBOU3VkN2dVRjc1TnZzWGJKL3liMmJwbFEr?=
 =?utf-8?B?YlVhcFFnalJVM2xzQnFBaFAvVXYxRk5ndExKN3dpWW92blJQNXNVWERMTnRp?=
 =?utf-8?B?WUY4YTlLTy9WZWRWWnQ5cW0rMUo3SkFIZHk3UXhCVnE5ZkorSGlNc1ZrUmZK?=
 =?utf-8?B?WkkxV1BkMnB2Qm5TcGtjcXAvdEtFVU9CZ05NZnpHbVhUWkxaTmdkaDV3OEtU?=
 =?utf-8?B?aStuUnVPL2JXQlJ6WmFEeldUUXdtRjlJeVY5UDhJZzVJVWsybFo4dFdjZE04?=
 =?utf-8?B?U0hlWkVycDNuQUh4MHlERjlMcTFmN3FiMjVPUHNuOVRWTStsZ293aVVFdUNy?=
 =?utf-8?B?K05pRnZRSnNBTVd1N3VFbllZVkF3aXYvQmRTMjYyKy8wWVBGR2p2R1pFYVpt?=
 =?utf-8?B?eUVGc2lvdkpSeGN4Z0VpKzhLSWpoTmRTQmZDMkZEYXdqN3dhRHZoZ0FiNHps?=
 =?utf-8?B?T1BOSG9rZC8vUi9YUWFiUllLeGxuZGk0dTk5cEV4WlBOaDUzWUU5UG0xQ1hh?=
 =?utf-8?B?TS9YRHFFaXUzNk5CbWZ0aEM5bndqMlRuM25BZlBpT2lHai9IdWVuTmd4M3hW?=
 =?utf-8?B?M0xXMmVpT1hxR1VIb3ZGTVlsYXBRVnNHUXpkMHk1QXhQNVR5Wit6YXFpT3d5?=
 =?utf-8?B?cTdOREh2UEREejN4N0pWZzF3RzZzc0NkTVlxTU9jTWFkOElEcXhuTUNXeEIv?=
 =?utf-8?B?VVZJSUpSYjVBU1NtbURnSFNLYk1MWEhkVWJHMmpHcEFKcENxbWZYam5mUFBp?=
 =?utf-8?B?ZjJGRXIrZXF4MTJRcGViNU1lZytQNVcrbVdmRkdiVk12N0ZSSHRPWmI5Wm5D?=
 =?utf-8?B?TVkxSnVhd216M3p3UkduWnBHVklUU0V5cncyZDJ2b3A0eFgrSFpodkl5aE9u?=
 =?utf-8?B?VFdmaHl2dVhqY0JicHdtRk4xMlc5OC9xekp0Mmx5Yk5mVWVkUFBVTXV6TjJk?=
 =?utf-8?B?NmxOazR5VXE5WXBSNVZYTmd2WW1CRjk0NkphVE9EeHNGS0E1c2MvRzhTNUdx?=
 =?utf-8?B?QmNFM2lOaExJd1JQd0JpS1dwa0txK1Y3clZ1WDlYdlFNK2JGOEg5SmlsWXFM?=
 =?utf-8?B?dFE9PQ==?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b1e8a00b-23eb-4dc0-b06a-08dc48c8def7
X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB6896.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2024 10:31:15.5167
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qQofdM3H0aB/nbltQfmo53iud2nCyOjQ6Q9/sUL9LM1vDhBIU82p5WDtq3aYp/IB8YPZza+DZIFBreXkKBM3kdIyaLV+4psZ6xfjNpCBk0A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS8PR03MB8961

Hi Krzysztof,
     Thanks for your reply.

On 2024/3/20 17:48, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
> 
> On 20/03/2024 10:44, Xianwei Zhao via B4 Relay wrote:
>> From: Xianwei Zhao <xianwei.zhao@amlogic.com>
>>
>> Amlogic A5 is an application processor designed for smart audio
>> and IoT applications.
>>
>> Add basic support for the A5 based Amlogic AV400 board, which describes
>> the following components: CPU, GIC, IRQ, Timer and UART.
>> These are capable of booting up into the serial console.
>>
>> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
>> ---
>>   arch/arm64/boot/dts/amlogic/Makefile               |  1 +
>>   .../boot/dts/amlogic/amlogic-a5-a113x2-av400.dts   | 42 ++++++++++++++++++++++
>>   arch/arm64/boot/dts/amlogic/amlogic-a5.dtsi        | 40 +++++++++++++++++++++
>>   3 files changed, 83 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
>> index 9a50ec11bb8d..154c9efb26e4 100644
>> --- a/arch/arm64/boot/dts/amlogic/Makefile
>> +++ b/arch/arm64/boot/dts/amlogic/Makefile
>> @@ -1,5 +1,6 @@
>>   # SPDX-License-Identifier: GPL-2.0
>>   dtb-$(CONFIG_ARCH_MESON) += amlogic-a4-a113l2-ba400.dtb
>> +dtb-$(CONFIG_ARCH_MESON) += amlogic-a5-a113x2-av400.dtb
>>   dtb-$(CONFIG_ARCH_MESON) += amlogic-c3-c302x-aw409.dtb
>>   dtb-$(CONFIG_ARCH_MESON) += amlogic-t7-a311d2-an400.dtb
>>   dtb-$(CONFIG_ARCH_MESON) += amlogic-t7-a311d2-khadas-vim4.dtb
>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-a5-a113x2-av400.dts b/arch/arm64/boot/dts/amlogic/amlogic-a5-a113x2-av400.dts
>> new file mode 100644
>> index 000000000000..2f5f5ea74bc9
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-a5-a113x2-av400.dts
>> @@ -0,0 +1,42 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +/*
>> + * Copyright (c) 2024 Amlogic, Inc. All rights reserved.
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "amlogic-a5.dtsi"
>> +
>> +/ {
>> +     model = "Amlogic A113X2 av400 Development Board";
>> +     compatible = "amlogic,av400","amlogic,a5";
> 
> Please fix missing space in all your patches.
> 
Will fix.
> 
> 
> Best regards,
> Krzysztof
>