Received-SPF: pass (google.com: domain of linux-kernel+bounces-108820-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Biju Das <biju.das.jz@bp.renesas.com>
To: Claudiu.Beznea <claudiu.beznea@tuxon.dev>, "geert+renesas@glider.be"
	<geert+renesas@glider.be>, "linus.walleij@linaro.org"
	<linus.walleij@linaro.org>, "tglx@linutronix.de" <tglx@linutronix.de>
CC: "linux-renesas-soc@vger.kernel.org" <linux-renesas-soc@vger.kernel.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Claudiu.Beznea
	<claudiu.beznea@tuxon.dev>, Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: RE: [PATCH v3 2/2] pinctrl: renesas: rzg2l: Configure the interrupt
 type on resume
Thread-Topic: [PATCH v3 2/2] pinctrl: renesas: rzg2l: Configure the interrupt
 type on resume
Thread-Index: AQHaerN1t0zmC78ia0+OQ9W2eqNy9bFAd/ZQ
Date: Wed, 20 Mar 2024 11:08:38 +0000
Message-ID:
 <OSAPR01MB158778802C8AAF3F9230259286332@OSAPR01MB1587.jpnprd01.prod.outlook.com>
References: <20240320104230.446400-1-claudiu.beznea.uj@bp.renesas.com>
 <20240320104230.446400-3-claudiu.beznea.uj@bp.renesas.com>
In-Reply-To: <20240320104230.446400-3-claudiu.beznea.uj@bp.renesas.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?Zp4ZqC50Qarv3BFO8Y/r6PFhKJflVhXUYK4erg3z/9nehJMi6q7Je/BDO5+w?=
 =?us-ascii?Q?EftNHz2fFan3O+m047ifnHPujHZa6RGSiHdMW2E6sIkQSoeQmYz4s7aTKV24?=
 =?us-ascii?Q?av0Pzt72jqIc+64MAOTpYg2zPdwTAMtC7QIwpP4jQdXXG1EpWitH2qEx5jNP?=
 =?us-ascii?Q?cezfDK16YiASef5aj9HYOXKV+0aT0F+R91+1xIlM2qOgGNUieQKhgmXgZwhS?=
 =?us-ascii?Q?LhtUPsOwL23cRUROvfm6dnqH6NV4v+2ffIAQUQmPfjTUGx1jjb0zo4s0RszS?=
 =?us-ascii?Q?rSU2k/41CEMB7/+zoZHlQv7sjVKQbz020fZRoYCZnlnEQE9wDYcb5CqjSQOb?=
 =?us-ascii?Q?XlvyoUdKCLtout4l4X51ALHw35Auistg23jyEJrjcaI1FRB/VCawTmXz9L8x?=
 =?us-ascii?Q?XWb6gsOsaoYq5la/8qplXybPKvhPaH39miSsT3eOXLSjfCByxCNd0ptTnThT?=
 =?us-ascii?Q?ht2YSsuP/CzwlKutmggPICIqMrotXRI1Awk6CZLakyqjs8IcGV7U7+eMgeIg?=
 =?us-ascii?Q?pC57DF19U6nvq7NsNrnGinUiHKJdbpXvabyxXpAlKiNEmKvXQgB+C3mRTeuH?=
 =?us-ascii?Q?wxKOu2V/yFzzoDokY+Ak2z4kaWAsd9Q2PNCUuS0UiqDrkUfaD+prec3E++cU?=
 =?us-ascii?Q?Y+wkOEsth/GE66GzOT5DWHvHwP3i95CR8buKSnZWO7guVCuYwFAIoNfy8xE3?=
 =?us-ascii?Q?v3wf0rD6HvPqzEaSoA6BWfYDcUXhzToiAOBtsrrRad9C6vqAUpNWcjN++gCt?=
 =?us-ascii?Q?sg2q4UZG5SwqeExmrZ15wVSGG2iKxGeyPXGfQj1AX6GNoFDKnd9MsjfJs9bE?=
 =?us-ascii?Q?y3QqcxzmRYor3myVrVCUgbxm2EMw4LEWI3mX5lmpssxa4Z0OjoplD/41UTGL?=
 =?us-ascii?Q?OM0uRl68Orw8l10UhaV5KLxlQQOkOQpD1uJlhPRiO7R/0PPdqM/Ert73o0po?=
 =?us-ascii?Q?5Ds5tzujSaBCqc6MHy/HBvkW2z0HdbPWJDpQafMB0RcKAzNUtojnd3HteJbz?=
 =?us-ascii?Q?+q5F89GY4r40oRrFunT4EMTEJAfVXYngcUqmLwWVgt4RPFHfNIE4+R497p01?=
 =?us-ascii?Q?hiMy+/m8bQwe5UW9HLb7DucUFl2x7rNNEgtLo2kg2z3hBcIgpUDKfvr0ONgU?=
 =?us-ascii?Q?cz/UIpRZpuf3f9o7R2l99kumSwnyW0VCC8oxhOcaUeUh7QDQQslWPvOT4pez?=
 =?us-ascii?Q?6fxyrLUbbgLZ5wRiGWDb9jZHlKONTZ4NpyqoaLlWg6rr/ZbAFJO0Wua78is5?=
 =?us-ascii?Q?egPn3bdv7aVxAcRkEUYYgdNijYURrgAlQEowKuL16/54TkoUzWWvdgFLWjXl?=
 =?us-ascii?Q?yLt/sps6wQNRpdjlySdfG8Jx4i1i6S51X8R/zH5GoWmEtZjD4B4nGaeOghf9?=
 =?us-ascii?Q?byRJ/9NDfKk1sgi0qLEUTG1+5mT1zSB1qcm8gG+HgBreF4HQwiGDBb+qUxw9?=
 =?us-ascii?Q?+/s3O1J/pMYQ8YJGKotaKSfx/YA3YqSIJExmEjMJ+5vWh+IJkgKYYmhAPhr9?=
 =?us-ascii?Q?jRk9ypAoSd6NelT1nLg6L+GUwl+ElhXcS9BfEu1FyocHubGuc7sTrvYZl+B0?=
 =?us-ascii?Q?39PDQKs5gtMmUF5fxF3+KaMgXlBSg/hEEwCZOWUYNFE2kuGgYH+JcxmVYTe5?=
 =?us-ascii?Q?GQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OSAPR01MB1587.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bba50b02-c10f-4264-299c-08dc48ce1849
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Mar 2024 11:08:38.7070
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Mq+IRZ8vMJ9hG9dhghj/q/7ydAaisTJwG1oQqfkNlCFb+pCIhtXDbnOFzfNbWhyRCuCDclPj9exqfxRlQ8KAZwRi3iekSItz/2/DwcX2WJU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWPR01MB8284

Hi Claudiu,

> -----Original Message-----
> From: Claudiu <claudiu.beznea@tuxon.dev>
> Sent: Wednesday, March 20, 2024 10:43 AM
> Subject: [PATCH v3 2/2] pinctrl: renesas: rzg2l: Configure the interrupt =
type on resume
>=20
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>=20
> Commit dce0919c83c3 ("irqchip/renesas-rzg2l: Do not set TIEN and TINT sou=
rce at the same time") removed
> the setup of TINT from rzg2l_irqc_irq_enable(). To address the spourious =
interrupt issue the setup of
> TINT has been moved in rzg2l_tint_set_edge() though rzg2l_disable_tint_an=
d_set_tint_source(). With
> this, the interrupts are not properly re-configured after a suspend-to-RA=
M cycle. To address this issue
> and avoid spurious interrupts while resumming set the interrupt type befo=
re enabling it.

Just a question,

Previously you don't save/restore irq_type() register during suspend/resume=
()??
After STR, any way we will lose that information.

Cheers,
Biju


>=20
> Fixes: dce0919c83c3 ("irqchip/renesas-rzg2l: Do not set TIEN and TINT sou=
rce at the same time")
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> ---
>  drivers/pinctrl/renesas/pinctrl-rzg2l.c | 22 ++++++++++++----------
>  1 file changed, 12 insertions(+), 10 deletions(-)
>=20
> diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/re=
nesas/pinctrl-rzg2l.c
> index 93916553bcc7..4fee3b0e6c5e 100644
> --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> @@ -2045,7 +2045,9 @@ static void rzg2l_gpio_irq_restore(struct rzg2l_pin=
ctrl *pctrl)
>=20
>  	for (unsigned int i =3D 0; i < RZG2L_TINT_MAX_INTERRUPT; i++) {
>  		struct irq_data *data;
> +		unsigned long flags;
>  		unsigned int virq;
> +		int ret;
>=20
>  		if (!pctrl->hwirq[i])
>  			continue;
> @@ -2063,17 +2065,17 @@ static void rzg2l_gpio_irq_restore(struct rzg2l_p=
inctrl *pctrl)
>  			continue;
>  		}
>=20
> -		if (!irqd_irq_disabled(data)) {
> -			unsigned long flags;
> -
> -			/*
> -			 * This has to be atomically executed to protect against a concurrent
> -			 * interrupt.
> -			 */
> -			raw_spin_lock_irqsave(&pctrl->lock.rlock, flags);
> +		/*
> +		 * This has to be atomically executed to protect against a concurrent
> +		 * interrupt.
> +		 */
> +		raw_spin_lock_irqsave(&pctrl->lock.rlock, flags);
> +		ret =3D rzg2l_gpio_irq_set_type(data, irqd_get_trigger_type(data));
> +		if (ret)
> +			dev_crit(pctrl->dev, "Failed to set IRQ type for virq=3D%u\n", virq);
> +		else if (!irqd_irq_disabled(data))
>  			rzg2l_gpio_irq_enable(data);
> -			raw_spin_unlock_irqrestore(&pctrl->lock.rlock, flags);
> -		}
> +		raw_spin_unlock_irqrestore(&pctrl->lock.rlock, flags);
>  	}
>  }
>=20
> --
> 2.39.2