Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp1442115lqt; Wed, 20 Mar 2024 04:24:15 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW8dc9qjD9PnKU61RAjX3gyjfxvuu3y4Ky1Pv/IUXcbsR0oPX4FRy+MlMnaPiVZXAdM+gU4enUomiRRsQg9/34I7mDEOvZtWqRka7PTCQ== X-Google-Smtp-Source: AGHT+IGuy16r9s836fuD94GTMsw87zUkCt4w3FEj5mgPpRPbdJox0YDbueF05AH6R0H5SYZwas+p X-Received: by 2002:ac8:7d81:0:b0:430:a286:38cd with SMTP id c1-20020ac87d81000000b00430a28638cdmr4776857qtd.35.1710933855065; Wed, 20 Mar 2024 04:24:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710933855; cv=pass; d=google.com; s=arc-20160816; b=bKHDlw7EIeFkq/Evo6IG9D4OvnrpmbXgQgNJyPSiYFEdTtJ37mw3LShX2bNgqIlDJb pEv8Yu11i2+wjoTbN4N0B27JqFBiaG9nHIoanDb2OxRORbEwuZLpqUMDyzSmYB0e4Wwj f1kMilbF7DM07pJRTE7x2gRyINnEGD8P3NyJqjO3jOKTyx24WAlecC1sBVTRIf7gqs6F eiaFJWFWS74lxccsjY+3uWWVMnMpSyzvF2ohguGQxDR9pTca6Eq9TDwMxUfxQQyibs5T EugmoyltKVh6lPVk5+fz/+GWF5QXeF6aVqG4RKD3Nglo1K/SXu/5S9p2I9yh+fRP2XVy gI/Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:references:in-reply-to:subject:cc:to:dkim-signature :dkim-signature:from; bh=aTym/nC5xD61zbRK5hpctTKsJawMwlPvb8OVQ2E/Od4=; fh=/VYd32wrMSDeBhkgwOysODQ4upytDi4R5dTyqCuuAVg=; b=U46FxKHxqvyf3M7ZXs2sFXJKp7XX8AA43AjTwpgBokkHKueGGxC6nsEdz+xBCVwqcd HsBJvkAROu+R/8vlxi+W3q+6+WJzQlYqjtWmUR18qauHjzi0eRC/BZWJUa38y5S04Vgx d/YzV4Ohauio8FY27RCBgbJelSD7ANIZW4upTK/FvOQM+DiXqbwzJ1H/mQp7foRsR5YY E75MDScpt9dkvWlxwaogCMbTBP7dkXMAcXp9oluLjZh/EnfBqO5rNV5hFhaUaM8zTx83 bvJgOKqFaFNAteDPNmm9VYRvdDMlF400vI8FgPDjWEVITc5A8bWrJ/q3JdM0d0Hj9/wg IdTg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=KvlwfhtK; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-108849-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-108849-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id j10-20020ac85c4a000000b0042ef5bdda3asi1918415qtj.374.2024.03.20.04.24.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Mar 2024 04:24:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-108849-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=KvlwfhtK; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-108849-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-108849-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id C564F1C2147C for ; Wed, 20 Mar 2024 11:24:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4404E3D993; Wed, 20 Mar 2024 11:23:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="KvlwfhtK"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="5S4OJ0Bq" Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EDD33FBA3; Wed, 20 Mar 2024 11:23:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710933821; cv=none; b=tVay2u5krvbJsmeUA6dhHKRbYOh14OEQyA3r4DM0FgFAsoKkSy659OlYqpyrdPHqsceC82JtpievKb1TUNbQwtcgjm8R9kLOIg/ish0d1WrOE47U44PUc6Rh4t7H8tQlIT4fls19cdRtVRhq28jfw+H55Ixef9xUngDg2QKLTCY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710933821; c=relaxed/simple; bh=0aPMYZqS1U/faF5yL5h5SYsSJK/wGQpWX/DtVL7hT4Y=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=sXScvIj/GXTYot5E0rwnK1//GGNen4NXtVfjoUeBbtbJGCSlddf806uGx+rh5Id53tfVc+/N7ys+3vc87SM9PuBCGkHjsgGIoCkbrjE7NW9T4/NN7zLqRFrvuv7FML23YIY0XvvoKZl7auninnsBrVsoJdwxbYwFvMuVxqIKIYU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=KvlwfhtK; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=5S4OJ0Bq; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1710933818; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aTym/nC5xD61zbRK5hpctTKsJawMwlPvb8OVQ2E/Od4=; b=KvlwfhtKxgD4GRV4La6sGDGFZr+2/2uQrcTfqM3vprppbQRBkL/TLG6IXU/hXtuEdKTRWU 8j62Nfc078Ao9H36UHuTIm9El2GoZ0LbJ4UnXyyIh2KtBC0/qwC14k1SmTqRP/f177mK7B DlIuApaSsLAFcCx09fnG5xqcxZf/lewP6w/aPQFYdFLQkKbMHzXVPSVQTwD4g380A5a0nR bohRu65iUTWfJXh2G9qDlxCeLHYbtn/1RxX6elSI50rVI25EjfOaq1jApa+jCL4PJS35ME 6FOW71TXq+emFfTlbaT2VVOyWI/HQuDjjudpJRADjjmMZ+Gw/YNJKYhb0SCrew== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1710933818; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aTym/nC5xD61zbRK5hpctTKsJawMwlPvb8OVQ2E/Od4=; b=5S4OJ0Bqq8GLmgf1t47z3Wr7Pn74Q0Z8hp6uTTCi/CglQBez4Y7PgP+9Y8m7R18/ZWh6QO 7N63F1Og9OVrh6Aw== To: lakshmi.sowjanya.d@intel.com, jstultz@google.com, giometti@enneenne.com, corbet@lwn.net, linux-kernel@vger.kernel.org Cc: x86@kernel.org, netdev@vger.kernel.org, linux-doc@vger.kernel.org, intel-wired-lan@lists.osuosl.org, andriy.shevchenko@linux.intel.com, eddie.dong@intel.com, christopher.s.hall@intel.com, jesse.brandeburg@intel.com, davem@davemloft.net, alexandre.torgue@foss.st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, perex@perex.cz, linux-sound@vger.kernel.org, anthony.l.nguyen@intel.com, peter.hilber@opensynergy.com, pandith.n@intel.com, mallikarjunappa.sangannavar@intel.com, subramanian.mohan@intel.com, basavaraj.goudar@intel.com, thejesh.reddy.t.r@intel.com, lakshmi.sowjanya.d@intel.com Subject: Re: [PATCH v5 01/11] x86/tsc: Add base clock properties in clocksource structure In-Reply-To: <20240319130547.4195-2-lakshmi.sowjanya.d@intel.com> References: <20240319130547.4195-1-lakshmi.sowjanya.d@intel.com> <20240319130547.4195-2-lakshmi.sowjanya.d@intel.com> Date: Wed, 20 Mar 2024 12:23:37 +0100 Message-ID: <875xxhi1ty.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Tue, Mar 19 2024 at 18:35, lakshmi.sowjanya.d@intel.com wrote: > From: Lakshmi Sowjanya D > > Add base clock hardware abstraction in clocksource structure. > > Add clocksource ID for x86 ART(Always Running Timer). This change log tells the WHAT but not the WHY. You have to add context and explanation WHY this change is required and why it makes sense. Also I think this should be ordered differently: 1) Add the clocksource_base struct and provide the infrastructure in get_device_system_crosststamp() 2) Make TSC/ART use it 3) Add the realtime muck Thanks, tglx