Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp1446149lqt; Wed, 20 Mar 2024 04:32:12 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW28/bA0GiBjn5JE6gAXRHXRKu5jJYpcW3T28twBBF+hobwDZVgqElr4AovQmYP8j3lW6yzeHWbTEtJjxEB37c2Y28IaeziTzhQ6nyZOg== X-Google-Smtp-Source: AGHT+IHfbsY9IzVg/c4sjFdxUJD4Sof/ZJS3/alYcr3aOD4kuLnOqmDfpFkoZgDbH/SaTO06q+ny X-Received: by 2002:a05:6a00:4648:b0:6e6:5343:c165 with SMTP id kp8-20020a056a00464800b006e65343c165mr1933985pfb.16.1710934332447; Wed, 20 Mar 2024 04:32:12 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710934332; cv=pass; d=google.com; s=arc-20160816; b=B/z9Mn96IMcbScde56nLL2hMLZHueshg3MFKWlcakuxzZ5AIKyqj0vW06fGooPgFKw qP8ERR79owxk0i5Vzcei+0Iv39rbnILhZBgia/VVoLNHj5OCJ1gQIS9FsWBPJcnhkA8u 5YUrYzxJEPE8nZo2qhISYzQisX9vRQpSZj8ynTJvfrvd0Dgx+R8huodOSg1Pv6dIB+dB D9QfZAk5HuuzTW7Huk4bPkHPDWcVsWeHasV4f5HPOIXVwARA5QLNQ108xm8f2epFBLgt CSfExmxPF311rbL4GfGZYwPqhc6usRJYk0uAgfEnnfqt9GFx8TkkcN0u3NlKDL+PBD5a KD5w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:references:in-reply-to:subject:cc:to:dkim-signature :dkim-signature:from; bh=pwE/GBJYLkV/7/yUUomeUZHide/jRSkFJUzETBE/thU=; fh=/VYd32wrMSDeBhkgwOysODQ4upytDi4R5dTyqCuuAVg=; b=CZnSQw+Bsnu+7nKhi6Ij+m+0zFlz4FoVUnO4gVQW1gd7YDQDPDCD/BcCCGdx3kPWyu 1qKAoBNILYUfKcCgRb4ZPkg+igE4DNTJ5C2qnkfQ1KBONLZZcZaOSDDOBAXRJWqDPEuj 1sxm5n9nPtA1HKg4R4fwL5SZzq2u3FFkPMRwlJA/vynTcMxy3MJK7qW1q/7I66pmSrVO 8bFuIMVtP67egRGtK5T9vY51p2Jk/r2mc8T5yN5RwCykYesl1d9EqSWL5Jr5IAE517Ih GCgUrFaxzwugGbJl7EQs4K0/UzM6jt55Gwy9/Gm+McdmY/jp2yANN+GamNUAtpkTlGHU 0/wQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=MET3jxyq; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b="KD+F/3vI"; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-108858-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-108858-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id y63-20020a62ce42000000b006e6880bdccbsi12983488pfg.388.2024.03.20.04.32.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Mar 2024 04:32:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-108858-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=MET3jxyq; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b="KD+F/3vI"; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-108858-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-108858-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 14FCEB22BAC for ; Wed, 20 Mar 2024 11:31:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6ECCD3E489; Wed, 20 Mar 2024 11:30:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="MET3jxyq"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="KD+F/3vI" Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2A7A3BBC8; Wed, 20 Mar 2024 11:30:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710934256; cv=none; b=dZtF/N88IPJDVE/cwljpyuWXFhn9maDRfKXwdLcZbFXMugA8RNkrv3GjLGLoIxHVfCIjAD4VCf1EerZ0dI2pN2Y3UDSfqKvluooT+x+hMu0xrcrG8dfhVYEglXzAqBG5GvJu+jaUM45GzXoFvM37Uozs2wdrUgl1hTQ2YIZ+PKU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710934256; c=relaxed/simple; bh=a8TOprEuyws5CRENEXE+KPayvt7+FUvQnptRl61id2g=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=VjzTdcXQDUf/yZItJ/KhFghpbxqzXP2DVzahW+5TDyS+cRg62pJJ3DtZxH+Tf8srnVKGqPb7M29i7PK2fLcuTqju5I1Sq0FQPJQAqTBLK1cYatoTn9ThlR2m6FKVfLMAD7pPKnL7yT3ChavhYBTgYR6tm3wX75UH8BkgGnErVy8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=MET3jxyq; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=KD+F/3vI; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1710934253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pwE/GBJYLkV/7/yUUomeUZHide/jRSkFJUzETBE/thU=; b=MET3jxyqm1sXOQn5gphkidNCjfG+Tr/p2/ki9n+/AqGfDi6uzTb2aT/MyL+ioOWks6ndHO MI95oCOA1zQP2cwvzPcoi7DRiq7z2zXhoQrgJCUxMxEHjz9x4uvFfD/XYPX3zBQTUr65XL lNTFECeMgVwWMspuPc3Omri78q9n2MBo8amNB3KLmOlgidIbjna0YRPG5+YXucDf8l0X6t Xe5iJoS5QZsKia9g+j3+SDVmp31i41KL3GoBs5cawaUNf+yvjjaPvcxueJEeMTUBz6dcYS q1ELLfg0R+vKzoni0nnLM5iim2DRcVOb6v7gUhRjGS7rNFMU1AXrXD/j6iMeew== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1710934253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pwE/GBJYLkV/7/yUUomeUZHide/jRSkFJUzETBE/thU=; b=KD+F/3vIh9T1cQ/PXywhSvE5rgPwIOfCSkG52QZ7ALq7BZCiJ1z2qhgQYCog3Dp3vC7iyf WkvevLWZUyLc3cCw== To: lakshmi.sowjanya.d@intel.com, jstultz@google.com, giometti@enneenne.com, corbet@lwn.net, linux-kernel@vger.kernel.org Cc: x86@kernel.org, netdev@vger.kernel.org, linux-doc@vger.kernel.org, intel-wired-lan@lists.osuosl.org, andriy.shevchenko@linux.intel.com, eddie.dong@intel.com, christopher.s.hall@intel.com, jesse.brandeburg@intel.com, davem@davemloft.net, alexandre.torgue@foss.st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, perex@perex.cz, linux-sound@vger.kernel.org, anthony.l.nguyen@intel.com, peter.hilber@opensynergy.com, pandith.n@intel.com, mallikarjunappa.sangannavar@intel.com, subramanian.mohan@intel.com, basavaraj.goudar@intel.com, thejesh.reddy.t.r@intel.com, lakshmi.sowjanya.d@intel.com Subject: Re: [PATCH v5 01/11] x86/tsc: Add base clock properties in clocksource structure In-Reply-To: <875xxhi1ty.ffs@tglx> References: <20240319130547.4195-1-lakshmi.sowjanya.d@intel.com> <20240319130547.4195-2-lakshmi.sowjanya.d@intel.com> <875xxhi1ty.ffs@tglx> Date: Wed, 20 Mar 2024 12:30:52 +0100 Message-ID: <87zfutgmxf.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed, Mar 20 2024 at 12:23, Thomas Gleixner wrote: > On Tue, Mar 19 2024 at 18:35, lakshmi.sowjanya.d@intel.com wrote: >> From: Lakshmi Sowjanya D >> >> Add base clock hardware abstraction in clocksource structure. >> >> Add clocksource ID for x86 ART(Always Running Timer). > > This change log tells the WHAT but not the WHY. You have to add context > and explanation WHY this change is required and why it makes sense. > > Also I think this should be ordered differently: > > 1) Add the clocksource_base struct and provide the infrastructure in > get_device_system_crosststamp() > > 2) Make TSC/ART use it 2a) Remove the art to tsc conversion in drivers 2b) Remove art to tsc > 3) Add the realtime muck > > Thanks, > > tglx