Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp1448033lqt; Wed, 20 Mar 2024 04:35:52 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW1/HGUv4WKmsDoE6aDjODDWSo0v+SsTw5c9fwhY6XXhacyR6IkKjcme/3VUV9jCbL8Sed9i905aIqe0SvqrMCNPIetW46tll09iOVong== X-Google-Smtp-Source: AGHT+IHpSPRRi6xcsY1IkjoiQXQdBB/vr7xP3zJfY6KOo3j5PjBoTpTkC/WbDFOWtDsf90YUcmGR X-Received: by 2002:a05:6a20:9189:b0:1a3:81dd:2e7c with SMTP id v9-20020a056a20918900b001a381dd2e7cmr2374965pzd.43.1710934552544; Wed, 20 Mar 2024 04:35:52 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710934552; cv=pass; d=google.com; s=arc-20160816; b=rURI466wGiUdqqjYikVOAalKySn4lZ4A6X2Jv+ileDGCXvNk6zUmcLNOWxDLt2pQlD aWzDA5hPwIuR9rON9JfwimBY2rM6ytw6ZlblMwwvhW9BzUOSgQK4C50iZLpZQtw0llND Vkim4wfRKywNRzhCRIBEDYhMwK+b2yXBEcQcLcZ+ejBMNQGADi1LCBFm9TaXnDS9/coU HlnIMMrZQSqKQZwnwu2OcSmj1H9xwapMuZv7+V+UcoRbNcenN+F6LMLqn1hkLHTfLDW/ zxiVxncV4U9qAiCOSaaSpdemfGZHAkK2NVG0aRs8g1d+Y9EQQnh/2RjEmR1jFLgNg48g CPfQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=WxTD2hB5MDacVjwhAlli2Ecjh1dJfTB2r6xn0IlYg78=; fh=PE/3I9ChJY1m3kdfUTcekVbCnMB3VJlXmy4b9ZIE4kY=; b=r4MIY4jCFP63JoSRhHxGMXQsme9nQg6BtAy53qYIT2WXOQn+EZ3V2vvvzYBVnRncwa OYHhhC1IHNmQ9RmDBJYkX7foZG1bOv2f+BhAKlqVq8H1JWN5GqjFApsDfkUqARPlwCHH cjPTGD7rH5Fy1AsUNBAd8GaCtNCpXC17l4vtPpeZyAyMn187KAKcxbEy3imYwW6qgU+2 yk4pOOS4riPK92wift6k0qe9Pw4vk00tB7MJKFOTUjNnaeuW/U6+qDMEOg0pvb2sg0mV 1BS5ty79tes7eGlG48FCwop0GZCAyuxmFjI/mk7dknIDRnNHBqWHzpaZM+ufhGtNwd0i RRog==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="LOk2N/pR"; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-108866-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-108866-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id v15-20020aa799cf000000b006e6ac8fd9dcsi12882129pfi.288.2024.03.20.04.35.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Mar 2024 04:35:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-108866-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="LOk2N/pR"; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-108866-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-108866-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 33B47282DCD for ; Wed, 20 Mar 2024 11:35:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 37AD63F8F6; Wed, 20 Mar 2024 11:35:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LOk2N/pR" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A147F3DB8C for ; Wed, 20 Mar 2024 11:35:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710934540; cv=none; b=tdYq5bHGT9ubHVwSGykOIxvkvhJgB2xohn6zauwuYSsxc8hQlpjQjvTBCdTaSy3EA62Oo49/Z5uMBb36P5cbv+y/Nm/MAlrdMfvVaT2q5MhFaGlSGgdNyqGWR1ZjhLkyXj/xZm3STnUYDtgc9/uxiLL9OiEjCCLeE63UFx5u+7Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710934540; c=relaxed/simple; bh=SLiFCfY4b3lVXzFCGGs9sIbiGRlF4bB6wOUpWVI6vOQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=a+z/9wKt5GjZH6Dq7yOzhbQBlJiZjUYOuOQ28Q3+Z2RU4B/E+gGKqtNP5AfnPLLXi4VRi99Y4TBYiauJq33Wq5BcVIIygwx6irvp1/baappfC7wAnZpPTSf9+qltVTdvr7zlSYkYIQLX+z+EQI+GTEQBO0hxZRK9eiJHjJipPic= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LOk2N/pR; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710934537; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=WxTD2hB5MDacVjwhAlli2Ecjh1dJfTB2r6xn0IlYg78=; b=LOk2N/pRG60IaQgbVf+aChN6C4QvaU3b2ruIHUUZow9XoDG2+3BKFcdrWGA56Rj9PXMggt ZkSfbA3w29iIbsAhWkNHnKmLIFioUVvIrNetg9SXFK5ju1m9WjJFhedwZ4iYsvWfj2Yy3L 6yuu8L5c/z4am45qy5A+B78sLRMr4+0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-252-hLIZTTRDMKOWqYcANj_6Dg-1; Wed, 20 Mar 2024 07:35:35 -0400 X-MC-Unique: hLIZTTRDMKOWqYcANj_6Dg-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4140f58ac00so18776825e9.3 for ; Wed, 20 Mar 2024 04:35:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710934534; x=1711539334; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WxTD2hB5MDacVjwhAlli2Ecjh1dJfTB2r6xn0IlYg78=; b=wcz7DOOk/WK1VSkTEcBwbuhQHzKPOqaQE9F61tI0OP95rT+WuOk/CCpcYSNtMtW9WE qQ7AMF6So5cGsMjEkjYSOTg2kz5ijtryKz76wsBN0QSC8kcOSSDON3HD0M526vRSuB/v 2LAs6nf7J/NTGgRip9So5vkYY9lo2OpjLFfUx5wUQ6wWJ29EciIJGmWBsYwYEdlLHkaX Qu2Pp+iNr13D0o8M7PMk62JafZMfF5b4e+lYRadYvak8K9yxH95x+HspaLA3shoxQMBp MNEQXEjWk6bNN3bL4/aknJTSvVzJgtnrHxAqRUbFmFnHNOzzPMZj/eN8QDmGlyhZYAqM 4enA== X-Gm-Message-State: AOJu0YyVMArQ9q5CkbTOD+c9l8UsuBlWHgIttYmWghhrj7yrtI5aXjnJ y9Ifb3My8GWuWeg7VGKfY3zyfkxRJspkDFIlHSTMH1jE3A+3v8vaga/dFtnHTS4sgVAODYEYdFJ XwfPrce5qGafxY1Lmw3jwqDdOuJlPSQZmI2je9iCwj7qY+/t7V61rP+JfarRkzQ== X-Received: by 2002:a05:600c:16d3:b0:414:a75:7457 with SMTP id l19-20020a05600c16d300b004140a757457mr4053437wmn.10.1710934534420; Wed, 20 Mar 2024 04:35:34 -0700 (PDT) X-Received: by 2002:a05:600c:16d3:b0:414:a75:7457 with SMTP id l19-20020a05600c16d300b004140a757457mr4053418wmn.10.1710934534036; Wed, 20 Mar 2024 04:35:34 -0700 (PDT) Received: from ?IPV6:2003:cb:c709:c400:9a2:3872:9372:fbc? (p200300cbc709c40009a2387293720fbc.dip0.t-ipconnect.de. [2003:cb:c709:c400:9a2:3872:9372:fbc]) by smtp.gmail.com with ESMTPSA id q14-20020a05600c46ce00b004140a757256sm1962413wmo.31.2024.03.20.04.35.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Mar 2024 04:35:33 -0700 (PDT) Message-ID: Date: Wed, 20 Mar 2024 12:35:32 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] KVM: s390: vsie: Use virt_to_phys for facility control block Content-Language: en-US To: Nina Schoetterl-Glausch , Alexander Gordeev , Claudio Imbrenda , Christian Borntraeger , Vasily Gorbik , Janosch Frank , Heiko Carstens Cc: linux-kernel@vger.kernel.org, Sven Schnelle , kvm@vger.kernel.org, linux-s390@vger.kernel.org References: <20240319164420.4053380-1-nsg@linux.ibm.com> <20240319164420.4053380-3-nsg@linux.ibm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240319164420.4053380-3-nsg@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 19.03.24 17:44, Nina Schoetterl-Glausch wrote: > In order for SIE to interpretively execute STFLE, it requires the real > or absolute address of a facility-list control block. > Before writing the location into the shadow SIE control block, convert > it from a virtual address. > We currently do not run into this bug because the lower 31 bits are the > same for virtual and physical addresses. So it's not a bug (yet) :) But certainly the right thing to do and more future-proof. Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb