Received-SPF: pass (google.com: domain of linux-kernel+bounces-108867-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Wed, 20 Mar 2024 13:36:58 +0200 (EET)
To: "Luke D. Jones" <luke@ljones.dev>
cc: Hans de Goede <hdegoede@redhat.com>, corentin.chary@gmail.com, 
    platform-driver-x86@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] platform/x86: asus-wmi: add support variant of
 TUF RGB
In-Reply-To: <20240320011442.11608-2-luke@ljones.dev>
Message-ID: <5d5e8895-8843-a0bf-de97-b293528a0643@linux.intel.com>
References: <20240320011442.11608-1-luke@ljones.dev> <20240320011442.11608-2-luke@ljones.dev>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323328-523568904-1710934361=:1037"
Content-ID: <9d3e5125-d4d9-6974-9847-0c4bdb5ed5e1@linux.intel.com>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-523568904-1710934361=:1037
Content-Type: text/plain; CHARSET=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE
Content-ID: <a1a754a9-a482-e651-1732-b988a89a7b45@linux.intel.com>

On Wed, 20 Mar 2024, Luke D. Jones wrote:

> Adds support for a second TUF RGB wmi call that some versions of the TUF
> laptop come with. Also adjusts existing support to select whichever is
> available.
>=20
> Signed-off-by: Luke D. Jones <luke@ljones.dev>
> ---
>  drivers/platform/x86/asus-wmi.c            | 13 +++++++++++--
>  include/linux/platform_data/x86/asus-wmi.h |  1 +
>  2 files changed, 12 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-=
wmi.c
> index b9a2fb8007c0..0d8a2b82cc06 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c

> @@ -4544,6 +4545,14 @@ static int asus_wmi_add(struct platform_device *pd=
ev)
>  =09=09asus->gpu_mux_dev =3D ASUS_WMI_DEVID_GPU_MUX_VIVO;
>  =09}
> =20
> +=09if (asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_TUF_RGB_MODE)) {

The patch itself is fine,

Reviewed-by: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>

However,

There's a major problem in the way you're submitting these. This patch is=
=20
built on top of the GPU_MUX_VIVO patch as can be seen from the context
above. Yet, you're sending these independently instead of series. I=20
suspect there are other similar problems among these patches that there's=
=20
hidden dependency order in which these should be applied. This will cause=
=20
problems if maintainer applies the patches in wrong order (they may even=20
misapply with fuzz).

Only if the patches are truly independent, that is, focus on solving=20
entirely differently thing (functional independency) and do not have any=20
linewise conflicts (code locality independecy) either, it's fine to send=20
patches as independent ones without making a series out of them. But=20
clearly it's not the case here.

--=20
 i.
--8323328-523568904-1710934361=:1037--