Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp1550355lqt; Wed, 20 Mar 2024 07:21:45 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVbrvhXd2HJGqCEd9MFZNiYze9cQJEJlJYonD39eIgePH+SQ4+RFV2853G12HvUIb4gUDv8qjy6zA4DNlyyoydMUIEMnqhUhj6gjy02eg== X-Google-Smtp-Source: AGHT+IEkmZ/4Wu00xvMrCySzrjfseK9gQAXnxOrlcDn37Nv8FQn/wFG7s0lgAx7h2tUJxnDV/PoV X-Received: by 2002:a0c:d804:0:b0:691:736c:86eb with SMTP id h4-20020a0cd804000000b00691736c86ebmr2150234qvj.26.1710944505015; Wed, 20 Mar 2024 07:21:45 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710944505; cv=pass; d=google.com; s=arc-20160816; b=reuW9QW7VEsfvitulop8BWQ9BtOcA/aRpyELKwJ9aqUb698qibR48NyKjzCfRlo+Pc TYIput6rcIkjR0QtttTh0fvcSmjix/6en46w3m66hxpVV6cxfP4n4T0PlRgbl4K4ANHl dWDoma/XTbq24f89Rj57sCPuPia/qZWA5pOXQ9g3kJj6iyDU/xeggW1TchbmarNrjVnE h64EpCrVtL0dWJteL1zMlpWb0yL8EhviXIeTtl5ggTxSonhNudbI4L6h7HE3dZh9qB61 f7Gh7WJNNZEASs596LVFUPNEpwRCVeqkQtBHwKnCxKngc0M8DyscOI7E3J36pN8xECFU mHTA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id; bh=sS6ZcYxNWvp78s1cP9mGaiOSeT6AChxv2PewOuoBVKg=; fh=EatWRA+kWOkGGma4xICrb5bPxHeCxy/gAUSouUxAN9A=; b=yuFHN/BhArWjKESOtAuQXjdEgPniuq8y8IVNXSFJFXFiBLO2qXcuu3cfwYLlNF0aOL NBfz8GzK4dndJOeoZLGUbfVB0JvWx+4pvX+DMUAcquugt6OUWKFVvamunAPbGbgq8PBY almh8JIh3nT5sCeLRdv9ygZ85eUkEhjLDGZPU/ohT7qHLDD+EyOINgXbFl1hxCplAhGP t8V41u07zzANomxnLgbz+HWiKTkw52zqyoSqwrGWApXuRmsuBK7XCfUV0NZ9AjtaEGxD uoPP04xAlDsbh64hIN8be+HP4YhIqmR7/3zdH790cxSRpaZzNppjwEj1CEyZnqM+4eNQ WK6Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-109003-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-109003-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id gv1-20020a056214262100b0068f44562bbasi13172888qvb.167.2024.03.20.07.21.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Mar 2024 07:21:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-109003-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-109003-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-109003-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id BB9D31C2265B for ; Wed, 20 Mar 2024 14:21:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3D4E84436E; Wed, 20 Mar 2024 14:21:40 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 633772628D for ; Wed, 20 Mar 2024 14:21:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710944499; cv=none; b=EO8Cy6weQMMeVq5cnx0ukmTCAfKb9CUvso3bjbPaw8CbGesj3D3EPaW2OS6t3gOSCQdA2/X6Xw9B5jK/1tL6Eb2XHo0IkorNn57AGxL4hcEUf5adVmCQK9rkwwRWKbclte7GqXN4rRfw709qGakNlMX31LLflmYtVuu6o360e80= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710944499; c=relaxed/simple; bh=sgvltgyVNo1Z71NR9F+7UwUoanVixUUJz+AVAcpQcU0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sEX9EmrXFphOvpDkqOZ5/WCyD7wyj2C6VkPOeSJU0zMb7UdEWx4sxEiKFz33rHdEKjzvvpmBfwl+JhWh4WdlIIEMypNUioKhUioL0EQi6Nfel/RADTLXVe6hoiTvKQfXcBhDmhDrLkrWJi2f9ITugmBGjbrm4SuiF2ETGeqhgUM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3D9401007; Wed, 20 Mar 2024 07:22:12 -0700 (PDT) Received: from [10.57.72.78] (unknown [10.57.72.78]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8029F3F64C; Wed, 20 Mar 2024 07:21:35 -0700 (PDT) Message-ID: Date: Wed, 20 Mar 2024 14:21:33 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/6] mm: swap: free_swap_and_cache_nr() as batched free_swap_and_cache() Content-Language: en-GB To: David Hildenbrand , Andrew Morton , Matthew Wilcox , Huang Ying , Gao Xiang , Yu Zhao , Yang Shi , Michal Hocko , Kefeng Wang , Barry Song <21cnbao@gmail.com>, Chris Li Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240311150058.1122862-1-ryan.roberts@arm.com> <20240311150058.1122862-3-ryan.roberts@arm.com> <42ae8cdf-2352-4bb9-9b22-aed92a2c9930@arm.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 20/03/2024 14:13, David Hildenbrand wrote: > On 20.03.24 12:10, Ryan Roberts wrote: >> Hi David, > > I'm usually lazy with review during the merge window :P Ahh no worries! I'll send out the latest version next week, and can go from there. > >> >> I hate to chase, but since you provided feedback on a couple of the other >> patches in the series, I wondered if you missed this one? It's the one that does >> the batching of free_swap_and_cache(), which you suggested in order to prevent >> needlessly taking folio locks and refs. >> >> If you have any feedback, it would be appreciated, otherwise I'm planning to >> repost as-is next week (nobody else has posted comments against this patch >> either) as part of the updated series. > > On my TODO list! >