Received-SPF: pass (google.com: domain of linux-kernel+bounces-109010-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <beb746c7538a4ff720a25fd8f309da20d8d854ef.1710933713.git.geert@linux-m68k.org>
 <47bddec7-953d-4ea4-84f1-b0dcf0641baa@sifive.com>
In-Reply-To: <47bddec7-953d-4ea4-84f1-b0dcf0641baa@sifive.com>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Wed, 20 Mar 2024 15:28:37 +0100
Message-ID: <CAMuHMdWP4R6Y6G0qzhMKJy1zJEeHE8a0XEK+Hs_D4wXB2i2BFA@mail.gmail.com>
Subject: Re: [PATCH v2] clk: starfive: jh7100: Use clk_hw for external input clocks
To: Samuel Holland <samuel.holland@sifive.com>
Cc: linux-clk@vger.kernel.org, linux-riscv@lists.infradead.org, 
	linux-kernel@vger.kernel.org, Emil Renner Berthing <kernel@esmil.dk>, 
	Hal Feng <hal.feng@starfivetech.com>, Michael Turquette <mturquette@baylibre.com>, 
	Stephen Boyd <sboyd@kernel.org>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, 
	Conor Dooley <conor.dooley@microchip.com>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, 
	Andy Shevchenko <andy.shevchenko@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Samuel,

On Wed, Mar 20, 2024 at 2:31=E2=80=AFPM Samuel Holland
<samuel.holland@sifive.com> wrote:
> On 2024-03-20 6:24 AM, Geert Uytterhoeven wrote:
> > The Starfive JH7100 clock driver does not use the DT "clocks" property
> > to find the external main input clock, but instead relies on the name o=
f
> > the actual clock provider ("osc_sys").  This is fragile, and caused
> > breakage when sanitizing clock node names in DTS.
> >
> > Fix this by obtaining the external main input clock using
> > devm_clk_get(), and passing the returned clk_hw object to
> > devm_clk_hw_register_fixed_factor_parent_hw().
> >
> > While name-based look-up of the other external input clocks works as-is=
,
> > convert them to a similar clk_hw-based scheme to increase uniformity,
> > and to decrease the number of name-based look-ups.
> >
> > Fixes: f03606470886 ("riscv: dts: starfive: replace underscores in node=
 names")
> > Fixes: 4210be668a09ee20 ("clk: starfive: Add JH7100 clock generator dri=
ver")
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>


> > --- a/drivers/clk/starfive/clk-starfive-jh7100.c
> > +++ b/drivers/clk/starfive/clk-starfive-jh7100.c

> > @@ -284,8 +293,11 @@ static struct clk_hw *jh7100_clk_get(struct of_pha=
ndle_args *clkspec, void *data
> >
> >  static int __init clk_starfive_jh7100_probe(struct platform_device *pd=
ev)
> >  {
> > +     static const char *jh7100_ext_clk[EXT_NUM_CLKS] =3D
> > +             { "osc_sys", "osc_aud", "gmac_rmii_ref", "gmac_gr_mii_rxc=
lk" };
>
> This should be __initconst. Otherwise:

With

    -       static const char *jh7100_ext_clk[EXT_NUM_CLKS] =3D
    +       static const char *jh7100_ext_clk[EXT_NUM_CLKS] __initconst =3D

I get:

    drivers/clk/starfive/clk-starfive-jh7100.c: In function
=E2=80=98clk_starfive_jh7100_probe=E2=80=99:
    drivers/clk/starfive/clk-starfive-jh7100.c:35:37: error:
=E2=80=98jh7100_clk_data=E2=80=99 causes a section type conflict with =E2=
=80=98jh7100_ext_clk=E2=80=99
       35 | static const struct jh71x0_clk_data jh7100_clk_data[]
__initconst =3D {
          |                                     ^~~~~~~~~~~~~~~
    drivers/clk/starfive/clk-starfive-jh7100.c:296:28: note:
=E2=80=98jh7100_ext_clk=E2=80=99 was declared here
      296 |         static const char *jh7100_ext_clk[EXT_NUM_CLKS]
__initconst =3D
          |                            ^~~~~~~~~~~~~~

which is a bit strange...
What am I missing?

> Reviewed-by: Samuel Holland <samuel.holland@sifive.com>

Thanks!

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds