Received-SPF: pass (google.com: domain of linux-kernel+bounces-109011-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 20 Mar 2024 10:29:42 -0400
From: Frank Li <Frank.li@nxp.com>
To: Niklas Cassel <cassel@kernel.org>
Cc: mani@kernel.org, kw@linux.com, niklas.cassel@wdc.com,
	bhelgaas@google.com, gustavo.pimentel@synopsys.com,
	imx@lists.linux.dev, jdmason@kudzu.us, jingoohan1@gmail.com,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	lpieralisi@kernel.org, robh@kernel.org
Subject: Re: [PATCH v2 1/1] PCI: dwc: Fix index 0 incorrectly being
 interpreted as a free ATU slot
Message-ID: <Zfry1kaYgg2OBvQL@lizhi-Precision-Tower-5810>
References: <20240304224616.1238966-1-Frank.Li@nxp.com>
 <ZfGJUDoGnFXKBoG0@ryzen>
 <Zfqj-mvpG442eyt2@ryzen>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Zfqj-mvpG442eyt2@ryzen>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?SxkR1hEnemM6uR7tR1AcnL894jx+Y/xX66XsIBrhD/nydS3V+Omw5qTEhqXy?=
 =?us-ascii?Q?J3ZA1u3n0O445IUMX9GcQrLlV6Ic4M2In79Z7bB5Gvf6XU1oUDi6pdJRtHbU?=
 =?us-ascii?Q?M9gEuOM8P4WDAFf+W4VWJddrQPP7GWdWuP58qZDlxoxvPm4xtRYjOWGKdfRF?=
 =?us-ascii?Q?Fz3R573F0cv/JMoUDguq6fL3jc3lCDP/NKldPsQsGnSmglj2vrt7sPdFJJFU?=
 =?us-ascii?Q?FjGqE+0eV9ZfNVfpi1bo8s+kBTgxor2Q+x0qekH0rGIBzrt9Oi3JSSqjDc7N?=
 =?us-ascii?Q?b915CJ7Mu+akevOQbgmhJqR5+mHh/LYeWA6LdzGub1fp/T7DHldU+etB4jCp?=
 =?us-ascii?Q?DN1aZaJfy3qFQIl3XsfJnRqEqV+Q5NbALLKPEc7qwiiUwxDcIgTwm/h0/7cz?=
 =?us-ascii?Q?6MsleHJiLqNLLM6pFNJSWnFvHF3DtQ/ftxrDHbYzFFhBv7k5ea6u4UvJxTB5?=
 =?us-ascii?Q?UJ0Q4aMnNFnHWofQvai+pqLGhs4tKZ7MO+cSt1k7n4PTlos9aWT1Tr/+DD8p?=
 =?us-ascii?Q?tdONL1Sl8wTO9Uu+52EGFcDMQK/9HTCv97FRHjffRUFzSjgYag1q9v/YGGq7?=
 =?us-ascii?Q?JYb5Pkq5sEk1HSmi0p5a8cmor9gygBZcECWw6zlT18Ezjx6V2y5huFcVZrGe?=
 =?us-ascii?Q?5ZbAXlnLQxQPcLuUtKcSGLVQo2/UTykAh/tbIVX4wfwLe4yVjrPOFwf+l/to?=
 =?us-ascii?Q?fc2Ty+wW7IGaRH9EoDHfBKMgoCqlZgCkpzQ13NEYl9ILbt5v7sWEaNZ7bQL6?=
 =?us-ascii?Q?ymXThl+puGvCGb3QrfZNSogY1aFOET8LfdCLx4otMrXoZFDXzuCgt9FoO5ml?=
 =?us-ascii?Q?KbX5qkJ1ITeCu3lv5v1xqHGvG1ViBi7HiepOM6cBbiBSczsg402ssLYt7vFu?=
 =?us-ascii?Q?LcKiDLITdR8K0MVlaWA9aFBW928Vb198d53SreYwJychJuqoNVA7lknhmFKE?=
 =?us-ascii?Q?tii9r3gEXhxDUTMh1hyLg+HbL5ytP4dEQgPcBZs24+pxyEdOpfRdvmY9YYLi?=
 =?us-ascii?Q?ZxOoMzy4i8Y4BegEUNgyA91c13rXrIByoRG3eTfczbWRK1KF77EGdPVnZ6Sf?=
 =?us-ascii?Q?YK/pND8KKQ69UI2I15x1G+UO5AhmZbJqTd/m3o0CaNNXwKuF7Kt+j60D2qO2?=
 =?us-ascii?Q?vZcza139KhbA1puMLlSsiwKO+FCIykPZe4Mdb6w5tfzbO/rLSP61+R5BKXW5?=
 =?us-ascii?Q?srse4F0ZkwspXTvXRw+NwTpEe/ok+MI23cE75o8KjRqoeyozH1dxc7dY2Am3?=
 =?us-ascii?Q?YXB8YD4uti39iKzAlIn7QuP8/hcaiPV+2vd7LqbNA8a5LMDstSkWkSymWT3R?=
 =?us-ascii?Q?Y5FdTfal8YAzSvxD2b54ox/wVHELtlkz+TovY86nIL7s/nBXU+lEo/oKl1C2?=
 =?us-ascii?Q?I9KyiLmvQxvrV68LqcZKhb3StXvWrkSSLgyg4z54/VC/2rMjR4VkACKEzCdA?=
 =?us-ascii?Q?+iZkfaE/wVXrt4+Fyt9tWTeVDw3yeIqoUghsuMdypb5AkMjPORurMHCKFS3V?=
 =?us-ascii?Q?jlKoXD3a1Fa72l+ctFdHEAE1ET9uy3HHcNg1mFiE5oIiIFP+qQ6ZSYnUsJYL?=
 =?us-ascii?Q?ekvsOfBJhROQTWbuItKmOKaSggMrDzrHIESASTWt?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 09aec101-754d-4c2f-3adb-08dc48ea353f
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2024 14:29:53.3634
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ph0yRNbor3S5e9nY+7U7LWjdi9GWZjfGKFP5fd2O5jIMU0+ZsS/diayqjEsOMgCEJ40UMWHLv3oksTe2CdJXZA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8145

On Wed, Mar 20, 2024 at 09:53:14AM +0100, Niklas Cassel wrote:
> On Wed, Mar 13, 2024 at 12:09:04PM +0100, Niklas Cassel wrote:
> > On Mon, Mar 04, 2024 at 05:46:16PM -0500, Frank Li wrote:
> > > dw_pcie_ep_inbound_atu()
> > > {
> > > 	...
> > > 	if (!ep->bar_to_atu[bar])
> > > 		free_win = find_first_zero_bit(ep->ib_window_map, pci->num_ib_windows);
> > > 	else
> > > 		free_win = ep->bar_to_atu[bar];
> > > 	...
> > > }
> > > 
> > > The atu index 0 is valid case for atu number. The find_first_zero_bit()
> > > will return 6 when second time call into this function if atu is 0. Suppose
> > > it should use branch 'free_win = ep->bar_to_atu[bar]'.
> > > 
> > > Change 'bar_to_atu' to free_win + 1. Initialize bar_to_atu as 0 to indicate
> > > it have not allocate atu to the bar.
> > > 
> > > Reported-by: Niklas Cassel <Niklas.Cassel@wdc.com>
> > > Closes: https://lore.kernel.org/linux-pci/ZXt2A+Fusfz3luQV@x1-carbon/T/#u
> > > Fixes: 4284c88fff0e ("PCI: designware-ep: Allow pci_epc_set_bar() update inbound map address")
> > > Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> > 
> > Any chance of this fix being picked up?
> 
> Gentle ping.

Now it is v6.9 merge windows. You'd better ping two weeks after linus
create v6.9-rc1 tag.

Frank

> 
> 
> Kind regards,
> Niklas