Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp1563035lqt; Wed, 20 Mar 2024 07:42:30 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVl06Cz/xgiaZEa0fJg2CoVeydE6glEvpmPzkf04l8o/8US+74eafWk8ahaY2knBkUTx/i+IUPEXqvEOP/kDnlBPAtGjrMcr3hYVg3jJw== X-Google-Smtp-Source: AGHT+IFnY7xX4H2xuFe4RdK1N8L9DVz4ockRo6qNm5cacWReKqfHqWDsHlYc++T5KtN6IZ/SlCe6 X-Received: by 2002:ac8:5a01:0:b0:430:9edc:561b with SMTP id n1-20020ac85a01000000b004309edc561bmr19222572qta.4.1710945750426; Wed, 20 Mar 2024 07:42:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710945750; cv=pass; d=google.com; s=arc-20160816; b=kpFzbNKOLycGSOUXijAbtCZAqKDTM0ldT4weanMM8BSMe1k7iG8mE48lQ7b2pIArYH XjvyLrjKgjiyDjYvZzax54Pe0KCJ/bE8xQbw92C179Dz+lEKTqKSyHF3Le56RBcKh0fh BDOG0SslYzTSmKfyzYHOm+XSmw+JEynaOFrB8DO/Vmy/ug5PM0PCbFuMN/QM8XaM++/5 YY7Z0m7fYEmBc9To03pV0q3B0wdX7Zc3EdZqTqumEMH3ByeUzbsY6TAxvgP+3v/E+Gnp Sgl2Obz35C25a8jmJSHFNtbFkqkrkYAWZQe9bZCk/tUct7ebkl7Mnbi+/0d9tMe+cWZS KCDQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ldtaL6dr3FBef7J1+tcSWWF8M6OWTyGM94wEG+tKRUA=; fh=7xpM5ZAjsPd9IUfzgIKInhp7ro4TMEcwa4AFbZZX410=; b=K3yBA2ta5+gNDzD62rGslWuAKEABJqt2qOq1R/hwq3fg4Iv3Os2IKInIZ3WcV4rSYh RQI9BRyLLYOWYP/pATYnFlxJlVwc87QOr9ISrhiWeeonI/HK/MjljBQ7vVJm1SVVkOF1 VI3oUU/TdorBFPBfQpV1MHoCgs7X30cAHicDoGBgWQt00MDj877nQmRi70c7q9pbbO79 R0ruBg0y0kwBjqVeqnQoLN0fw6+XyPEowV/cP+xBqYx+3cBKNvfhB0suo7Npot++f1sa BRpGJo3IHu+1LHxf8hVWXG6BDDzQrl4+rMUtQ70mSI2gJFWd4Gie/lgs8bhPOffhoRU/ bDVg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gTIubWms; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-109025-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-109025-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id p5-20020a05622a00c500b00430d054878esi6897438qtw.802.2024.03.20.07.42.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Mar 2024 07:42:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-109025-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gTIubWms; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-109025-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-109025-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 2B2CD1C226C9 for ; Wed, 20 Mar 2024 14:42:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4FF8A481DD; Wed, 20 Mar 2024 14:42:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gTIubWms" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7752747F6B; Wed, 20 Mar 2024 14:42:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710945743; cv=none; b=Wtlqv/NjI3VjWbBg8FYPJeTov6Oq0f+6HTuY9pcHVBQC0gu4YPZCKQuvtZT8vcopfCtQ4y4ce0D4i9k4j84b1YLJoPo9UWopJjXZpTO0RhptGRDWG0pP7yMR90FUntqJA2CQ00p1Ib8qI2yjUtbtNPyvg8o3xTbNCLMpmNsMlVw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710945743; c=relaxed/simple; bh=ovUrCh8ivPKPBF6OH/SCopVigijIup+Lh212CGR0Tes=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=H9syWB3lwkKEHrQFmrU3KDEi0914n/jd5vS0VVDCGhEiVDKjKcRJxquWothb3HkD2Ju1cjBO25sc7zlI5znhULUBY9brSFGVZCxCqg0jiwVd7bPCINlwreZpQ6uJFzwDLW0a15SUgRygyhq1/G18v1OMCh8UizLsByTQuH2V92A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gTIubWms; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A31DBC433C7; Wed, 20 Mar 2024 14:42:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710945743; bh=ovUrCh8ivPKPBF6OH/SCopVigijIup+Lh212CGR0Tes=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gTIubWms1oa9XTtUMbASdKDkDuJOG3hO/dFuzHc1lwm7xOKQZqmAJ4zMHnUFC2N7B Uqf/SaCJY58qbKHlMNIdIq5BkV1cA1OsoGqkam4KX9YGQUxYere0uqgF7AlwxAvohb 3j42WcY4uTtPM4xfM49AEcSG5u2fFz8rirqJL7zHhfnRNZT9CwfC10S703ol+VyyN7 po7y1egF1ccmb+vism+STYHXlyn4NtNlqrKkUFeL02O//gQKLaMGIs8IpymRchRZOI LmLjv0CHiyAhyvkmGY2z+ayo1okcCxNQl54WI6mjGOopv7+IVeSJnJuu7gFqz6E1Ur KcGuLIX5dMQEw== Date: Wed, 20 Mar 2024 11:42:20 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: "Liang, Kan" , Peter Zijlstra , Ingo Molnar , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Yang Jihong , James Clark , Ravi Bangoria , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/6] Extra verbose/perf-list details Message-ID: References: <20240308001915.4060155-1-irogers@google.com> <89249fc5-6102-45d4-9345-5dd80d06e001@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Mar 19, 2024 at 06:01:35PM -0700, Ian Rogers wrote: > On Fri, Mar 8, 2024 at 8:34 AM Ian Rogers wrote: > > On Fri, Mar 8, 2024 at 7:39 AM Liang, Kan wrote: > >> On 2024-03-07 7:19 p.m., Ian Rogers wrote: > >> > Add more encoding detail and raw event details in perf list. Add PMU > >> > name and reverse lookup from config to event name to > >> > perf_event_attr_fprintf. This makes the verbose output easier to read, > >> > and the perf list information more specific. > >> > > >> > v3. Fix to reverse lookup to ensure or aliases are loaded and if > >> > getting the config value fails for an event/alias just continue to > >> > the next one. > >> > v2. Address feedback from Kan Liang, "Raw hardware event descriptor" > >> > becomes "Raw event descriptor" add assert to keep term numbers in > >> > sync, fix a commit message. > >> > > >> > Ian Rogers (6): > >> > perf list: Add tracepoint encoding to detailed output > >> > perf pmu: Drop "default_core" from alias names > >> > perf list: Allow wordwrap to wrap on commas > >> > perf list: Give more details about raw event encodings > >> > perf tools: Use pmus to describe type from attribute > >> > perf tools: Add/use PMU reverse lookup from config to name > >> > >> The patch series look good to me. > >> I verified it on a hybrid machine. The new format is the same as the > >> advertise. > >> > >> Tested-by: Kan Liang > > Ping. Thanks, applied to perf-tools-next, - Arnaldo