Received-SPF: pass (google.com: domain of linux-kernel+bounces-109062-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <75b91ed1-6b80-4e03-b586-0bd58e81aba0@acm.org>
Date: Wed, 20 Mar 2024 08:07:29 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] scsi: core: Make scsi_lib KUnit tests modular for real
Content-Language: en-US
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Mike Christie <michael.christie@oracle.com>,
 "James E . J . Bottomley" <jejb@linux.ibm.com>,
 "Martin K . Petersen" <martin.petersen@oracle.com>,
 Lukas Bulwahn <lukas.bulwahn@gmail.com>, linux-scsi@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <48ca5e827ca420bbdbabb1643e2179dc95c9e0b7.1710849638.git.geert@linux-m68k.org>
 <d1a1b0b8-41f1-4ead-b393-d8d2f099b0c4@acm.org>
 <CAMuHMdWzD1OR8qj8oHfUgQ9GMtrD8y69G+A+ONdVm0vTCvYe=w@mail.gmail.com>
 <0d41ae1a-f6aa-4377-b8a3-7fcf067f99ac@acm.org>
 <CAMuHMdVig-cm7KPi76ow9-xyZ55z4YgYrx6QuO9V5A0ni7HxDA@mail.gmail.com>
From: Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <CAMuHMdVig-cm7KPi76ow9-xyZ55z4YgYrx6QuO9V5A0ni7HxDA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable


On 3/20/24 01:08, Geert Uytterhoeven wrote:
> On Tue, Mar 19, 2024 at 6:01=E2=80=AFPM Bart Van Assche <bvanassche@acm=
org> wrote:
>> run SCSI kunit tests is available below. And if there is a desire to r=
un
>> SCSI tests on the target system, how about adding triggers in sysfs fo=
r
>> running kunit tests? The (GPL v2) Samsung smartphone kernel supports
>> this but I have not yet checked whether their implementation is
>> appropriate for the upstream kernel.
>=20
> That would require all tests to be built-in, reducing the amount of mem=
ory
> (if any remains at all) available to the real application.

It would be great if it would be possible to convert scsi_lib_test.c
into a kernel module without exporting the functions that are being
tested. Exporting functions from scsi_lib.c only because these are
called from code in scsi_lib_test.c is not desired. More tests may be
added in the future into scsi_lib_test.c. If that would result in
exporting every static scsi_lib.c function that would make the SCSI core
harder to maintain than necessary.

Thanks,

Bart.